openforis / sepal

Geographical Data Processing in the Cloud
https://sepal.io/
MIT License
205 stars 46 forks source link

Add resilient rivers and basins app to sepal dashboard #180

Closed dfguerrerom closed 2 years ago

dfguerrerom commented 2 years ago

What is the name of your repository ?
https://github.com/sepal-contrib/basin-rivers

The name of your dashboard app
Resilient rivers and basins (Beta)

A short description of the app
Get Forest Cover Change by upstream sub-catchment

Is your module requiring a GEE account ?
Yes

Any comment you want to add
It will require plotly and seaborn. Versions are in the requirements file.

maintainer checklist

12rambau commented 2 years ago

@dfguerrerom I was looking at the requirements of your app, how can it work with GEE without having the gee api in the requirements ? (https://github.com/sepal-contrib/basin-rivers/blob/master/requirements.txt) ?

dfguerrerom commented 2 years ago

Ooops! I think it's working because the app is using the default Sepal environment... but, as the tool is not instantiated in sepal yet, there is no env to link with... yes, I have to add the GEE requirement, and then change the notebooks metadata to use the new kernel.

12rambau commented 2 years ago

also based on your screenshot, it's based on sepal_ui 2.7.0 (including locale and theme management) which is not yet published. I'll post it here when it's released.

dfguerrerom commented 2 years ago

Although theme and locale are in the app (because I was using master sepal_ui installation to create screenshot), the tool is working with 2.6.2, theme, and locale don't affect the functionality of the tool.

dfguerrerom commented 2 years ago

@cdanielw, I've tested the module in a test environment, and it works properly.

cdanielw commented 2 years ago

Done.