search

opengapps / opengapps-app-support

issuetracker and translations for the Open GApps App
http://opengapps.org/app
Creative Commons Attribution Share Alike 4.0 International
61 stars 57 forks source link

Italian translation update for v. 1.1 #84

Closed bovirus closed 7 years ago

mention-bot commented 7 years ago

@bovirus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mfonville and @rapperskull to be potential reviewers.

mfonville commented 7 years ago

@bovirus thanks for the PR; It seems it was based on a real old version of the repo, that is why the commit seems to give a conflict. I at least put your text versus the current one in a diff, so that we can at least see the differences at the moment more clearly: https://www.diffchecker.com/dmsEurzG

bovirus commented 7 years ago

@mfonville

Sorry but I didn't understand.

I checked all <string name="xxx" in my betweeen original and my language proposal and also if they are tagged as different are equal.

Than really the difference are in the string contents and not on string name.

I re-download master from repository and compared with my language proposal and there are NO differences in string variable name but only in the strings values.

Thanks.

mfonville commented 7 years ago

@bovirus don't worry about it, it is a version control thing; I now fixed it for you, I am sure that if you do it more often you will learn the perks.

With this updated version, I will comment on some of the proposed changes. Hopefully @rapperskull can also give his opinion

rapperskull commented 7 years ago

I'll also check for other changes soon.

bovirus commented 7 years ago

@rapperskull For me: Download as single word in a phrase (es. as menu command) should be "Download" or "Download MD5" (more clear than "Scarica"). If you you use Download in a description you should use "Scarica..." ex. "Scarica la checksum MD5". "Mostra" is not right as informatic term. It's "Visualizza". Please check Adobe/Microsoft/etc programs. It's the same for "Mostrare". It's used probably in not professional software. The professional sofwtare use "Visualizzare".

rapperskull commented 7 years ago

I commented with all the proposed changes. Sorry for the delay, I was very busy.

beatbrot commented 7 years ago

@bovirus It would be great if you could apply the changes suggested by @rapperskull until tomorrow 12am MEZ as we want to schedule a release quite soon

beatbrot commented 7 years ago

And with MEZ I actually meant CET (Central Europe Time) ;)

beatbrot commented 7 years ago

Alright, unfortunately @bovirus couldnt meat the (admittedly too tight) deadline and therefore I made the suggested fixes where possible. If you want to make further changes, feel free to create a new PR for our next release!

bovirus commented 7 years ago

I'm so sorry but I'm quite busy for company moving (and many times I'm offline). I will open a new thread for new version. Please take care that I didn't have a so big knowledge about github tastks.

beatbrot commented 7 years ago

@bovirus No problem :) I do appreciate your help! :) And of course we all have lives apart from opengapps :P

Also my deadline was unfortunately a bit too tight, sorry for that :)