search

opengeospatial / GeoPose

OGC GeoPose development.
Apache License 2.0
41 stars 17 forks source link

Quaternion property #4

Closed michaelvogt closed 3 years ago

michaelvogt commented 3 years ago

This might not be considered an issue, it's more about consistency.

In 7.4.1 basic-quaternion, the property for the quaternion is 'quaternion'. In 7.4.2 basic-euler, the property of the euler angles is 'rotations'.

Then from 7.4.4 on, the property name for quaternions is 'rotation'. This gives me the impression, that the value is euler angles.

Having consistent property names for quaternions and a different property name for euler angles (for example 'angles') would remove such confusion.

3DXScape commented 3 years ago

Good catch. It should always be quaternion for quaternions and rotations for Euler angles. This is an internal consistency issue. Proposed resolution: edit the text to reflect the issue as raised.

3DXScape commented 3 years ago

Updated schemata in documents.

3DXScape commented 3 years ago

No further comments so closed as resolved per previous comments.