openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: IRXCT: Iterative Reconstruction and visualization application for X-ray Computed Tomography #1588

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @dntrinca (D Narcis Trinca) Repository: https://github.com/dntrinca/IRXCT Version: 1.0 Editor: @usethedata Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @dntrinca. Currently, there isn't an JOSS editor assigned to your paper.

@dntrinca if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1588 with the following error:

Can't find any papers to compile :-(

danielskatz commented 5 years ago

@dntrinca - this submission has some problems - the source code being in a zip file is one. We expect to see the software in a version control repository (eg github) but in a way that the software can be updated via pull requests and changes - a zip file doesn't really work for that.

danielskatz commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1588 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:115:in check_fields': Paper YAML header is missing expected fields: affiliations (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:80:ininitialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/processor.rb:36:inset_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:inrun' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:indispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/bin/whedon:116:in<top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

danielskatz commented 5 years ago

Also, please follow the example paper to use affiliations correctly - they need to be marked as integer indexes in the authors section, then these indexes need to be used in the affiliations section.

Once you have made changes, please feel free to enter @whedon generate pdf here as a new comment in this issue to try to build the paper again.

ghost commented 5 years ago

Dear Daniel Skatz,

I just made the necessary corrections you have mentioned.

Best, D Narcis

ghost commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1588 with the following error:

Error reading bibliography ./paper.bib (line 24, column 3): unexpected "j" expecting space or "}" Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

ghost commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1588 with the following error:

Error reading bibliography ./paper.bib (line 29, column 1): unexpected "@" expecting space, ",", white space or "}" Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

ghost commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ghost commented 5 years ago

Dear Daniel S Katz,

Sorry for mispelling your name in a previous reply.

Best, D Narcis

danielskatz commented 5 years ago

Please carefully proofread your submission, and add DOIs to the bib entries for papers that have DOIs, again following the example in the JOSS documentation.

danielskatz commented 5 years ago

👋 @usethedata - would you be willing to edit this submission?

ghost commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ghost commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ghost commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

usethedata commented 5 years ago

@whedon assign @usethedata as editor

whedon commented 5 years ago

OK, the editor is @usethedata

usethedata commented 5 years ago

@dntrinca This is interesting work and thanks for your submission. However, we need to get a few more things take care of before this is ready to be reviewed. The biggest is that the readme should be more extensive. This is the key thing. There should also be guidelines for people wanting to contribute to the effort and for those who are looking for support. Please see the review criteria (https://joss.readthedocs.io/en/latest/review_criteria.html) for what we ask the reviewers to evaluate.

ghost commented 5 years ago

Dear Bruce Wilson, I will prepare this and reply to you soon. Best, D Narcis

ghost commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ghost commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ghost commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ghost commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ghost commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1588 with the following error:

Error reading bibliography ./paper.bib (line 62, column 1): unexpected end of input expecting space, ",", white space or "}" Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

ghost commented 5 years ago

@whedon generate pdf