search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: TorchGAN: A Flexible Framework for GAN Training and Evaluation #2606

Closed whedon closed 3 years ago

whedon commented 4 years ago

Submitting author: @avik-pal (Avik Pal) Repository: https://github.com/torchgan/torchgan/ Version: v0.0.4 Editor: @arfon Reviewers: @NMontanaBrown, @terrytangyuan Archive: 10.5281/zenodo.5575758

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/78a73cb647a355a8d6826ad2f2086bcc"><img src="https://joss.theoj.org/papers/78a73cb647a355a8d6826ad2f2086bcc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/78a73cb647a355a8d6826ad2f2086bcc/status.svg)](https://joss.theoj.org/papers/78a73cb647a355a8d6826ad2f2086bcc)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@Paul92, @urbanophile, @NMontanaBrown, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @terrytangyuan know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @NMontanaBrown

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @Paul92, @urbanophile it looks like you're currently assigned to review this paper :tada:.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 4 years ago

PDF failed to compile for issue #2606 with the following error:

Can't find any papers to compile :-(

avik-pal commented 4 years ago

@whedon generate pdf from branch ap/joss_paper

whedon commented 4 years ago 
Attempting PDF compilation from custom branch ap/joss_paper. Reticulating splines etc...
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

kthyng commented 4 years ago

Hello! I am the rotating associate editor in chief and am checking in on stale reviews. Will reviewers @Paul92, @urbanophile have a chance to start on/continue your reviews sometime soon? It's been over a month since the review started. Thanks!

urbanophile commented 4 years ago

Hi apologies, yes. I will continue on the review.

avik-pal commented 3 years ago

bump.

terrytangyuan commented 3 years ago

@Paul92 and @urbanophile, did you get a chance to review this yet?

arfon commented 3 years ago

:wave: @Paul92 and @urbanophile - could you please update us on the status of your reviews?

arfon commented 3 years ago

I've just emailed both @Paul92 and @urbanophile to see if they are able to return to this review sometime soon. I'm sorry this is taking so long @avik-pal.

arfon commented 3 years ago

@avik-pal - I'm afraid I think we need to find some new reviewers here 😞 . Could you take a look a this list of potential reviewers and identify a few people who would be good candidates to review this submission?

arfon commented 3 years ago

@whedon assign me as editor

arfon commented 3 years ago

@vs74 @NMontanaBrown - would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission we'd be asking you to review is TorchGAN: A Flexible Framework for GAN Training and Evaluation

NMontanaBrown commented 3 years ago

Hi @arfon, I should be able to, if this is still in need of a reviewer.

arfon commented 3 years ago

Hi @arfon, I should be able to, if this is still in need of a reviewer.

Yes please! I'll go ahead and set you up on the review now.

arfon commented 3 years ago

@whedon add @NMontanaBrown as reviewer

whedon commented 3 years ago

OK, @NMontanaBrown is now a reviewer

arfon commented 3 years ago

@whedon re-invite @NMontanaBrown as reviewer

whedon commented 3 years ago

@nmontanabrown already has access.

arfon commented 3 years ago

@NMontanaBrown - Please read the "Reviewer instructions & questions" in the first comment above.

As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention https://github.com/openjournals/joss-reviews/issues/2606 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule.

Thanks again for your help here!

arfon commented 3 years ago

:wave: folks. Checking in here to see how things are going. @NMontanaBrown it seems like you made it a good way through your review but might be waiting on @avik-pal to make some updates?

arfon commented 3 years ago

@whedon remove @urbanophile as reviewer

whedon commented 3 years ago

OK, @urbanophile is no longer a reviewer

arfon commented 3 years ago

@whedon remove @Paul92 as reviewer

whedon commented 3 years ago

OK, @Paul92 is no longer a reviewer

arfon commented 3 years ago

:wave: @thelinuxmaniac @smith42 – would either of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission we'd be asking you to review is TorchGAN: A Flexible Framework for GAN Training and Evaluation. We already have one review complete and are seeking a second reviewer to wrap up our review process.

NMontanaBrown commented 3 years ago

👋 folks. Checking in here to see how things are going. @NMontanaBrown it seems like you made it a good way through your review but might be waiting on @avik-pal to make some updates?

I am waiting on the updates regarding unit tests to assert the functionality of the package, raised in this ticket before finishing the review.

arfon commented 3 years ago

I am waiting on the updates regarding unit tests to assert the functionality of the package, raised in this ticket before finishing the review.

Got it. Thanks for the update! @avik-pal – are you planning on making these changes sometime in the not-too-distant future?

avik-pal commented 3 years ago

Yes, I am planning to do it by the end of this month. Apologies for the delay. I was in the middle of graduation and shifting and hence haven't been able to work on the tests.

arfon commented 3 years ago

Friendly reminder to get to these changes when you can @avik-pal 😄

avik-pal commented 3 years ago

Sorry I should have updated here (I mentioned in the other issue). The tests have been updated

NMontanaBrown commented 3 years ago

@avik-pal thanks, list completed @arfon

arfon commented 3 years ago

:wave: @yxoos –  would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

We already have one review from @NMontanaBrown and are looking for a second reviewer to help us wrap up the JOSS review process.

The submission we'd be asking you to review is TorchGAN: A Flexible Framework for GAN Training and Evaluation. We already have one review complete and are seeking a second reviewer to wrap up our review process.

danielskatz commented 3 years ago

@arfon - just a ping on this...

arfon commented 3 years ago

I've asked @terrytangyuan if he's willing to provide a second review here.

@avik-pal – I'd still welcome any help you might be able to provide to identify a second reviewer here.

terrytangyuan commented 3 years ago

Yes, I am happy to switch to the reviewer for this submission and my review is actually going to be quick as I initially spent some time looking through this submission as an editor previously.

terrytangyuan commented 3 years ago

@whedon add @terrytangyuan as reviewer

whedon commented 3 years ago

OK, @terrytangyuan is now a reviewer

terrytangyuan commented 3 years ago

Review checklist for @terrytangyuan

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

terrytangyuan commented 3 years ago

@avik-pal Just some small feedback. Not a blocker but nice to have.

  1. There might be some papers that you cited in arXiv but have been published to somewhere more formally. Could you check and update them accordingly?
  2. The paper has been here for a year and some things might have been changed, such as the feature tables for existing frameworks. Could you update those wherever necessary? If the API of TorchGAN has changed, please update as well.
arfon commented 3 years ago

@avik-pal – how are you getting on with the reviewer feedback here?

avik-pal commented 3 years ago

@whedon generate pdf from branch ap/joss_paper

whedon commented 3 years ago 
Attempting PDF compilation from custom branch ap/joss_paper. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 3 years ago

@avik-pal – have you made changes to your submission based on the reviewer feedback?

avik-pal commented 3 years ago

Yes the latest pdf has the updated references

arfon commented 3 years ago

@avik-pal – At this point could you make a new release of this software that includes the changes that have resulted from this review. Then, please make an archive of the software in Zenodo/figshare/other service and update this thread with the DOI of the archive? For the Zenodo/figshare archive, please make sure that:

I can then move forward with accepting the submission.

avik-pal commented 3 years ago

@arfon I have uploaded the archive to Zenodo: https://doi.org/10.5281/zenodo.5575758

arfon commented 3 years ago

@whedon set 10.5281/zenodo.5575758 as archive