search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
708 stars 38 forks source link

[REVIEW]: TorchGAN: A Flexible Framework for GAN Training and Evaluation #2606

Closed whedon closed 2 years ago

whedon commented 4 years ago

Submitting author: @avik-pal (Avik Pal) Repository: https://github.com/torchgan/torchgan/ Version: v0.0.4 Editor: @arfon Reviewers: @NMontanaBrown, @terrytangyuan Archive: 10.5281/zenodo.5575758

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/78a73cb647a355a8d6826ad2f2086bcc"><img src="https://joss.theoj.org/papers/78a73cb647a355a8d6826ad2f2086bcc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/78a73cb647a355a8d6826ad2f2086bcc/status.svg)](https://joss.theoj.org/papers/78a73cb647a355a8d6826ad2f2086bcc)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@Paul92, @urbanophile, @NMontanaBrown, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @terrytangyuan know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @NMontanaBrown

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 2 years ago

OK. 10.5281/zenodo.5575758 is the archive.

arfon commented 2 years ago

@whedon recommend-accept from branch ap/joss_paper

whedon commented 2 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 2 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/2690

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/2690, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true from branch ap/joss_paper
whedon commented 2 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/cvpr.2016.90 is OK
- 10.1109/cvpr.2017.243 is OK
- 10.1109/iccv.2017.304 is OK
- 10.1109/iccv.2017.244 is OK
- 10.1109/cvpr.2017.19 is OK
- 10.1109/cvpr.2018.00916 is OK

MISSING DOIs

- 10.1109/cvpr.2018.00165 may be a valid DOI for title: MoCoGAN: Decomposing Motion and Content for Video Generation

INVALID DOIs

- None
arfon commented 2 years ago

@whedon accept deposit=true from branch ap/joss_paper

whedon commented 2 years ago 
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 2 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon commented 2 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/2692
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.02606
  3. If everything looks good, then close this review issue.

  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

    Any issues? Notify your editorial technical team...

arfon commented 2 years ago

@NMontanaBrown, @terrytangyuan – many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@avik-pal – your paper is now accepted and published in JOSS :zap::rocket::boom:

whedon commented 2 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02606/status.svg)](https://doi.org/10.21105/joss.02606)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02606">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02606/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02606/status.svg
   :target: https://doi.org/10.21105/joss.02606

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: