Closed editorialbot closed 1 year ago
editorialbot
commented
1 year ago Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@editorialbot commandsFor example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@editorialbot generate pdfSoftware report:
github.com/AlDanial/cloc v 1.88 T=0.16 s (199.1 files/s, 109118.5 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
Java 23 2312 4738 9701
Markdown 6 121 0 248
Maven 1 41 2 189
TeX 1 17 0 146
YAML 1 3 5 18
-------------------------------------------------------------------------------
SUM: 32 2494 4745 10302
-------------------------------------------------------------------------------
gitinspector failed to run statistical information for the repositoryWordcount for paper.md is 1042
editorialbot
commented
1 year ago Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1111/j.1365-313x.2012.04927.x is OK
- 10.1002/mrc.4905 is OK
- 10.1186/s13628-014-0015-1 is OK
- 10.1104/pp.15.01388 is OK
- 10.1016/j.neuroimage.2020.116884 is OK
- 10.5281/zenodo.4518730 is OK
- 10.1109/icip.2019.8804298 is OK
- 10.1093/bioinformatics/btaa846 is OK
- 10.1016/0022-2364(76)90133-5 is OK
- 10.21105/joss.02343 is OK
- 10.1002/mrm.22178 is OK
- 10.1016/j.postharvbio.2009.02.004 is OK
- 10.1016/j.jmr.2012.12.019 is OK
MISSING DOIs
- None
INVALID DOIs
- None:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
britta-wstnr
commented
1 year ago Hello again! 👋
@Rocsg
@MaximLippeveld, @kasasxav, @hinerm
This is the review thread for the paper. All of our higher-level communications will happen here from now on, review comments and discussion can happen in the repository of the project (details below).
📓 Please read the "Reviewer instructions & questions" in the comment from our editorialbot (above).
✅ All reviewers get their own checklist with the JOSS requirements - you generate them as per the details in the editorialbot comment. As you go over the submission, please check any items that you feel have been satisfied.
💻 The JOSS review is different from most other journals: The reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention https://github.com/openjournals/joss-reviews/issues/4981 so that a link is created to this thread. That will also help me to keep track!
❓ Please also feel free to comment and ask questions on this thread.
🎯 We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule.
MaximLippeveld
commented
1 year ago 
hinerm
commented
1 year ago britta-wstnr
commented
1 year ago ping @kasasxav -- gentle reminder about this review, see above for more details on what to do next. 🙂
kasasxav
commented
1 year ago kasasxav
commented
1 year ago Hi, Thanks for inviting me to review this work @britta-wstnr and sorry for the delay! I took a first look into the project, and I can see an extensive documentation including installation details and video tutorials describing the functions of FijiRelax, both in the github repo but also in the ImageJ website. It looks great! I didn't have the chance to test it yet, but I took a look at the documentation and paper and I have some comments, I believe the author can start with this corrections until I can further test the functionality of the software.
Documentation
Some corrections (in github README):
Paper
Some corrections
Best, Xavier.
Rocsg
commented
1 year ago Hello @britta-wstnr and @kasasxav , Here is a point-by-point answer following the integration of requests from Xavier :
Hi, Thanks for inviting me to review this work @britta-wstnr and sorry for the delay! I took a first look into the project, and I can see an extensive documentation including installation details and video tutorials describing the functions of FijiRelax, both in the github repo but also in the ImageJ website. It looks great! I didn't have the chance to test it yet, but I took a look at the documentation and paper and I have some comments, I believe the author can start with this corrections until I can further test the functionality of the software.
Requests :
Documentation A requirement for GPL-2.0 is to add a file notice at the beginning of each file (see https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html). I see that your files do not have the file notice, so I believe it is needed for a successful review. I also recommend upgrading it to GPL-3.0 although 2.0 is also fine.
Answer : As requested, we met this requirement by adding a file notice at the beginning of each file, indicating authorship and a reminder of the GPL2.0 licence.
In the github repo you do explain what is the context of the software, however I am missing a clear Statement of Need where you describe throughly what type of problems your tool can solve, for the developer but also the general users. I can see that you have it in the paper, however JOSS requires that you have it in the documentation too - maybe just a smaller and general version of it.
Answer : We included the Statement of need section to the official ImageJ plugin page, after refactoring this section (see Question 5)
Could you elaborate in how you perform tests? It is a requirement for the review process, however I understand it is hard to do as Github actions as your software is a plugin of ImageJ. Maybe in this case manual testing could be an option? I suggest in this case you could have a separate documentation file in your repo describing different steps to follow to test the software (maybe a checklist?).
Answer : We added in the repo a file TESTING_AND_RELEASING_HOW-TO.md describing the rationale, how-to and when-to of testing (through maven test) and releasing FijiRelax (jar and code)
Some corrections (in github README): I would add the funding in a separate section "Funding", here you have it in the very beginning (suggestion). "This tools is developed" -> are "FijiRelax needs properly formatted dataset" -> article missing, "a properly formatted dataset". "FijiRelax interface have four main panels" -> has, and also FijiRelax's interface or the interface of FijiRelax. "Unit for the channels 2 and 3 are milliseconds, what mean you can use it like it" -> meaning or which means. "(the same, with an additional" -> I would remove "the same" "This plugin compute" -> computes When you mention the license, add the version "2.0".
Answer : Thank you for the careful proof-reading. We included all requested modifications.
Paper You briefly mention how FijiRelax compares to other software in your Statement of Need, however I think it is better to provide a separate section "State of the field" and explain it in more words. Also when you describe the capabilities, I feel that this shouldn't be in the statement of need either. I would add a section that explains the features of the plugin (or maybe add it in State of the Field pointing out that other software packages do not have those capabilities), and also provide more information about figure 1 to strengthen your claims and help the reader understand the potential of your plugin. I really like that you explain how it can benefit to different users, so I think the best is to go straight to that in your Statement of Need.
Answer : We proposed a refactoring of the statement of need, including : A section “Statement of need” going straight to how FijiRelax can benefit to different users. A section “State of the field”, including a paragraph about benchmarking, introducing capabilities, followed by the list of the main features. We hope that this modification fits well with the request.
Paper I see that you have an API and some directions for developers. I would also suggest adding a sentence about it in the software Documentation, and maybe even in the contributing file.
Answer : As requested, we copied the paper paragraph indicating the three type of users and their possibilities with Fijiyama, and integrating it as an accessibility disclaim in the CONTRIBUTING.md file
The references are not ordered by appearance in the text. Is there a reason for it? Otherwise I suggest reordering them.
Answer : We checked that point by checking the refs order in the .bib, by recompiling it, and by checking already published papers in JOSS. From our observations, it seems that this is the result of the automatic compilation using the template of JOSS, making the reference appearing by alphanumeric order.
Some corrections line 17 "dramatically reduces parameters estimation accuracy" -> dramatically reduces the estimation accuracy of the parameters. Or: reduces the parameters' estimation accuracy. In the legend of Figure 1: "results of map computation" and "results of drift artifacts" missing article "the".
Answer : Thank you again for the careful proof-reading. We included all requested modifications.
MaximLippeveld
commented
1 year ago @editorialbot generate pdf
editorialbot
commented
1 year ago :point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
MaximLippeveld
commented
1 year ago Hi, thanks for the interesting submission! Here are my findings.
I went through the installation process as described on the ImageJ plugin page and everything went smoothly. To test the software I downloaded the dataset from Zenodo and I was able to run Tutorial 2. I ran into a problem when running one of the Figure reproduction scripts and made an issue on the FijiRelax repo: https://github.com/Rocsg/FijiRelax/issues/5
In the paper, I find the second sentence of the summary unclear for a non-specialist audience: "This unique capability is useful to decipher the impacts of stresses on living samples." What unique capability is referenced here? Is it the fact that qMRI can be used to measure water availability and binding or that it can do it in animal or vegetal tissues? The current wording also makes it seem like qMRI is only used to decipher the impacts of stresses on living samples. Is that the case? If not, I would word it like "Among others, MRI is useful to decipher the impacts ..."
Please also provide instructions on how to reproduce the claim of Figure 1f stating that FijiRelax is 100 times quicker compared to other implementations.
Thanks, Maxim
kasasxav
commented
1 year ago Hi @Rocsg,
thank you for the corrections! I checked some more boxes in the checklist, from the feedback I gave earlier I'm good with your changes.
I also installed the software and tested it with Tutorial 1 and it works smothly, I identified though one bug when running it on my screen and opened an issue (https://github.com/Rocsg/FijiRelax/issues/6). I also plan on going through Tutorial 2, I will let you know if I have further comments on that.
Best, Xavier.
britta-wstnr
commented
1 year ago Thank you @kasasxav and @MaximLippeveld for making such great progress on the reviewing! 🌟 A quick reminder that you can also address issues directly in the toolbox' repository (just link to the issues or PRs here as well). As always, feel free to ping me if you have any questions!
Rocsg
commented
1 year ago Hello @MaximLippeveld . We produce a point-by-point answer to your requests : Overview : Hi, thanks for the interesting submission! Here are my findings. I went through the installation process as described on the ImageJ plugin page and everything went smoothly. To test the software I downloaded the dataset from Zenodo and I was able to run Tutorial 2.
Requests :
Question 1 “Reproducibility issue with figure 1-a” : I ran into a problem when running one of the Figure reproduction scripts and made an issue on the FijiRelax repo: Rocsg/FijiRelax#5
Answer : We have fixed the bug and closed the issue. Additionally, we have worked on the versioning of the beanshell scripts. The previous method of storing the scripts in a Zenodo archive was not user-friendly, so we have moved them to the github repository at https://github.com/Rocsg/FijiRelax/tree/master/test/Scripts . We have also removed the scripts from the Zenodo archive and updated the README files in FijiRelax to explain their location for future users. This will make it easier for users to access the scripts.
Question 2 “Clarification required in the paper” : In the paper, I find the second sentence of the summary unclear for a non-specialist audience: "This unique capability is useful to decipher the impacts of stresses on living samples." What unique capability is referenced here? Is it the fact that qMRI can be used to measure water availability and binding or that it can do it in animal or vegetal tissues? The current wording also makes it seem like qMRI is only used to decipher the impacts of stresses on living samples. Is that the case? If not, I would word it like "Among others, MRI is useful to decipher the impacts ..."
Answer : We understand your concern about the wording and have incorporated your suggestion into the paper by stating "Among others, MRI…
Question 3 “How to reproduce performance tests” : Please also provide instructions on how to reproduce the claim of Figure 1f stating that FijiRelax is 100 times quicker compared to other implementations.
Answer : As requested, we have made the performance tests reproducible and documented them for publication in JOSS. These tests only measure the computation time for the fitting process and do not include any loading time for the application or data. The original performance tab was created months ago, and since then, MyRelax has implemented multi-threaded computation and eventually other improvements that speeds up the fitting process. As a result, MyRelax is now only 4.6 times slower than FijiRelax, which is a significant improvement. We apologize for our previous statement that MyRelax was 100 times slower and we update the text in the paper to reflect this new information: “FijiRelax offers both scripting capabilities and a graphic interface, and is 4 times faster than the Python implementation and 100 times faster than the Matlab implementation (see computation time benchmark in \autoref{fig:figure1}-f), while including noise-corrected fitting and spatial drift correction.”
We also decided to include the release number of the benchmarked software to ensure the accuracy of our statements over time. For QMRLab (the Matlab part), we were unable to find a documented way to multi-thread the process, and the timing is quite unchanged.
Now the instructions for repeating the experiments with FijiRelax, MyRelax and QMRLab can be found in the Github repository, including path to scripts, instructions to reproduce, and release versions of the software used: FijiRelax/REPRODUCING_EXPERIMENTS.md These modifications are integrated into the new release, patch v4.0.4 - Xavier/Maxim We appreciate your request for this important investigation, which has had a significant impact on our results and claims.
MaximLippeveld
commented
1 year ago @editorialbot generate pdf
editorialbot
commented
1 year ago :point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Rocsg
commented
1 year ago @MaximLippeveld , please note that while the new code is up-to-date, the updated DOI dataset is currently under uploading. The previous version of the dataset could cause a failure of the script_f for editing the benchmarking values for FijiRelax due to refactoring in the data structure. The new DOI should be online in the evening, depending on the Upload capacity of my internet connection. Conversely, I think that the other experiments are available.
MaximLippeveld
commented
1 year ago Thank you @kasasxav and @MaximLippeveld for making such great progress on the reviewing! star2 A quick reminder that you can also address issues directly in the toolbox' repository (just link to the issues or PRs here as well). As always, feel free to ping me if you have any questions!
@britta-wstnr Should we also address issues relating to the paper as an issue in the the toolbox' repository? Or should those comments be made in this thread?
hinerm
commented
1 year ago Hi @Rocsg! I'm almost done with my review. I added a couple of issues that I'd like to see resolved:
README.mdI also added two issues that are optional but I thought might make things nicer for you:
Other comments:
zulu8.60.0.21-ca-fx-jdk8.0.322-win_x64) the ImageJ-ITK update site is currently broken, because that JDK has some sort of issue loading native libraries (discussion here and here). This is not your fault at all and has nothing to do with your plugin, but since it could affect your users I wanted you to be aware. The current work-around is to use a different Java version.Script_import_and_compute_all_time_series BeanShell script in tutorial-02-time-lapse-sorgho was broken for me. It was just missing two import statements:
import io.github.rocsg.fijiyama.common.VitiDialogs;
io.github.rocsg.fijiyama.fijiyamaplugin.RegistrationAction;Since that was the script used in your tutorials that was the only one I checked, but you might want to double-check others.
hinerm
commented
1 year ago @Rocsg note that I ran into some errors trying to reproduce your benchmark. I will try and take a closer look tomorrow.
Rocsg
commented
1 year ago Hello @hinerm ,
Overall, I am grateful for your suggestions, I learned a lot about ImageJ/CI. There is still room to improve my coding patterns and ImageJ lib usage to make me a better contributor to ImageJ ecosystem, I’ll do it on the way.
I implemented your required evolutions. I tried to do the same for your suggestions, but I kept being stuck at some point with github actions. It seems that since maven 3.8, there is a need to “force” maven to authorize gathering dependencies from http: links, which is needed for VIB-lib. I tried to implement a fix in the workflow, but to date, the fix does not work.
In addition, while you did not ask it, It seems to me that using “SNAPSHOT-like” deploying pattern could allow making automatic jar deployment on push from github to maven (and eventually to sites.imagej.net/Fijiyama). That kind of thing should be really nice to foster community involvement (i.e : automatic sync of maven for each push / accepted pr).
Finally, I used your method to fix the point with ImageJ-ITK which is very nice for our Windows users.
Here is a point-by-point answer to your review, whereas I will answer then to your issues, which is a very convenient way to work.
Overview: Hi @Rocsg! I'm almost done with my review. I added a couple of issues that I'd like to see resolved: Question 1: Adding a Support section in the README.md
Answer: Thank you for this suggestion. We added a support section, following your suggestions. To date, the “support” procedure was to write a mail to me (my personal mail appears here and there in the GUI). But it seems that it cannot be the single way to get support, and added official support, following your suggestions.
Question 2: Making the unit tests work on all systems
Answer: We worked on the exact setup you proposed. It seems to be going well. Thank you again. I closed the issue
Question 3: I also added two issues that are optional but I thought might make things nicer for you: Adding a parent pom Answer: We worked on the exact setup you proposed. It seems to be going well.
Question 4: Building with GitHub acitons
Answer: Stuck at a point with a dependence on VIB-lib, requiring to fetch dependence with http: unsecured link (unauthorized since maven 3.8). I keep you in touch.
Question 5: Other comments: On Windows with the JDK that is currently shipped with Fiji (zulu8.60.0.21-ca-fx-jdk8.0.322-win_x64) the ImageJ-ITK update site is currently broken, because that JDK has some sort of issue loading native libraries (discussion here and here). This is not your fault at all and has nothing to do with your plugin, but since it could affect your users I wanted you to be aware. The current workaround is to use a different Java version.
Answer: I really appreciate your help on that point. I reproduced the bug under Windows, and managed a quickfix. I set a showMessage() warning for Windows/Zulu users at the opening of FijiRelax and Fijiyama which refers to the installation guide of FijiRelax, linking to the procedure to follow for using a different Java.
Question 6: I'm not sure I'm seeing the latest DOI since the date still says Feb 2021... but the Script_import_and_compute_all_time_series BeanShell script in tutorial-02-time-lapse-sorgho was broken for me. It was just missing two import statements: import io.github.rocsg.fijiyama.common.VitiDialogs; io.github.rocsg.fijiyama.fijiyamaplugin.RegistrationAction; Since that was the script used in your tutorials that was the only one I checked, but you might want to double-check others.
Answer: You’re right, the DOI was ancient AND broken. I updated this Wednesday, you can download the new version https://doi.org/10.5281/zenodo.4518730 V5. There is still one script called from the tutorial (that is the one you used. The other ones are not required and not provided anymore. I also changed a bit the setup: as suggested by Xavier, keeping the reproduction scripts in the DOI is not good. I versioned them in Github in test/Scripts/Beanshell_Scripts. I ran double-check on this. However, if you notice any issues, you can tell me.
hinerm
commented
1 year ago @Rocsg I was able to get the new DOI and reproduce your times! Mine were slightly different, but pretty close (my Octave was even slower!). I did have to turn off IJ.log to get close to a 4x speedup on my system.
I included Matlab in my tests, which is much faster than Octave but still 10x slower than FijiRelax - but I don't think that needs to be tested in your paper since it's not an open product, right?
Regardless, I opened a PR to make your test scripts work in MATLAB, but also not required. Everything worked in Octave out of the box.
Stuck at a point with a dependence on VIB-lib, requiring to fetch dependence with http: unsecured link (unauthorized since maven 3.8). I keep you in touch
You're so close - you just need to update the repository block in your pom to use https! 😄
In addition, while you did not ask it, It seems to me that using “SNAPSHOT-like” deploying pattern could allow making automatic jar deployment on push from github to maven (and eventually to sites.imagej.net/Fijiyama). That kind of thing should be really nice to foster community involvement (i.e : automatic sync of maven for each push / accepted pr).
I opened an issue to keep track of this - definitely not required for the article though!
@britta-wstnr thanks for making the review process so easy!
Rocsg
commented
1 year ago Hello @hinerm . I answered to your additional requests. Thank you again for your comments and advices!
Rocsg
commented
1 year ago Hello @britta-wstnr @kasasxav @MaximLippeveld @hinerm , Thank you for your reviews which we carefully addressed. I believe we have responded to all requests made, and the software is clearly improved as a result.
I am available for any further requests.
Romain
britta-wstnr
commented
1 year ago Hello everyone,
sorry for a bit of radio silence on my end, I was on my end-of-year leave (I realize now that I forgot to give a heads-up in this thread about it, apologies!).
It looks like all reviewers @kasasxav, @hinerm, @MaximLippeveld have checked all the boxes in their checklist. Is there anything you three still would like to have addressed at this stage?
Thanks everyone for such a smooth process so far! ☺️ 💚
hinerm
commented
1 year ago Is there anything you three still would like to have addressed at this stage?
@britta-wstnr I think everything I brought up has been addressed, so I'm good!
MaximLippeveld
commented
1 year ago @britta-wstnr I'm also happy with the state of the paper and software.
kasasxav
commented
1 year ago @britta-wstnr All good from my side!
britta-wstnr
commented
1 year ago @editorialbot generate pdf
editorialbot
commented
1 year ago :point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
britta-wstnr
commented
1 year ago @editorialbot check references
editorialbot
commented
1 year ago Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1111/j.1365-313x.2012.04927.x is OK
- 10.1002/mrc.4905 is OK
- 10.1186/s13628-014-0015-1 is OK
- 10.1104/pp.15.01388 is OK
- 10.1016/j.neuroimage.2020.116884 is OK
- 10.5281/zenodo.4518730 is OK
- 10.1109/icip.2019.8804298 is OK
- 10.1093/bioinformatics/btaa846 is OK
- 10.1016/0022-2364(76)90133-5 is OK
- 10.21105/joss.02343 is OK
- 10.1002/mrm.22178 is OK
- 10.1016/j.postharvbio.2009.02.004 is OK
- 10.1016/j.jmr.2012.12.019 is OK
MISSING DOIs
- None
INVALID DOIs
- NoneThanks for confirming, @kasasxav, @MaximLippeveld, and @hinerm!
@Rocsg I went over the pdf and opened a PR to fix some typos. Please make sure to check the pdf yourself as well for things you might want to fix before the publication. The formal things (like references) seem to be okay.
Once the pdf is in shape, we can move on!
Rocsg
commented
1 year ago @editorialbot generate pdf
editorialbot
commented
1 year ago :point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Rocsg
commented
1 year ago Hello @britta-wstnr , As the two authors, we carefully checked the pdf, fixed some typos and committed the changes. We are ready to move on.
oliviaguest
commented
1 year ago @editorialbot check references
editorialbot
commented
1 year ago Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1111/j.1365-313x.2012.04927.x is OK
- 10.1002/mrc.4905 is OK
- 10.1186/s13628-014-0015-1 is OK
- 10.1104/pp.15.01388 is OK
- 10.1016/j.neuroimage.2020.116884 is OK
- 10.5281/zenodo.4518730 is OK
- 10.1109/icip.2019.8804298 is OK
- 10.1093/bioinformatics/btaa846 is OK
- 10.1016/0022-2364(76)90133-5 is OK
- 10.21105/joss.02343 is OK
- 10.1002/mrm.22178 is OK
- 10.1016/j.postharvbio.2009.02.004 is OK
- 10.1016/j.jmr.2012.12.019 is OK
MISSING DOIs
- None
INVALID DOIs
- None@editorialbot generate pdf
editorialbot
commented
1 year ago :point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
britta-wstnr
commented
1 year ago Hi @Rocsg, 👋
can you please
Please make sure the archived deposit has the correct metadata (title and author list that match to here). Thanks! 🙏 Don't hesitate to let me know if you have questions about this.
Rocsg
commented
1 year ago Hello @britta-wstnr ,
I made the v4.0.10 tagged release : https://github.com/Rocsg/FijiRelax/releases/tag/v4.0.10
I created a Zenodo archive of that release : https://zenodo.org/record/7554691#.Y8qjRdLMJhE
I fixed the info of the Zenodo repo: Title: "FijiRelax: Fast and noise-corrected estimation of MRI relaxation maps in 3D + t" Authors : Romain Fernandez (+ORCID) and Cedric Moisy (+ORCID).
I posted here the release version number: 4.0.10, and the links (just above).
Is everything okay?
Romain
britta-wstnr
commented
1 year ago @editorialbot set 10.5281/zenodo.7554691 as archive
editorialbot
commented
1 year ago Done! Archive is now 10.5281/zenodo.7554691
britta-wstnr
commented
1 year ago @editorialbot set 4.0.10 as version
editorialbot
commented
1 year ago Done! version is now 4.0.10
Submitting author: !--author-handle-->@Rocsg<!--end-author-handle-- (Romain Fernandez) Repository: https://github.com/Rocsg/FijiRelax Branch with paper.md (empty if default branch): Version: 4.0.10 Editor: !--editor-->@britta-wstnr<!--end-editor-- Reviewers: @MaximLippeveld, @kasasxav, @hinerm Archive: 10.5281/zenodo.7554691
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@MaximLippeveld & @kasasxav & @hinerm, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @britta-wstnr know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @MaximLippeveld
📝 Checklist for @hinerm
📝 Checklist for @kasasxav