Closed editorialbot closed 11 months ago
Done! version is now v1.0.0
@editorialbot set 10.5281/zenodo.8321618 as archive
Done! archive is now 10.5281/zenodo.8321618
@editorialbot recommend-accept
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1038/s41550-017-0220-3 is OK
- 10.2307/j.ctvc778ff is OK
- 10.1051/0004-6361/201629272 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.6084/m9.figshare.828487 is OK
- 10.1007/978-3-642-61609-9 is OK
- 10.3389/fchem.2019.00377 is OK
- 10.1103/PhysRevB.78.085125 is OK
- 10.1145/1874391.187410 is OK
- 10.1007/s00791-018-00308-4 is OK
- 10.1021/acs.jctc.3c00555 is OK
- 10.1007/s00791-018-00308-4 is OK
- 10.1103/PhysRev.126.413 is OK
- 10.1103/PhysRev.129.62 is OK
- 10.1063/1.462485 is OK
- 10.1021/ct5001268 is OK
- 10.1103/PhysRevB.90.054115 is OK
- 10.1103/PhysRevB.94.165109 is OK
- 10.1021/acs.jctc.0c01282 is OK
- 10.1103/PhysRevLett.74.1827 is OK
- 10.1103/PhysRev.139.A796 is OK
- 10.1002/wcms.1344 is OK
- 10.1103/PhysRevB.84.241201 is OK
- 10.1103/PhysRevB.71.193102 is OK
- 10.1021/acs.jctc.6b00380 is OK
- 10.1038/s41597-020-0385-y is OK
- 10.1021/acs.jctc.0c00693 is OK
- 10.1021/acs.jpclett.7b02740 is OK
- 10.1021/acs.jctc.7b00770 is OK
- 10.1088/1367-2630/14/5/053020 is OK
- 10.1007/BF00655090 is OK
- 10.48550/arXiv.1108.4417 is OK
- 10.1016/S0010-4655(98)00174-X is OK
- 10.1103/PhysRevB.13.4274 is OK
- 10.1103/PhysRevA.73.012511 is OK
- 10.1103/PhysRevB.96.155207 is OK
- 10.1016/j.cpc.2018.09.003 is OK
- 10.1016/j.cpc.2014.10.021 is OK
- 10.1021/acs.jctc.9b01235 is OK
- 10.1021/acs.jctc.1c00101 is OK
- 10.1021/acs.jctc.1c00308 is OK
- 10.3389/fchem.2021.736591 is OK
- 10.1021/acs.jctc.3c00512 is OK
- 10.1021/acs.jctc.0c00600 is OK
- 10.1021/acs.jctc.8b00177 is OK
- 10.1021/acs.jctc.6b01235 is OK
- 10.1021/acs.jctc.2c00774 is OK
- 10.1063/1.5090605 is OK
- 10.1016/0009-2614(91)80078-C is OK
- 10.1063/1.1809602 is OK
- 10.1103/PhysRevB.94.035118 is OK
- 10.1007/s10853-012-6570-4 is OK
- 10.1007/s00214-011-1084-8 is OK
- 10.1021/ct4002202 is OK
- 10.1103/RevModPhys.74.601 is OK
- 10.1021/acs.jctc.6b00840 is OK
- 10.1103/PhysRevB.85.155129 is OK
- 10.1016/j.cpc.2017.06.012 is OK
- 10.48550/arXiv.2306.16066 is OK
MISSING DOIs
- None
INVALID DOIs
- None
The paper's PDF and metadata files generation produced some warnings that could prevent the final paper from being published. Please fix them before the end of the review process.
d}(i\tau) \hspace{1.9em} &\text{and} \hs
^
unexpected "."
expecting digit, "em", "pt", "in" or "cm"
\hspace{-3em}F^\text{even}(i\omega_k
^
unexpected "-"
expecting white space or digit
:warning: Error preparing paper acceptance. The generated XML metadata file is invalid.
IDREFS attribute rid references an unknown ID "st_odd_t_to_w"
IDREFS attribute rid references an unknown ID "st_odd_t_to_w"
IDREFS attribute rid references an unknown ID "ct_st_even"
IDREFS attribute rid references an unknown ID "ct_st_even"
IDREFS attribute rid references an unknown ID "ct_st_even"
Dear @lucydot
It seems that there is a problem with the preparation of the acceptance. We have tried to fix it. May I ask if you run again recommend-accept to see if it works?
Thank you very much in advance! Best regards, Maryam
@editorialbot recommend-accept
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1038/s41550-017-0220-3 is OK
- 10.2307/j.ctvc778ff is OK
- 10.1051/0004-6361/201629272 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.6084/m9.figshare.828487 is OK
- 10.1007/978-3-642-61609-9 is OK
- 10.3389/fchem.2019.00377 is OK
- 10.1103/PhysRevB.78.085125 is OK
- 10.1145/1874391.187410 is OK
- 10.1007/s00791-018-00308-4 is OK
- 10.1021/acs.jctc.3c00555 is OK
- 10.1007/s00791-018-00308-4 is OK
- 10.1103/PhysRev.126.413 is OK
- 10.1103/PhysRev.129.62 is OK
- 10.1063/1.462485 is OK
- 10.1021/ct5001268 is OK
- 10.1103/PhysRevB.90.054115 is OK
- 10.1103/PhysRevB.94.165109 is OK
- 10.1021/acs.jctc.0c01282 is OK
- 10.1103/PhysRevLett.74.1827 is OK
- 10.1103/PhysRev.139.A796 is OK
- 10.1002/wcms.1344 is OK
- 10.1103/PhysRevB.84.241201 is OK
- 10.1103/PhysRevB.71.193102 is OK
- 10.1021/acs.jctc.6b00380 is OK
- 10.1038/s41597-020-0385-y is OK
- 10.1021/acs.jctc.0c00693 is OK
- 10.1021/acs.jpclett.7b02740 is OK
- 10.1021/acs.jctc.7b00770 is OK
- 10.1088/1367-2630/14/5/053020 is OK
- 10.1007/BF00655090 is OK
- 10.48550/arXiv.1108.4417 is OK
- 10.1016/S0010-4655(98)00174-X is OK
- 10.1103/PhysRevB.13.4274 is OK
- 10.1103/PhysRevA.73.012511 is OK
- 10.1103/PhysRevB.96.155207 is OK
- 10.1016/j.cpc.2018.09.003 is OK
- 10.1016/j.cpc.2014.10.021 is OK
- 10.1021/acs.jctc.9b01235 is OK
- 10.1021/acs.jctc.1c00101 is OK
- 10.1021/acs.jctc.1c00308 is OK
- 10.3389/fchem.2021.736591 is OK
- 10.1021/acs.jctc.3c00512 is OK
- 10.1021/acs.jctc.0c00600 is OK
- 10.1021/acs.jctc.8b00177 is OK
- 10.1021/acs.jctc.6b01235 is OK
- 10.1021/acs.jctc.2c00774 is OK
- 10.1063/1.5090605 is OK
- 10.1016/0009-2614(91)80078-C is OK
- 10.1063/1.1809602 is OK
- 10.1103/PhysRevB.94.035118 is OK
- 10.1007/s10853-012-6570-4 is OK
- 10.1007/s00214-011-1084-8 is OK
- 10.1021/ct4002202 is OK
- 10.1103/RevModPhys.74.601 is OK
- 10.1021/acs.jctc.6b00840 is OK
- 10.1103/PhysRevB.85.155129 is OK
- 10.1016/j.cpc.2017.06.012 is OK
- 10.48550/arXiv.2306.16066 is OK
MISSING DOIs
- None
INVALID DOIs
- None
The paper's PDF and metadata files generation produced some warnings that could prevent the final paper from being published. Please fix them before the end of the review process.
{\color{white}.}\hspace{-3em}F^\text
^
unexpected control sequence \color
expecting "%", "\\label", "\\tag", "\\nonumber" or whitespace
:warning: Error preparing paper acceptance. The generated XML metadata file is invalid.
IDREFS attribute rid references an unknown ID "ctsteven"
IDREFS attribute rid references an unknown ID "ctsteven"
IDREFS attribute rid references an unknown ID "ctsteven"
IDREFS attribute rid references an unknown ID "stoddttow"
IDREFS attribute rid references an unknown ID "stoddttow"
Dear @lucydot,
The editorialbot encountered some issues during the paper acceptance process, primarily stemming from markdown problems. We have addressed these issues, and it appears that they have now been successfully resolved. We kindly request you to please rerun the "recommend-accept" function to confirm its functionality.
We apologize for any inconvenience this may have caused and sincerely appreciate your cooperation. Thank you in advance!
Best regards, Maryam
Dear @lucydot, can you run the recommend-accept command again please? As far as we know, only editors can do this. We checked and fixed the warnings of the logs in the GitHub Action. We hope everything works now.
Best regards, Dorothea
Ping @lucydot
@editorialbot recommend-accept
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1038/s41550-017-0220-3 is OK
- 10.2307/j.ctvc778ff is OK
- 10.1051/0004-6361/201629272 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.6084/m9.figshare.828487 is OK
- 10.1007/978-3-642-61609-9 is OK
- 10.3389/fchem.2019.00377 is OK
- 10.1103/PhysRevB.78.085125 is OK
- 10.1145/1874391.187410 is OK
- 10.1007/s00791-018-00308-4 is OK
- 10.1021/acs.jctc.3c00555 is OK
- 10.1007/s00791-018-00308-4 is OK
- 10.1103/PhysRev.126.413 is OK
- 10.1103/PhysRev.129.62 is OK
- 10.1063/1.462485 is OK
- 10.1021/ct5001268 is OK
- 10.1103/PhysRevB.90.054115 is OK
- 10.1103/PhysRevB.94.165109 is OK
- 10.1021/acs.jctc.0c01282 is OK
- 10.1103/PhysRevLett.74.1827 is OK
- 10.1103/PhysRev.139.A796 is OK
- 10.1002/wcms.1344 is OK
- 10.1103/PhysRevB.84.241201 is OK
- 10.1103/PhysRevB.71.193102 is OK
- 10.1021/acs.jctc.6b00380 is OK
- 10.1038/s41597-020-0385-y is OK
- 10.1021/acs.jctc.0c00693 is OK
- 10.1021/acs.jpclett.7b02740 is OK
- 10.1021/acs.jctc.7b00770 is OK
- 10.1088/1367-2630/14/5/053020 is OK
- 10.1007/BF00655090 is OK
- 10.48550/arXiv.1108.4417 is OK
- 10.1016/S0010-4655(98)00174-X is OK
- 10.1103/PhysRevB.13.4274 is OK
- 10.1103/PhysRevA.73.012511 is OK
- 10.1103/PhysRevB.96.155207 is OK
- 10.1016/j.cpc.2018.09.003 is OK
- 10.1016/j.cpc.2014.10.021 is OK
- 10.1021/acs.jctc.9b01235 is OK
- 10.1021/acs.jctc.1c00101 is OK
- 10.1021/acs.jctc.1c00308 is OK
- 10.3389/fchem.2021.736591 is OK
- 10.1021/acs.jctc.3c00512 is OK
- 10.1021/acs.jctc.0c00600 is OK
- 10.1021/acs.jctc.8b00177 is OK
- 10.1021/acs.jctc.6b01235 is OK
- 10.1021/acs.jctc.2c00774 is OK
- 10.1063/1.5090605 is OK
- 10.1016/0009-2614(91)80078-C is OK
- 10.1063/1.1809602 is OK
- 10.1103/PhysRevB.94.035118 is OK
- 10.1007/s10853-012-6570-4 is OK
- 10.1007/s00214-011-1084-8 is OK
- 10.1021/ct4002202 is OK
- 10.1103/RevModPhys.74.601 is OK
- 10.1021/acs.jctc.6b00840 is OK
- 10.1103/PhysRevB.85.155129 is OK
- 10.1016/j.cpc.2017.06.012 is OK
- 10.48550/arXiv.2306.16066 is OK
MISSING DOIs
- None
INVALID DOIs
- None
The paper's PDF and metadata files generation produced some warnings that could prevent the final paper from being published. Please fix them before the end of the review process.
\hspace{-2em}F^\text{even}(i\omega_k
^
unexpected "-"
expecting white space or digit
i\omega_k) \hspace{-1em}&=&\hspace{-1em}
^
unexpected "-"
expecting white space or digit
:warning: Error preparing paper acceptance. The generated XML metadata file is invalid.
IDREFS attribute rid references an unknown ID "stoddttow"
IDREFS attribute rid references an unknown ID "stoddttow"
IDREFS attribute rid references an unknown ID "ctsteven"
IDREFS attribute rid references an unknown ID "ctsteven"
IDREFS attribute rid references an unknown ID "ctsteven"
Hello @arfon, thanks for the recommend-accept. We have been facing this XML error for a while now. I looked in the documentation of JOSS, but did not find any entry about how to deal with it. Do you have any hint? Thanks a lot
I think the issue here is that Pandoc is struggling to identify the equations labeled/linked in your document. Have you tried following these docs? https://joss.readthedocs.io/en/latest/submitting.html#equations
Dear @arfon,
We have updated the md file with the labeling format explained in the documentation. Could you please run the recommend-accept again to see if it works.
Thank you very much in advance! Best, Maryam
ping @arfon
@editorialbot recommend-accept
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1038/s41550-017-0220-3 is OK
- 10.2307/j.ctvc778ff is OK
- 10.1051/0004-6361/201629272 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.6084/m9.figshare.828487 is OK
- 10.1007/978-3-642-61609-9 is OK
- 10.3389/fchem.2019.00377 is OK
- 10.1103/PhysRevB.78.085125 is OK
- 10.1145/1874391.187410 is OK
- 10.1007/s00791-018-00308-4 is OK
- 10.1021/acs.jctc.3c00555 is OK
- 10.1007/s00791-018-00308-4 is OK
- 10.1103/PhysRev.126.413 is OK
- 10.1103/PhysRev.129.62 is OK
- 10.1063/1.462485 is OK
- 10.1021/ct5001268 is OK
- 10.1103/PhysRevB.90.054115 is OK
- 10.1103/PhysRevB.94.165109 is OK
- 10.1021/acs.jctc.0c01282 is OK
- 10.1103/PhysRevLett.74.1827 is OK
- 10.1103/PhysRev.139.A796 is OK
- 10.1002/wcms.1344 is OK
- 10.1103/PhysRevB.84.241201 is OK
- 10.1103/PhysRevB.71.193102 is OK
- 10.1021/acs.jctc.6b00380 is OK
- 10.1038/s41597-020-0385-y is OK
- 10.1021/acs.jctc.0c00693 is OK
- 10.1021/acs.jpclett.7b02740 is OK
- 10.1021/acs.jctc.7b00770 is OK
- 10.1088/1367-2630/14/5/053020 is OK
- 10.1007/BF00655090 is OK
- 10.48550/arXiv.1108.4417 is OK
- 10.1016/S0010-4655(98)00174-X is OK
- 10.1103/PhysRevB.13.4274 is OK
- 10.1103/PhysRevA.73.012511 is OK
- 10.1103/PhysRevB.96.155207 is OK
- 10.1016/j.cpc.2018.09.003 is OK
- 10.1016/j.cpc.2014.10.021 is OK
- 10.1021/acs.jctc.9b01235 is OK
- 10.1021/acs.jctc.1c00101 is OK
- 10.1021/acs.jctc.1c00308 is OK
- 10.3389/fchem.2021.736591 is OK
- 10.1021/acs.jctc.3c00512 is OK
- 10.1021/acs.jctc.0c00600 is OK
- 10.1021/acs.jctc.8b00177 is OK
- 10.1021/acs.jctc.6b01235 is OK
- 10.1021/acs.jctc.2c00774 is OK
- 10.1063/1.5090605 is OK
- 10.1016/0009-2614(91)80078-C is OK
- 10.1063/1.1809602 is OK
- 10.1103/PhysRevB.94.035118 is OK
- 10.1007/s10853-012-6570-4 is OK
- 10.1007/s00214-011-1084-8 is OK
- 10.1021/ct4002202 is OK
- 10.1103/RevModPhys.74.601 is OK
- 10.1021/acs.jctc.6b00840 is OK
- 10.1103/PhysRevB.85.155129 is OK
- 10.1016/j.cpc.2017.06.012 is OK
- 10.48550/arXiv.2306.16066 is OK
MISSING DOIs
- None
INVALID DOIs
- None
The paper's PDF and metadata files generation produced some warnings that could prevent the final paper from being published. Please fix them before the end of the review process.
\hspace{-2em}F^\text{even}(i\omega_k
^
unexpected "-"
expecting white space or digit
i\omega_k) \hspace{-1em}&=&\hspace{-1em}
^
unexpected "-"
expecting white space or digit
:warning: Error preparing paper acceptance. The generated XML metadata file is invalid.
IDREFS attribute rid references an unknown ID "stoddttow"
IDREFS attribute rid references an unknown ID "stoddttow"
IDREFS attribute rid references an unknown ID "ctsteven"
IDREFS attribute rid references an unknown ID "ctsteven"
IDREFS attribute rid references an unknown ID "ctsteven"
@aziziph @dgolze apologies for my late reply to your earlier messages.
It seems there is still a problem @arfon, will raise with other editors in case they have seen similar.
Is the hspace
necessary @aziziph? As a test could we try removing it to see if that is where the problem is? Just to check, is the hspace
being used in math mode? I don't think valid latex if so.
Is the
hspace
necessary @aziziph? As a test could we try removing it to see if that is where the problem is? Just to check, is thehspace
being used in math mode? I don't think valid latex if so.@lucydot we will remove the hspace, trying right now
@lucydot or @arfon we did more radical changes now: i) removed all hspace's in the equations as you recommend ii) removed all labels in the equations and replaced the reference in the text by hand Could you please try again to run the recommend-accept command?
Hi @lucydot I believe I fixed the compilation warnings in nomad-coe/greenX@3df7ff1c7a73d57abdb595a6672c03e697624796 Would you mind recommending again? Apologies for the long iterations
ping @lucydot @arfon
ping @lucydot @arfon
@editorialbot recommend-accept
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1038/s41550-017-0220-3 is OK
- 10.2307/j.ctvc778ff is OK
- 10.1051/0004-6361/201629272 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.6084/m9.figshare.828487 is OK
- 10.1007/978-3-642-61609-9 is OK
- 10.3389/fchem.2019.00377 is OK
- 10.1103/PhysRevB.78.085125 is OK
- 10.1145/1874391.187410 is OK
- 10.1007/s00791-018-00308-4 is OK
- 10.1021/acs.jctc.3c00555 is OK
- 10.1007/s00791-018-00308-4 is OK
- 10.1103/PhysRev.126.413 is OK
- 10.1103/PhysRev.129.62 is OK
- 10.1063/1.462485 is OK
- 10.1021/ct5001268 is OK
- 10.1103/PhysRevB.90.054115 is OK
- 10.1103/PhysRevB.94.165109 is OK
- 10.1021/acs.jctc.0c01282 is OK
- 10.1103/PhysRevLett.74.1827 is OK
- 10.1103/PhysRev.139.A796 is OK
- 10.1002/wcms.1344 is OK
- 10.1103/PhysRevB.84.241201 is OK
- 10.1103/PhysRevB.71.193102 is OK
- 10.1021/acs.jctc.6b00380 is OK
- 10.1038/s41597-020-0385-y is OK
- 10.1021/acs.jctc.0c00693 is OK
- 10.1021/acs.jpclett.7b02740 is OK
- 10.1021/acs.jctc.7b00770 is OK
- 10.1088/1367-2630/14/5/053020 is OK
- 10.1007/BF00655090 is OK
- 10.48550/arXiv.1108.4417 is OK
- 10.1016/S0010-4655(98)00174-X is OK
- 10.1103/PhysRevB.13.4274 is OK
- 10.1103/PhysRevA.73.012511 is OK
- 10.1103/PhysRevB.96.155207 is OK
- 10.1016/j.cpc.2018.09.003 is OK
- 10.1016/j.cpc.2014.10.021 is OK
- 10.1021/acs.jctc.9b01235 is OK
- 10.1021/acs.jctc.1c00101 is OK
- 10.1021/acs.jctc.1c00308 is OK
- 10.3389/fchem.2021.736591 is OK
- 10.1021/acs.jctc.3c00512 is OK
- 10.1021/acs.jctc.0c00600 is OK
- 10.1021/acs.jctc.8b00177 is OK
- 10.1021/acs.jctc.6b01235 is OK
- 10.1021/acs.jctc.2c00774 is OK
- 10.1063/1.5090605 is OK
- 10.1016/0009-2614(91)80078-C is OK
- 10.1063/1.1809602 is OK
- 10.1103/PhysRevB.94.035118 is OK
- 10.1007/s10853-012-6570-4 is OK
- 10.1007/s00214-011-1084-8 is OK
- 10.1021/ct4002202 is OK
- 10.1103/RevModPhys.74.601 is OK
- 10.1021/acs.jctc.6b00840 is OK
- 10.1103/PhysRevB.85.155129 is OK
- 10.1016/j.cpc.2017.06.012 is OK
- 10.48550/arXiv.2306.16066 is OK
MISSING DOIs
- None
INVALID DOIs
- None
:wave: @openjournals/pe-eics, this paper is ready to be accepted and published.
Check final proof :point_right::page_facing_up: Download article
If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4641, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept
Looks like this is fixed now. I'll let @kyleniemeyer take over from here.
Thanks @Panadestein and the rest of the team, got there in the end!
@lucydot is action required from our side? Do we have to reply in https://github.com/openjournals/joss-papers/pull/4641
@dgolze nothing at the moment - I'm going to do some final checks before publishing. I'll let you know if we need any changes. You could review the final PDF, though!
@dgolze just a question: can you explain why GW is italicized in the title and text, while other acronyms like RPA are not?
It's in Italic because of convention. @kyleniemeyer
OK, thanks @aziziph!
@editorialbot accept
Submitting author: !--author-handle-->@aziziph<!--end-author-handle-- (Maryam Azizi) Repository: https://github.com/nomad-coe/greenX Branch with paper.md (empty if default branch): main Version: v1.0.0 Editor: !--editor-->@lucydot<!--end-editor-- Reviewers: @mailhexu, @DarioALeonValido Archive: 10.5281/zenodo.8321618
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@mailhexu & @DarioALeonValido, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lucydot know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @DarioALeonValido
📝 Checklist for @mailhexu