[REVIEW]: Time-frequency component of the Green-X library: minimax grids for efficient RPA and GW calculations

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@aziziph@lucydot<!--end-editor-- Reviewers: @mailhexu, @DarioALeonValido Archive: 10.5281/zenodo.8321618

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/47a495c8d6c180bfb278762fc06cb992"><img src="https://joss.theoj.org/papers/47a495c8d6c180bfb278762fc06cb992/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/47a495c8d6c180bfb278762fc06cb992/status.svg)](https://joss.theoj.org/papers/47a495c8d6c180bfb278762fc06cb992)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@mailhexu & @DarioALeonValido, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lucydot know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @DarioALeonValido

📝 Checklist for @mailhexu

editorialbot commented 11 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 11 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Azizi given-names: Maryam orcid: "https://orcid.org/0000-0001-9089-1043" - family-names: Wilhelm given-names: Jan orcid: "https://orcid.org/0000-0001-8678-8246" - family-names: Golze given-names: Dorothea orcid: "https://orcid.org/0000-0002-2196-9350" - family-names: Giantomassi given-names: Matteo orcid: "https://orcid.org/0000-0002-7007-9813" - family-names: Panadés-Barrueta given-names: Ramón L. orcid: "https://orcid.org/0000-0003-4239-0978" - family-names: Delesma given-names: Francisco A. orcid: "https://orcid.org/0000-0001-6912-7745" - family-names: Buccheri given-names: Alexander orcid: "https://orcid.org/0000-0001-5983-8631" - family-names: Gulans given-names: Andris orcid: "https://orcid.org/0000-0001-7304-1952" - family-names: Rinke given-names: Patrick orcid: "https://orcid.org/0000-0003-1898-723X" - family-names: Draxl given-names: Claudia orcid: "https://orcid.org/0000-0003-3523-6657" - family-names: Gonze given-names: Xavier orcid: "https://orcid.org/0000-0002-8377-6829" doi: 10.5281/zenodo.8321618 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Azizi given-names: Maryam orcid: "https://orcid.org/0000-0001-9089-1043" - family-names: Wilhelm given-names: Jan orcid: "https://orcid.org/0000-0001-8678-8246" - family-names: Golze given-names: Dorothea orcid: "https://orcid.org/0000-0002-2196-9350" - family-names: Giantomassi given-names: Matteo orcid: "https://orcid.org/0000-0002-7007-9813" - family-names: Panadés-Barrueta given-names: Ramón L. orcid: "https://orcid.org/0000-0003-4239-0978" - family-names: Delesma given-names: Francisco A. orcid: "https://orcid.org/0000-0001-6912-7745" - family-names: Buccheri given-names: Alexander orcid: "https://orcid.org/0000-0001-5983-8631" - family-names: Gulans given-names: Andris orcid: "https://orcid.org/0000-0001-7304-1952" - family-names: Rinke given-names: Patrick orcid: "https://orcid.org/0000-0003-1898-723X" - family-names: Draxl given-names: Claudia orcid: "https://orcid.org/0000-0003-3523-6657" - family-names: Gonze given-names: Xavier orcid: "https://orcid.org/0000-0002-8377-6829" date-published: 2023-10-03 doi: 10.21105/joss.05570 issn: 2475-9066 issue: 90 journal: Journal of Open Source Software publisher: name: Open Journals start: 5570 title: "Time-frequency component of the GreenX library: minimax grids for efficient RPA and GW calculations" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05570" volume: 8 title: "Time-frequency component of the GreenX library: minimax grids for efficient RPA and *GW* calculations" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 11 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 11 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4650
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05570
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

Panadestein commented 11 months ago

@kyleniemeyer thanks for accepting the manuscript. The title seems to have been rendered incorrectly though, I can see in my mobile device \textit{GW}, should simply be this in italics.

kyleniemeyer commented 11 months ago

@openjournals/dev looks like some LaTeX markup got caught in the title at https://doi.org/10.21105/joss.05570, does that need to be fixed manually?

dgolze commented 11 months ago

@kyleniemeyer is there a chance that the title on the website gets fixed --> \textit{GW}

Panadestein commented 11 months ago

@kyleniemeyer the article already got indexed by Google Scholar and ResearchGate with this latex code in the title. That does not look good for anybody. Would you mind taking a look at this issue? Thanks

kyleniemeyer commented 11 months ago

@openjournals/dev @arfon can the title for this paper be fixed manually? I don't think I can do this myself.

arfon commented 11 months ago

@aziziph – please merge this PR. @kyleniemeyer then you can run reaccept here: https://joss.readthedocs.io/en/latest/editorial_bot.html?highlight=reaccept#updating-an-already-accepted-paper

kyleniemeyer commented 11 months ago

@editorialbot reaccept

editorialbot commented 11 months ago

Rebuilding paper!

editorialbot commented 11 months ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/4662

kyleniemeyer commented 11 months ago

Thanks, @arfon. I thought fixing this would involve some manual magic on the website.

@Panadestein @dgolze the website appears correct for me now, and indexers should update after some time as well.

editorialbot commented 11 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05570/status.svg)](https://doi.org/10.21105/joss.05570)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05570">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05570/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05570/status.svg
   :target: https://doi.org/10.21105/joss.05570

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews