openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
699 stars 36 forks source link

[PRE REVIEW]: G'MIC: An Open-Source Self-Extending Framework for Image Processing #6056

Closed editorialbot closed 4 months ago

editorialbot commented 9 months ago

Submitting author: !--author-handle-->@dtschump<!--end-author-handle-- (David Tschumperlé) Repository: https://github.com/GreycLab/gmic Branch with paper.md (empty if default branch): joss Version: 3.3.2 Editor: !--editor-->@gkthiruvathukal<!--end-editor-- Reviewers: @jamesrhester, @Smattr, @drj11 Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8"><img src="https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8/status.svg)](https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8)

Author instructions

Thanks for submitting your paper to JOSS @dtschump. Currently, there isn't a JOSS editor assigned to your paper.

@dtschump if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 9 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 9 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (228.7 files/s, 47869.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         1            156              0            499
SVG                              1              5              1            357
TeX                              1             22              0            179
YAML                             2              1              4             19
make                             1              4              0              9
-------------------------------------------------------------------------------
SUM:                             6            188              5           1063
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 6734

editorialbot commented 9 months ago

Failed to discover a valid open source license

editorialbot commented 9 months ago

Failed to discover a Statement of need section in paper

editorialbot commented 9 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1109/icip46576.2022.9897386 may be a valid DOI for title: Automatic Illumination of Flat-Colored Drawings by 3D Augmentation of 2D Silhouettes
- 10.1109/icip46576.2022.9897334 may be a valid DOI for title: A Patch-Based Approach for Artistic Style Transfer via Constrained Multi-Scale Image Matching
- 10.1137/19m1306798 may be a valid DOI for title: Reconstruction of Smooth 3D Color Functions from Keypoints: Application to Lossy Compression and Exemplar-Based Generation of Color LUTs
- 10.1109/tip.2015.2411437 may be a valid DOI for title: Exemplar-based inpainting: Technical review and new heuristics for better geometric reconstructions
- 10.1109/99.660313 may be a valid DOI for title: OpenMP: an industry standard API for shared-memory programming
- 10.1038/s41586-023-06551-1 may be a valid DOI for title: Outflows from the youngest stars are mostly molecular

INVALID DOIs

- None
editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 9 months ago

@dtschump - Can you add the full software to the joss branch (so that this is copy of master, with the paper, rather than just the paper)?

danielskatz commented 9 months ago

In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

danielskatz commented 9 months ago

Finally (for now), your paper is not a JOSS paper: it's about 7000 words long, while JOSS papers are typically around 1000 words. Much of what is in your paper might be replaced by links to documentation or something else. The JOSS paper should just be a brief introduction to the software.

Please follow the example paper You can use the command @editorialbot generate pdf after making changes to the .md file to make a new PDF.

dtschump commented 9 months ago

Hello @danielskatz . Thanks for your inspection. I'm currently trying to fix the issues, and I'll reduce the length of the paper as well.

dtschump commented 9 months ago

@editorialbot check references

editorialbot commented 9 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/icip46576.2022.9897386 is OK
- 10.1109/icip46576.2022.9897334 is OK
- 10.1137/19m1306798 is OK
- 10.1109/tip.2015.2411437 is OK
- 10.1109/99.660313 is OK
- 10.1038/s41586-023-06551-1 is OK

MISSING DOIs

- None

INVALID DOIs

- None
dtschump commented 9 months ago

@editorialbot check repository

editorialbot commented 9 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.15 s (380.3 files/s, 309496.6 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                               3            920            755          13939
SVG                               5             12              4          11995
JavaScript                       13           1127            207           9089
CSS                               3            160             68           1615
HTML                              6            116             70           1295
Markdown                          3            286              0            792
make                              3            112            331            589
CMake                             7             87             70            390
Bourne Again Shell                5             66            101            387
C/C++ Header                      1             99             94            382
TeX                               1             22              0            185
XML                               1              0              0             36
Scheme                            1             10             45             31
YAML                              2              1              4             19
Bourne Shell                      2              5             56              6
--------------------------------------------------------------------------------
SUM:                             56           3023           1805          40750
--------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 4292

editorialbot commented 9 months ago

Failed to discover a Statement of need section in paper

dtschump commented 9 months ago

@editorialbot check repository

editorialbot commented 9 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.16 s (355.3 files/s, 288913.6 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                               3            920            755          13939
SVG                               5             12              4          11995
JavaScript                       13           1127            207           9089
CSS                               3            160             68           1615
HTML                              6            116             70           1295
Markdown                          3            276              0            764
make                              3            112            331            589
CMake                             7             87             70            390
Bourne Again Shell                5             66            101            387
C/C++ Header                      1             99             94            382
TeX                               1             22              0            185
XML                               1              0              0             36
Scheme                            1             10             45             31
YAML                              2              1              4             19
Bourne Shell                      2              5             56              6
--------------------------------------------------------------------------------
SUM:                             56           3013           1805          40722
--------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 3829

editorialbot commented 9 months ago

Failed to discover a Statement of need section in paper

dtschump commented 9 months ago

@editorialbot check repository

editorialbot commented 9 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.18 s (305.8 files/s, 248199.3 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                               3            920            755          13939
SVG                               5             12              4          11995
JavaScript                       13           1127            207           9089
CSS                               3            160             68           1615
HTML                              6            116             70           1295
Markdown                          3            254              0            693
make                              3            112            331            589
CMake                             7             87             70            390
Bourne Again Shell                5             66            101            387
C/C++ Header                      1             99             94            382
TeX                               1             22              0            185
XML                               1              0              0             36
Scheme                            1             10             45             31
YAML                              2              1              4             19
Bourne Shell                      2              5             56              6
--------------------------------------------------------------------------------
SUM:                             56           2991           1805          40651
--------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 2321

editorialbot commented 9 months ago

Failed to discover a Statement of need section in paper

dtschump commented 9 months ago

@editorialbot check repository

editorialbot commented 9 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.18 s (305.6 files/s, 247918.0 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                               3            920            755          13939
SVG                               5             12              4          11995
JavaScript                       13           1127            207           9089
CSS                               3            160             68           1615
HTML                              6            116             70           1295
Markdown                          3            250              0            676
make                              3            112            331            589
CMake                             7             87             70            390
Bourne Again Shell                5             66            101            387
C/C++ Header                      1             99             94            382
TeX                               1             22              0            185
XML                               1              0              0             36
Scheme                            1             10             45             31
YAML                              2              1              4             19
Bourne Shell                      2              5             56              6
--------------------------------------------------------------------------------
SUM:                             56           2987           1805          40634
--------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 1585

editorialbot commented 9 months ago

Failed to discover a Statement of need section in paper

dtschump commented 9 months ago

@danielskatz , I think I'm done with the rewrite. I don't think I can reduce the paper it any further (without removing important content). I'm a bit surprised the "Statement of need" section is not found, as it is actually the title of the first section.

Is there anything more I can do now? Thanks for your attention.

danielskatz commented 9 months ago

The issue with the statement of need section might be because you are adding numbers to your section headings, which the JOSS example paper doesn't have. Can you remove them and check again?

danielskatz commented 9 months ago

@editorialbot generate pdf

editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dtschump commented 9 months ago

@editorialbot generate pdf

dtschump commented 9 months ago

I've removed the section numbers.

editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 9 months ago

@editorialbot check repository

editorialbot commented 9 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.15 s (382.2 files/s, 310024.4 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                               3            920            755          13939
SVG                               5             12              4          11995
JavaScript                       13           1127            207           9089
CSS                               3            160             68           1615
HTML                              6            116             70           1295
Markdown                          3            250              0            676
make                              3            112            331            589
CMake                             7             87             70            390
Bourne Again Shell                5             66            101            387
C/C++ Header                      1             99             94            382
TeX                               1             22              0            185
XML                               1              0              0             36
Scheme                            1             10             45             31
YAML                              2              1              4             19
Bourne Shell                      2              5             56              6
--------------------------------------------------------------------------------
SUM:                             56           2987           1805          40634
--------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 9 months ago

Wordcount for paper.md is 1576

danielskatz commented 9 months ago

@dtschump - that seems to have fixed it. I'll next look for an editor. While I do so, if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission, or suggest people from outside JOSS.

danielskatz commented 9 months ago

👋 @gkthiruvathukal - do you think you could edit this submission?

danielskatz commented 9 months ago

@editorialbot invite @gkthiruvathukal as editor

editorialbot commented 9 months ago

Invitation to edit this submission sent!

dtschump commented 9 months ago

About reviewers suggestion :

In your list, I think people with an image processing & C/C++ background, would be good candidates. So with the search filters, I found : Jonathan Bach Martin, Justus Schock and @hechth.

Outside JOSS official reviewers, I would recommend :

gkthiruvathukal commented 9 months ago

@danielskatz Yes. A bit busy at SC23 but will get to it soon.

danielskatz commented 9 months ago

Thanks - maybe I'll see you here at SC somewhere... Also, I'll go ahead and add as as editor now, knowing that you won't start immediately.

danielskatz commented 9 months ago

@editorialbot assign @gkthiruvathukal as editor

editorialbot commented 9 months ago

Assigned! @gkthiruvathukal is now the editor

gkthiruvathukal commented 8 months ago

@danielskatz Sorry I did not get a chance to meet you at SC23. There was a lot going on, including some (unwanted) meetings I had to take remotely from Denver. Working on getting this submission moving!

gkthiruvathukal commented 8 months ago

@editorialbot commands