Closed editorialbot closed 8 months ago
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@editorialbot commands
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@editorialbot generate pdf
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1001/jamainternmed.2018.7117 is OK
- 10.1109/TNNLS.2022.3190448 is OK
- 10.1088/1741-2552/abca18 is OK
- 10.1109/ACCESS.2023.3344531 is OK
- 10.48550/arXiv.1912.01703 is OK
- 10.1088/1741-2552/ab4af6 is OK
- 10.3390/app13095472 is OK
MISSING DOIs
- None
INVALID DOIs
- None
Software report:
github.com/AlDanial/cloc v 1.88 T=0.19 s (775.1 files/s, 128088.7 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
Python 24 2401 5788 7347
Jupyter Notebook 12 0 3971 2565
reStructuredText 97 552 564 491
Markdown 8 196 0 457
YAML 4 22 17 109
TeX 1 11 0 70
DOS Batch 1 8 1 26
make 1 4 7 9
TOML 1 1 0 6
-------------------------------------------------------------------------------
SUM: 149 3195 10348 11080
-------------------------------------------------------------------------------
gitinspector failed to run statistical information for the repository
Wordcount for paper.md
is 979
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
π Hi @vferat, @wmvanvliet, @Bsingstad, and thank you again for agreeing to review this submission for SelfEEG !
The review will take place in this issue, and you can generate your individual reviewer checklists by asking editorialbot directly with @editorialbot generate my checklist
.
In working through the checklist, you're likely to have specific feedback on SelfEEG. Whenever possible, please open relevant issues on the software repository (and cross-link them with this issue) rather than discussing them here. This helps to make sure that feedback is translated into actionable items to improve the software !
If you aren't sure how to get started, please see the Reviewing for JOSS guide -- and, of course, feel free to ping me with any questions !
Excellent work, @fedepup and team! I think this package will definitely help with the development of self-supervised learning techniques on EEG data.
Excellent work, @fedepup and team! I think this package will definitely help with the development of self-supervised learning techniques on EEG data.
Thank you very much, @wmvanvliet!
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
I've generated a new PDF draft to include changes made during wmvanvliet's review.
π Hi everyone ! I just wanted to check-in on how this review is going for you, @Bsingstad and @vferat.
If you have any questions that I can answer, please don't hesitate to let me know. And thank you again for your help in reviewing SelfEEG !
Hey @emdupre, The review is coming along, I'm a bit busy this week, but I expect to finish by next week.
Review completed !
Thanks to the authors for their responsiveness! The library delivers on its promise to simplify access to EEG data All my comments have been addressed and I can only recommend to accept this publication.
Thank to all authors for making this tool available to the community !
Thanks to the authors for their responsiveness! The library delivers on its promise to simplify access to EEG data All my comments have been addressed and I can only recommend to accept this publication.
Thank you very much, @vferat!
Hi @emdupre. To help you have a clear view of all the revisions made during vferat and wmvanvliet review, I would like to write a little summary.
wmvanvliet:
vferat
Notebooks
folder MedMaxLab/selfEEG@e573df17acc1f15a77b0fc94b92aeaa8d23ae3b2Thank you for your write-up, @fedepup ! I appreciate this summary π And thank you very much to @wmvanvliet and @vferat for your reviews !
@Bsingstad, please let us know when you've finalized your review -- or if there are any blockers that we should be aware of ! And thank you again for your work on reviewing SelfEEG to date π»
Sorry for my silence here. I will try to finish my review during this week.
Hi @Bsingstad, thank you for following up on this ! Please let me know if you would still be able to complete your review within the next week, or if you anticipate a longer delay.
@emdupre - Thanks for your constant monitoring on this review process. Considering how smoothly things have gone so far and, more importantly, how the revisions have already greatly improved the quality of selfEEG, I'm confident that the entire review process will be completed within the expected time.
@Bsingstad - As already said in the pre-review process, I will try to solve any raised issue as soon as possible, possibly within the same day. Thanks again for having accepted to review selfEEG.
π Hi everyone !
I just wanted to follow-up on this review for SelfEEG. Given that we're now outside of the six week review window, we'll need to wrap up our initial reviews. @Bsingstad, if you're able to provide comments by Monday, 4 March we would still be consider those. Otherwise, we'll need to conclude the initial review.
Thank you again to everyone for all of your input throughout this review process !
Hi again,
Now that we've passed this final deadline, I'll need to remove @Bsingstad from the reviewer list. Thank you, though, for your enthusiasm for SelfEEG.
As @wmvanvliet and @vferat have already confirmed their completed reviews, I'll then proceed to perform a few final editorial checks.
If there are any questions or concerns at this point, please let me know !
@editorialbot remove @Bsingstad from reviewers
@Bsingstad removed from the reviewers list!
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1001/jamainternmed.2018.7117 is OK
- 10.1109/TNNLS.2022.3190448 is OK
- 10.1088/1741-2552/abca18 is OK
- 10.1109/ACCESS.2023.3344531 is OK
- 10.48550/arXiv.1912.01703 is OK
- 10.1088/1741-2552/ab4af6 is OK
- 10.3390/app13095472 is OK
MISSING DOIs
- None
INVALID DOIs
- None
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1001/jamainternmed.2018.7117 is OK
- 10.1109/TNNLS.2022.3190448 is OK
- 10.1088/1741-2552/abca18 is OK
- 10.1109/ACCESS.2023.3344531 is OK
- 10.48550/arXiv.1912.01703 is OK
- 10.1088/1741-2552/ab4af6 is OK
- 10.3390/app13095472 is OK
- 10.1016/j.eswa.2024.123550 is OK
MISSING DOIs
- None
INVALID DOIs
- None
Hi @emdupre. Yesterday a paper on torchEEG was published on Expert Systems with Applications. Therefore, I've updated the paper and added the new reference. You can find all the modifications here MedMaxLab/SelfEEG@c7475baa2b539901d9b426ccbde2e0d5038b17c3.
I also take the chance to ask if there are other additional steps I need to perform at this stage of the peer-review.
Thanks for checking in, @fedepup ! I've now had a chance to review SelfEEG and am happy with the state of the submission π
I do, though, have a few small editorial requests before we can proceed (the torchEEG citation was actually one of my original requests, so thanks for taking care of that !):
@software{susmelj2020lightly,
title = {Lightly},
author={Igor Susmelj and Matthias Heller and Philipp Wirth and Jeremy Prescott and Malte Ebner et al.},
url = {https://github.com/lightly-ai/lightly},
version = {1.5.0},
date = {2024-03-11},
}
I've taken the version and date accessed as latest, but please update as appropriate !
After making these changes, could you then please:
I'll then be able to proceed with processing the submission π
@editorialbot set <DOI here> as archive
@editorialbot set <version here> as version
@editorialbot generate pdf
@editorialbot check references
and ask author(s) to update as needed@editorialbot recommend-accept
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1001/jamainternmed.2018.7117 is OK
- 10.1109/TNNLS.2022.3190448 is OK
- 10.1088/1741-2552/abca18 is OK
- 10.1109/ACCESS.2023.3344531 is OK
- 10.48550/arXiv.1912.01703 is OK
- 10.1088/1741-2552/ab4af6 is OK
- 10.3390/app13095472 is OK
- 10.1016/j.eswa.2024.123550 is OK
MISSING DOIs
- No DOI given, and none found for title: Lightly
- No DOI given, and none found for title: VISSL
INVALID DOIs
- None
Line 63 of the paper: Few examples are
should be A few examples are
Line 63 of the paper:
Few examples are
should beA few examples are
Thanks! Corrected.
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
HI @emdupre. Here I report all the requested information and revisions.
Title, list of authors, license (MIT), affiliations and version tag reported in the archive are the same as in the paper or GitHub repository.
Zenodo's DOI registration is currently affected by a service incident at DataCite. So, the provided link does not work at the moment, although it is correct. If you check the DOI that represent all versions of selfEEG ( https://zenodo.org/doi/10.5281/zenodo.10813094 ), you can see that this works. You can also check that the one provided for the specific release (v0.1.1) is correct.
Thanks again.
@editorialbot set 10.5281/zenodo.10813095 as archive
That doesn't look like a valid DOI value
Submitting author: !--author-handle-->@fedepup<!--end-author-handle-- (Federico Del Pup) Repository: https://github.com/MedMaxLab/selfEEG Branch with paper.md (empty if default branch): Version: v0.1.1 Editor: !--editor-->@emdupre<!--end-editor-- Reviewers: @vferat, @wmvanvliet Archive: 10.5281/zenodo.10813095
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@vferat & @wmvanvliet & @Bsingstad, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @emdupre know.
β¨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest β¨
Checklists
π Checklist for @wmvanvliet
π Checklist for @Bsingstad
π Checklist for @vferat