editorialbot commented 7 months ago

Submitting author: !--author-handle-->@cfarm6@AnjaliSandip<!--end-editor-- Reviewers: @fb456, @SotaYoshida Archive: 10.5281/zenodo.10903235

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/439f08d1e0ca104c5e8e1da37a05d3ce"><img src="https://joss.theoj.org/papers/439f08d1e0ca104c5e8e1da37a05d3ce/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/439f08d1e0ca104c5e8e1da37a05d3ce/status.svg)](https://joss.theoj.org/papers/439f08d1e0ca104c5e8e1da37a05d3ce)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@fb456 & @SotaYoshida, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @AnjaliSandip know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @SotaYoshida

📝 Checklist for @fb456

editorialbot commented 7 months ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot commented 7 months ago

Software report:

github.com/AlDanial/cloc v 1.88  T=0.05 s (828.4 files/s, 178153.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           29           1062            439           5353
TeX                              2            156              0           1512
XML                              1              4              0            464
Markdown                         6             72              0            321
YAML                             4              6              9            143
TOML                             3              7              0            130
-------------------------------------------------------------------------------
SUM:                            45           1307            448           7923
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository

editorialbot commented 7 months ago

Wordcount for paper.md is 1072

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

SotaYoshida commented 7 months ago

Review checklist for @SotaYoshida

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the https://github.com/TRACER-LULab/Hyperelastics.jl?
[x] License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@cfarm6) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
[x] Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
[x] Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
[x] Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[x] A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
[x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

SotaYoshida commented 7 months ago

@cfarm6 I started reviewing. If some of the checklists are blank, it doesn't mean your code doesn't meet those items, it just means I'm still checking them. I'll probably have some time next week to run your code and read docs, so I'll give you some initial feedback (hopefully) next week. Thanks.

fb456 commented 7 months ago

Review checklist for @fb456

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the https://github.com/TRACER-LULab/Hyperelastics.jl?
[x] License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@cfarm6) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
[x] Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
[x] Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
[x] Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[x] A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
[x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

fb456 commented 7 months ago

Hi @cfarm6!

I've also started the review. I have submitted a few issues already that should be addressed, specifically about: https://github.com/TRACER-LULab/Hyperelastics.jl/issues/109: software installation https://github.com/TRACER-LULab/Hyperelastics.jl/issues/110: Statement of Need and Community Guidelines in the docs https://github.com/TRACER-LULab/Hyperelastics.jl/issues/111: A bug I encountered when running the Example https://github.com/TRACER-LULab/Hyperelastics.jl/issues/112: A few references that could be added in the paper

I'll continue my review next week and let you know if any more issues arise.

AnjaliSandip commented 7 months ago

@SotaYoshida Just a kind reminder

SotaYoshida commented 7 months ago

Thank you for reminding me. We (I) have dealt with the above issues, and I am still reviewing the code and documentation.

SotaYoshida commented 7 months ago

This package is an excellent effort to implement over 70 hyperelastic material models in the Julia language. This would help students, newcomers and also experts in the field to work on their own materials. The paper and documentation are both well written. I recommend publication of this paper and package.

Minor comments from me are as follows:

It would be better to highlight the features of the package and the intended audience or users in the paper, as raised in the issue.
I suggest authors to describe the assumed and recommended environment (OS and version of Julia guaranteed) of the user in the document. Such information can be found at CI settings and elsewhere, but it would help prevent the readers from using this package in a wrong way.

AnjaliSandip commented 7 months ago

@fb456 This is just a kind reminder to complete the review process.

fb456 commented 7 months ago

Hi, I also recommend publication provided the issues in the link https://github.com/TRACER-LULab/Hyperelastics.jl/issues/121#issue-2132223511 are addressed. This is regarding the general structure of the paper.

AnjaliSandip commented 6 months ago

@cfarm6 can you address the issues stated?

cfarm6 commented 6 months ago

@AnjaliSandip Yes. I will have the corrections made by the end of this week.

AnjaliSandip commented 6 months ago

@cfarm6, could you provide a timeline for wrapping up the corrections suggested?

cfarm6 commented 6 months ago

@AnjaliSandip Yes, I will be finishing up the suggested corrections later today.

cfarm6 commented 6 months ago

@AnjaliSandip The issues have been addressed by adding a section for comparisons with other open-source and commercial packages and a section detailing a common use case for the package. paper.pdf

AnjaliSandip commented 6 months ago

@SotaYoshida @fb456 Could you review the changes made?

fb456 commented 6 months ago

Hi,

I think the issues above have been addressed. One very very minor comment from me is that, referring to the comment above, the information about the recommended version of Julia could also be included in the docs.

Otherwise, I recommend the publication of the paper and the package!

cfarm6 commented 6 months ago

@fb456 I have added statements to the installation instructions in the README and the documentation to reference the compatible Julia versions. In addition, the package is unavailable in older versions as I have only listed compatibility for Julia 1.9+ in the Project.toml file. The updates in the documentation should appear in about 20 minutes once they finish rebuilding.

SotaYoshida commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

SotaYoshida commented 6 months ago

@AnjaliSandip Confirmed the changes made. I am happy to recommend this paper and package for publication.

AnjaliSandip commented 6 months ago

@fb456 Could you confirm the changes are acceptable? Do you recommend this paper and package for publication?

fb456 commented 6 months ago

Hi @AnjaliSandip

Yes, I've already confirmed it above. I think the package is acceptable for publication.

AnjaliSandip commented 6 months ago

thank you @fb456 and @SotaYoshida!

AnjaliSandip commented 6 months ago

@editorialbot generate pdf

AnjaliSandip commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.7738525 is OK
- 10.1137/141000671 is OK
- 10.5254/1.3538357 is OK

MISSING DOIs

- 10.1016/j.cma.2024.116751 may be a valid DOI for title: Simultaneous shape and topology optimization of in...
- 10.1115/1.4063348 may be a valid DOI for title: A comparative study of the entanglement models tow...
- 10.1016/j.heliyon.2024.e25379 may be a valid DOI for title: An Ogden hyperelastic 3D micromechanical model to ...
- 10.1016/j.commatsci.2024.112885 may be a valid DOI for title: User subroutines platform development for rubber h...
- No DOI given, and none found for title: matADi: Material Definition with Automatic Differe...
- 10.1515/bmt-2014-0146 may be a valid DOI for title: Isotropic incompressible hyperelastic models for m...
- 10.1016/j.eurpolymj.2013.10.006 may be a valid DOI for title: An approach for hyperelastic model-building and pa...
- 10.1002/cnm.1105 may be a valid DOI for title: A model of incompressible isotropic hyperelastic m...
- No DOI given, and none found for title: A theory of large elastic deformation
- 10.1016/j.ijsolstr.2014.08.018 may be a valid DOI for title: Constitutive modeling of isotropic hyperelastic ma...
- 10.1002/app.41718 may be a valid DOI for title: New polynomial strain energy function; application...
- 10.1002/polb.20308 may be a valid DOI for title: Reconciling the fundamental phenomenological expre...
- No DOI given, and none found for title: A theory of large elastic deformation
- 10.1039/tf9433900241 may be a valid DOI for title: The elasticity of a network of long-chain molecule...
- 10.1063/1.1748111 may be a valid DOI for title: Statistical theory of rubber-like elasticity. IV.(...
- No DOI given, and none found for title: Calculation of rubber parts
- 10.1002/app.1975.070190723 may be a valid DOI for title: Strain energy functions of rubber. I. Characteriza...
- No DOI given, and none found for title: Strain-energy density function for rubberlike mate...
- 10.5254/1.3538289 may be a valid DOI for title: Characterization of elastic properties of carbon-b...
- 10.1016/s0022-5096(97)00028-8 may be a valid DOI for title: On the large deformation behaviour of reinforced r...
- 10.1016/s0020-7683(03)00086-6 may be a valid DOI for title: Polyconvexity of generalized polynomial-type hyper...
- 10.1007/s10659-010-9279-0 may be a valid DOI for title: A strain energy function for vulcanized rubbers
- 10.1002/app.41718 may be a valid DOI for title: New polynomial strain energy function; application...
- 10.1155/2019/2832059 may be a valid DOI for title: Modeling and verification of a new hyperelastic mo...
- 10.1007/bf00017296 may be a valid DOI for title: The finite anti-plane shear field near the tip of ...
- 10.1115/1.3225782 may be a valid DOI for title: A constitutive model for high elongation elastic m...
- 10.5254/1.3538706 may be a valid DOI for title: Characterization of the behavior of rubber for eng...
- 10.1016/j.nanoms.2021.07.003 may be a valid DOI for title: A comparative study of 85 hyperelastic constitutiv...
- 10.1002/polb.20308 may be a valid DOI for title: Reconciling the fundamental phenomenological expre...
- 10.1061/(asce)0733-9399(2006)132:1(54) may be a valid DOI for title: Hyperelasticity model for finite element analysis ...
- No DOI given, and none found for title: A new I1-based hyperelastic model for rubber elast...
- 10.5254/rct.19.80387 may be a valid DOI for title: A constitutive model for both low and high strain ...
- 10.1002/pen.10948 may be a valid DOI for title: Tools for multiaxial validation of behavior laws c...
- No DOI given, and none found for title: A new isotropic hyperelastic strain energy functio...
- 10.1007/bf01597242 may be a valid DOI for title: Elasticity parameters for finite deformations of r...
- No DOI given, and none found for title: A constitutive relation for rubber-like materials
- 10.1002/pol.1958.1202811814 may be a valid DOI for title: Forms for the stored (strain) energy function for ...
- 10.1016/s0997-7538(99)00147-3 may be a valid DOI for title: New phenomenological behavior laws for rubbers and...
- No DOI given, and none found for title: A new constitutive model for rubber-like materials
- No DOI given, and none found for title: A hyperelastic constitutive model for rubber-like ...
- 10.1007/bf01410637 may be a valid DOI for title: The use of the van der Waals model to elucidate un...
- 10.1007/bfb0115432 may be a valid DOI for title: Relaxation in permanent networks
- 10.1007/bf00254166 may be a valid DOI for title: A molecular interpretation of the parameters of th...
- 10.1016/0021-9290(87)90262-4 may be a valid DOI for title: Strain energy density function and uniform strain ...
- 10.1002/(sici)1099-0488(19970915)35:12<1919::aid-polb7>3.0.co;2-k may be a valid DOI for title: A new attempt to reconcile the statistical and phe...
- 10.5254/1.3547687 may be a valid DOI for title: A note on the Gent model for rubber-like materials
- 10.1007/s10659-005-4408-x may be a valid DOI for title: Constitutive models for compressible nonlinearly e...
- 10.1177/1081286507076405 may be a valid DOI for title: On constitutive models for limited elastic, molecu...
- 10.1007/s10659-006-9085-x may be a valid DOI for title: Limiting chain extensibility constitutive models o...
- 10.1063/1.1710039 may be a valid DOI for title: The strain-energy function of a hyperelastic mater...
- 10.1063/1.1661660 may be a valid DOI for title: Stored energy function of rubberlike materials der...
- 10.5254/1.3542910 may be a valid DOI for title: Large deformation isotropic elasticity–on the corr...
- No DOI given, and none found for title: Hyperelastic constitutive modeling under finite st...
- 10.5254/1.3547576 may be a valid DOI for title: Strain energy function for filled and unfilled rub...
- No DOI given, and none found for title: Modification of exponential based hyperelastic str...
- 10.1063/1.1586471 may be a valid DOI for title: Hybrid continuum model for large elastic deformati...
- No DOI given, and none found for title: A hyperelastic constitutive model for rubber-like ...
- No DOI given, and none found for title: Theory of elasticity of polymer networks. 3
- 10.1021/ma00231a023 may be a valid DOI for title: Relationships between stress, strain, and molecula...
- 10.1016/0032-3861(86)90231-4 may be a valid DOI for title: The effect of entanglements in rubber elasticity
- 10.1021/ma00198a026 may be a valid DOI for title: Theory of elasticity of amorphous networks: effect...
- 10.1016/s1089-3156(98)00010-5 may be a valid DOI for title: Theoretical and numerical formulation of a molecul...
- 10.1021/ma970364k may be a valid DOI for title: Nonaffine deformation and elasticity of polymer ne...
- No DOI given, and none found for title: Theory of the elastic properties of rubber
- 10.1016/0022-5096(93)90013-6 may be a valid DOI for title: A three-dimensional constitutive model for the lar...
- 10.1088/0370-1328/92/1/303 may be a valid DOI for title: The statistical mechanics of polymerized material
- 10.5254/1.3538822 may be a valid DOI for title: An extended tube-model for rubber elasticity: stat...
- 10.1016/s0032-3861(03)00411-7 may be a valid DOI for title: A Langevin-elasticity-theory-based constitutive eq...
- 10.1016/s0032-3861(03)00411-7 may be a valid DOI for title: A Langevin-elasticity-theory-based constitutive eq...
- 10.1016/j.jmps.2004.03.011 may be a valid DOI for title: A micro-macro approach to rubber-like materials—pa...
- 10.1016/j.jmps.2004.10.006 may be a valid DOI for title: Composite and filament models for the mechanical b...
- 10.1016/j.ijsolstr.2008.08.037 may be a valid DOI for title: Heuristic search for a predictive strain-energy fu...
- 10.1016/j.jmps.2013.03.009 may be a valid DOI for title: A nonaffine network model for elastomers undergoin...
- No DOI given, and none found for title: Analytical network-averaging of the tube model:: R...
- No DOI given, and none found for title: A general constitutive model of soft elastomers
- 10.1098/rspa.1979.0163 may be a valid DOI for title: A non-Gaussian theory for rubber in biaxial strain...
- 10.1016/0093-6413(92)90021-2 may be a valid DOI for title: On improved 3-D non-Gaussian network models for ru...
- 10.1016/0022-5096(93)90043-f may be a valid DOI for title: On improved network models for rubber elasticity a...
- 10.1016/s0020-7225(02)00140-4 may be a valid DOI for title: Constitutive equations for amended non-Gaussian ne...
- No DOI given, and none found for title: Scratch behavior of polymers
- 10.1007/s004190000102 may be a valid DOI for title: Viscoplasticity of elastomeric materials: experime...
- 10.2324/gomu.65.517 may be a valid DOI for title: Approximated form of the strain energy-density fun...
- 10.1177/10812865211001094 may be a valid DOI for title: On a new class of non-Gaussian molecular-based con...

INVALID DOIs

- None

AnjaliSandip commented 6 months ago

@cfarm6 Please refer to the suggested DOIs for the articles that are missing DOIs and add them if they are accurate.

cfarm6 commented 6 months ago

@AnjaliSandip I have added the missing DOIs where applicable. There are a couple references that do not have DOIs associated with them.

cfarm6 commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.cma.2024.116751 is OK
- 10.1115/1.4063348 is OK
- 10.1016/j.heliyon.2024.e25379 is OK
- 10.1016/j.commatsci.2024.112885 is OK
- 10.5281/zenodo.5519971 is OK
- 10.1515/bmt-2014-0146 is OK
- 10.1016/j.eurpolymj.2013.10.006 is OK
- 10.5281/zenodo.7738525 is OK
- 10.1002/cnm.1105 is OK
- 10.1137/141000671 is OK
- 10.1063/1.1712836 is OK
- 10.1016/j.ijsolstr.2014.08.018 is OK
- 10.1002/app.41718 is OK
- 10.1002/polb.20308 is OK
- 10.1063/1.1712836 is OK
- 10.1039/tf9433900241 is OK
- 10.1002/app.1975.070190723 is OK
- 10.1016/0022-5096(79)90034-6 is OK
- 10.5254/1.3538289 is OK
- 10.1016/S0022-5096(97)00028-8 is OK
- 10.1016/s0020-7683(03)00086-6 is OK
- 10.1007/s10659-010-9279-0 is OK
- 10.1002/app.41718 is OK
- 10.1155/2019/2832059 is OK
- 10.1007/bf00017296 is OK
- 10.1115/1.3225782 is OK
- 10.5254/1.3538706 is OK
- 10.1016/j.nanoms.2021.07.003 is OK
- 10.1002/polb.20308 is OK
- 10.1061/(ASCE)0733-9399(2006)132:1(54) is OK
- 10.1016/j.crme.2009.12.007 is OK
- 10.5254/rct.19.80387 is OK
- 10.1002/pen.10948 is OK
- 10.1007/bf01597242 is OK
- 10.1016/0020-7225(68)90006-2 is OK
- 10.1002/pol.1958.1202811814 is OK
- 10.1016/s0997-7538(99)00147-3 is OK
- 10.1016/j.euromechsol.2012.09.010 is OK
- 10.1007/bf01410637 is OK
- 10.1007/bfb0115432 is OK
- 10.1007/bf00254166 is OK
- 10.5254/1.3538357 is OK
- 10.1016/0021-9290(87)90262-4 is OK
- 10.1002/(sici)1099-0488(19970915)35:12<1919::aid-polb7>3.0.co;2-k is OK
- 10.5254/1.3547687 is OK
- 10.1007/s10659-005-4408-x is OK
- 10.1177/1081286507076405 is OK
- 10.1007/s10659-006-9085-x is OK
- 10.1063/1.1710039 is OK
- 10.1063/1.1661660 is OK
- 10.5254/1.3542910 is OK
- 10.1016/j.ijsolstr.2004.03.016 is OK
- 10.5254/1.3547576 is OK
- 10.22059/jcamech.2018.245070.204 is OK
- 10.1063/1.1586471 is OK
- 10.1021/ma00231a022 is OK
- 10.1021/ma00231a023 is OK
- 10.1016/0032-3861(86)90231-4 is OK
- 10.1021/ma00198a026 is OK
- 10.1016/s1089-3156(98)00010-5 is OK
- 10.1021/ma970364k is OK
- 10.1063/1.1723785 is OK
- 10.1016/0022-5096(93)90013-6 is OK
- 10.1088/0370-1328/92/1/303 is OK
- 10.5254/1.3538822 is OK
- 10.1016/s0032-3861(03)00411-7 is OK
- 10.1016/j.jmps.2004.03.011 is OK
- 10.1016/j.jmps.2004.10.006 is OK
- 10.1016/j.ijsolstr.2008.08.037 is OK
- 10.1016/j.jmps.2013.03.009 is OK
- 10.1016/j.jmps.2016.05.030 is OK
- 10.1016/j.jmps.2018.04.016 is OK
- 10.1098/rspa.1979.0163 is OK
- 10.1016/0093-6413(92)90021-2 is OK
- 10.1016/0022-5096(93)90043-f is OK
- 10.1016/s0020-7225(02)00140-4 is OK
- 10.1007/s004190000102 is OK
- 10.2324/gomu.65.517 is OK
- 10.1177/10812865211001094 is OK

MISSING DOIs

- No DOI given, and none found for title: Calculation of rubber parts
- No DOI given, and none found for title: A new isotropic hyperelastic strain energy functio...
- No DOI given, and none found for title: A new constitutive model for rubber-like materials
- No DOI given, and none found for title: Scratch behavior of polymers

INVALID DOIs

- https://doi.org/10.1063/1.1748111 is INVALID because of 'https://doi.org/' prefix

cfarm6 commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.cma.2024.116751 is OK
- 10.1115/1.4063348 is OK
- 10.1016/j.heliyon.2024.e25379 is OK
- 10.1016/j.commatsci.2024.112885 is OK
- 10.5281/zenodo.5519971 is OK
- 10.1515/bmt-2014-0146 is OK
- 10.1016/j.eurpolymj.2013.10.006 is OK
- 10.5281/zenodo.7738525 is OK
- 10.1002/cnm.1105 is OK
- 10.1137/141000671 is OK
- 10.1063/1.1712836 is OK
- 10.1016/j.ijsolstr.2014.08.018 is OK
- 10.1002/app.41718 is OK
- 10.1002/polb.20308 is OK
- 10.1063/1.1712836 is OK
- 10.1039/tf9433900241 is OK
- 10.1002/app.1975.070190723 is OK
- 10.1016/0022-5096(79)90034-6 is OK
- 10.5254/1.3538289 is OK
- 10.1016/S0022-5096(97)00028-8 is OK
- 10.1016/s0020-7683(03)00086-6 is OK
- 10.1007/s10659-010-9279-0 is OK
- 10.1002/app.41718 is OK
- 10.1155/2019/2832059 is OK
- 10.1007/bf00017296 is OK
- 10.1115/1.3225782 is OK
- 10.5254/1.3538706 is OK
- 10.1016/j.nanoms.2021.07.003 is OK
- 10.1002/polb.20308 is OK
- 10.1061/(ASCE)0733-9399(2006)132:1(54) is OK
- 10.1016/j.crme.2009.12.007 is OK
- 10.5254/rct.19.80387 is OK
- 10.1002/pen.10948 is OK
- 10.1007/bf01597242 is OK
- 10.1016/0020-7225(68)90006-2 is OK
- 10.1002/pol.1958.1202811814 is OK
- 10.1016/s0997-7538(99)00147-3 is OK
- 10.1016/j.euromechsol.2012.09.010 is OK
- 10.1007/bf01410637 is OK
- 10.1007/bfb0115432 is OK
- 10.1007/bf00254166 is OK
- 10.5254/1.3538357 is OK
- 10.1016/0021-9290(87)90262-4 is OK
- 10.1002/(sici)1099-0488(19970915)35:12<1919::aid-polb7>3.0.co;2-k is OK
- 10.5254/1.3547687 is OK
- 10.1007/s10659-005-4408-x is OK
- 10.1177/1081286507076405 is OK
- 10.1007/s10659-006-9085-x is OK
- 10.1063/1.1710039 is OK
- 10.1063/1.1661660 is OK
- 10.5254/1.3542910 is OK
- 10.1016/j.ijsolstr.2004.03.016 is OK
- 10.5254/1.3547576 is OK
- 10.22059/jcamech.2018.245070.204 is OK
- 10.1063/1.1586471 is OK
- 10.1021/ma00231a022 is OK
- 10.1021/ma00231a023 is OK
- 10.1016/0032-3861(86)90231-4 is OK
- 10.1021/ma00198a026 is OK
- 10.1016/s1089-3156(98)00010-5 is OK
- 10.1021/ma970364k is OK
- 10.1063/1.1723785 is OK
- 10.1016/0022-5096(93)90013-6 is OK
- 10.1088/0370-1328/92/1/303 is OK
- 10.5254/1.3538822 is OK
- 10.1016/s0032-3861(03)00411-7 is OK
- 10.1016/j.jmps.2004.03.011 is OK
- 10.1016/j.jmps.2004.10.006 is OK
- 10.1016/j.ijsolstr.2008.08.037 is OK
- 10.1016/j.jmps.2013.03.009 is OK
- 10.1016/j.jmps.2016.05.030 is OK
- 10.1016/j.jmps.2018.04.016 is OK
- 10.1098/rspa.1979.0163 is OK
- 10.1016/0093-6413(92)90021-2 is OK
- 10.1016/0022-5096(93)90043-f is OK
- 10.1016/s0020-7225(02)00140-4 is OK
- 10.1007/s004190000102 is OK
- 10.2324/gomu.65.517 is OK
- 10.1177/10812865211001094 is OK

MISSING DOIs

- No DOI given, and none found for title: Calculation of rubber parts
- No DOI given, and none found for title: A new isotropic hyperelastic strain energy functio...
- No DOI given, and none found for title: A new constitutive model for rubber-like materials
- No DOI given, and none found for title: Scratch behavior of polymers

INVALID DOIs

- doi.org/10.1063/1.1748111 is INVALID because of 'doi.org/' prefix

cfarm6 commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.cma.2024.116751 is OK
- 10.1115/1.4063348 is OK
- 10.1016/j.heliyon.2024.e25379 is OK
- 10.1016/j.commatsci.2024.112885 is OK
- 10.5281/zenodo.5519971 is OK
- 10.1515/bmt-2014-0146 is OK
- 10.1016/j.eurpolymj.2013.10.006 is OK
- 10.5281/zenodo.7738525 is OK
- 10.1002/cnm.1105 is OK
- 10.1137/141000671 is OK
- 10.1063/1.1712836 is OK
- 10.1016/j.ijsolstr.2014.08.018 is OK
- 10.1002/app.41718 is OK
- 10.1002/polb.20308 is OK
- 10.1063/1.1712836 is OK
- 10.1039/tf9433900241 is OK
- 10.1063/1.1748111 is OK
- 10.1002/app.1975.070190723 is OK
- 10.1016/0022-5096(79)90034-6 is OK
- 10.5254/1.3538289 is OK
- 10.1016/S0022-5096(97)00028-8 is OK
- 10.1016/s0020-7683(03)00086-6 is OK
- 10.1007/s10659-010-9279-0 is OK
- 10.1002/app.41718 is OK
- 10.1155/2019/2832059 is OK
- 10.1007/bf00017296 is OK
- 10.1115/1.3225782 is OK
- 10.5254/1.3538706 is OK
- 10.1016/j.nanoms.2021.07.003 is OK
- 10.1002/polb.20308 is OK
- 10.1061/(ASCE)0733-9399(2006)132:1(54) is OK
- 10.1016/j.crme.2009.12.007 is OK
- 10.5254/rct.19.80387 is OK
- 10.1002/pen.10948 is OK
- 10.1007/bf01597242 is OK
- 10.1016/0020-7225(68)90006-2 is OK
- 10.1002/pol.1958.1202811814 is OK
- 10.1016/s0997-7538(99)00147-3 is OK
- 10.1016/j.euromechsol.2012.09.010 is OK
- 10.1007/bf01410637 is OK
- 10.1007/bfb0115432 is OK
- 10.1007/bf00254166 is OK
- 10.5254/1.3538357 is OK
- 10.1016/0021-9290(87)90262-4 is OK
- 10.1002/(sici)1099-0488(19970915)35:12<1919::aid-polb7>3.0.co;2-k is OK
- 10.5254/1.3547687 is OK
- 10.1007/s10659-005-4408-x is OK
- 10.1177/1081286507076405 is OK
- 10.1007/s10659-006-9085-x is OK
- 10.1063/1.1710039 is OK
- 10.1063/1.1661660 is OK
- 10.5254/1.3542910 is OK
- 10.1016/j.ijsolstr.2004.03.016 is OK
- 10.5254/1.3547576 is OK
- 10.22059/jcamech.2018.245070.204 is OK
- 10.1063/1.1586471 is OK
- 10.1021/ma00231a022 is OK
- 10.1021/ma00231a023 is OK
- 10.1016/0032-3861(86)90231-4 is OK
- 10.1021/ma00198a026 is OK
- 10.1016/s1089-3156(98)00010-5 is OK
- 10.1021/ma970364k is OK
- 10.1063/1.1723785 is OK
- 10.1016/0022-5096(93)90013-6 is OK
- 10.1088/0370-1328/92/1/303 is OK
- 10.5254/1.3538822 is OK
- 10.1016/s0032-3861(03)00411-7 is OK
- 10.1016/j.jmps.2004.03.011 is OK
- 10.1016/j.jmps.2004.10.006 is OK
- 10.1016/j.ijsolstr.2008.08.037 is OK
- 10.1016/j.jmps.2013.03.009 is OK
- 10.1016/j.jmps.2016.05.030 is OK
- 10.1016/j.jmps.2018.04.016 is OK
- 10.1098/rspa.1979.0163 is OK
- 10.1016/0093-6413(92)90021-2 is OK
- 10.1016/0022-5096(93)90043-f is OK
- 10.1016/s0020-7225(02)00140-4 is OK
- 10.1007/s004190000102 is OK
- 10.2324/gomu.65.517 is OK
- 10.1177/10812865211001094 is OK

MISSING DOIs

- No DOI given, and none found for title: Calculation of rubber parts
- No DOI given, and none found for title: A new isotropic hyperelastic strain energy functio...
- No DOI given, and none found for title: A new constitutive model for rubber-like materials
- No DOI given, and none found for title: Scratch behavior of polymers

INVALID DOIs

- None

AnjaliSandip commented 6 months ago

@cfarm6 Can you release a new version of the software being reviewed and deposit a new archive with Zenodo/Figshare? After releasing the new version, please update the review thread with this archive DOI: @editorialbot set 10.5281/zenodo.xxxxxx as an archive.

arfon commented 6 months ago

@editorialbot set 10.5281/zenodo.xxxxxx as an archive.

@AnjaliSandip – just an FYI that this is something that only the editor can do.

AnjaliSandip commented 6 months ago

@arfon Thanks for letting me know. I previously thought the author completed this. After re-reading the editorial guide, I see this is not the case, as you state.

After @cfarm6 releases the new software version and deposits a new archive with Zenodo/Figshare, I will update this thread with the archive DOI.

cfarm6 commented 5 months ago

@AnjaliSandip 10.5281/zenodo.10903235

AnjaliSandip commented 5 months ago

@editorialbot set 10.5281/zenodo.10903235 as archive

editorialbot commented 5 months ago

Done! archive is now 10.5281/zenodo.10903235

AnjaliSandip commented 5 months ago

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

Double check authors and affiliations (including ORCIDs)
Make a release of the software with the latest changes from the review and post the version number here. This is the version that will be used in the JOSS paper.
Archive the release on Zenodo/figshare/etc and post the DOI here.
Make sure that the title and author list (including ORCIDs) in the archive match those in the JOSS paper.
Make sure that the license listed for the archive is the same as the software license.

Editor Tasks Prior to Acceptance

[x] Read the text of the paper and offer comments/corrections (as either a list or a pull request)
[x] Check that the archive title, author list, version tag, and the license are correct
[x] Set archive DOI with @editorialbot set <DOI here> as archive
[x] Set version with @editorialbot set <version here> as version
[x] Double check rendering of paper with @editorialbot generate pdf
[x] Specifically check the references with @editorialbot check references and ask author(s) to update as needed
[x] Recommend acceptance with @editorialbot recommend-accept

AnjaliSandip commented 5 months ago

@editorialbot set v0.1.3 as version

editorialbot commented 5 months ago

Done! version is now v0.1.3

AnjaliSandip commented 5 months ago

@editorialbot generate pdf

editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

openjournals / joss-reviews

[REVIEW]: Hyperelastics.jl: A Julia package for hyperelastic1 material modelling with a large collection of models #6314

Status

Reviewer instructions & questions

Checklists

Review checklist for @SotaYoshida

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @fb456

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

Editor Tasks Prior to Acceptance