search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: Aurora: An open-source python implementation of the EMTF package for magnetotelluric data processing using MTH5 and mt_metadata #6520

Closed editorialbot closed 5 months ago

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@kkappler<!--end-author-handle-- (karl kappler) Repository: https://github.com/simpeg/aurora Branch with paper.md (empty if default branch): joss Version: 0.3.12 Editor: !--editor-->@diehlpk<!--end-editor-- Reviewers: @blsqr, @sinanozaydin Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7d22a8379f812eb1fa42dd1a9bddad37"><img src="https://joss.theoj.org/papers/7d22a8379f812eb1fa42dd1a9bddad37/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7d22a8379f812eb1fa42dd1a9bddad37/status.svg)](https://joss.theoj.org/papers/7d22a8379f812eb1fa42dd1a9bddad37)

Author instructions

Thanks for submitting your paper to JOSS @kkappler. Currently, there isn't a JOSS editor assigned to your paper.

@kkappler if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 8 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 8 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.16 s (780.2 files/s, 281159.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          96           2483           5823           7778
XML                              2             22              0           2440
Jupyter Notebook                11              0          24668            848
JSON                             2              0              0            547
TeX                              1             18              0            174
Markdown                         1             44              0            103
reStructuredText                 8            112            136             73
CSV                              1              0              0             46
YAML                             2              1              4             32
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           126           2692          30639          12076
-------------------------------------------------------------------------------

Commit count by author:

  1177  Karl N. Kappler
    93  JP
    13  kkappler
    12  Lindsey Heagy
     9  Joseph Capriotti
     5  timronan
     3  Laura Keyson
     2  Karl Kappler
     1  Seogi Kang
editorialbot commented 8 months ago

Paper file info:

📄 Wordcount for paper.md is 1742

✅ The paper includes a Statement of need section

editorialbot commented 8 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 8 months ago

:warning: An error happened when generating the pdf. Problem with affiliations for Karl Kappler, perhaps the affiliations index need quoting?.

editorialbot commented 8 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1051/0004-6361/201629272 is OK
- 10.1051/0004-6361/201322068 is OK

MISSING DOIs

- 10.1016/j.cageo.2022.105270 may be a valid DOI for title: SigMT: An open-source Python package for magnetote...
- No DOI given, and none found for title: BIRRP: Bounded influence, remote reference process...
- 10.1016/j.cageo.2015.09.015 may be a valid DOI for title: SimPEG: An open source framework for simulation an...
- No DOI given, and none found for title: Continuous integration: improving software quality...
- 10.1111/j.1365-246x.1997.tb05663.x may be a valid DOI for title: Robust multiple-station magnetotelluric data proce...
- No DOI given, and none found for title: Mod3DMT and EMTF: Free Software for MT Data Proces...
- No DOI given, and none found for title: Processing and interpretation of electromagnetic i...
- 10.1111/rssa.12315 may be a valid DOI for title: Statistical challenges of administrative and trans...
- 10.1190/geo2018-0679.1 may be a valid DOI for title: EMTF XML: New data interchange format and conversi...
- 10.1093/gji/ggz197 may be a valid DOI for title: An automated new pre-selection tool for noisy Magn...
- 10.2481/dsj.ss_igy-009 may be a valid DOI for title: EMScope: A continental scale magnetotelluric obser...
- No DOI given, and none found for title: Resistics: A versatile native Python 3 package for...
- 10.3389/feart.2020.00296 may be a valid DOI for title: Razorback, an open source Python library for robus...
- No DOI given, and none found for title: The Magnetotelluric Method
- No DOI given, and none found for title: Gaps in Globular Cluster Streams: Pal 5 and the Ga...
- No DOI given, and none found for title: Galactic Dynamics: Second Edition
- No DOI given, and none found for title: MTHotel

INVALID DOIs

- None
kthyng commented 8 months ago

Hi @kkappler and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment as I have a chance to go through them:

kthyng commented 7 months ago

@kkappler some comments/questions:

kkappler commented 7 months ago

Hi Kristen,

Thank you for the prompts,

I pushed on the joss branch with the following updates:

Thanks,

Karl P.S. DOI Notes below:

MISSING DOIs

On Thu, Mar 28, 2024 at 3:19 PM Kristen Thyng @.***> wrote:

@kkappler https://github.com/kkappler some comments/questions:

  • Please look through the DOI notes above to see if anything needs to be addressed
  • Also look at the error generating the paper, to see if you can fix it
  • I recommend getting your tutorials into your docs so everything is easier to find

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6520#issuecomment-2026231043, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZ663SFKTWPEP2LLVK6QTY2SJQJAVCNFSM6AAAAABFCC6EGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWGIZTCMBUGM . You are receiving this because you were mentioned.Message ID: @.***>

kthyng commented 7 months ago

@editorialbot generate pdf

editorialbot commented 7 months ago

:warning: An error happened when generating the pdf. Problem with ORCID (0000-0000-0000-0000) for Laura Keyson. Invalid ORCID.

kthyng commented 7 months ago

@editorialbot check references

editorialbot commented 7 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.cageo.2022.105270 is OK
- 10.1016/j.cageo.2015.09.015 is OK
- 10.1111/j.1365-246x.1997.tb05663.x is OK
- 10.1023/A:1015012821040 is OK
- 10.1111/rssa.12315 is OK
- 10.1190/geo2018-0679.1 is OK
- 10.1093/gji/ggz197 is OK
- 10.2481/dsj.ss_igy-009 is OK
- 10.3389/feart.2020.00296 is OK

MISSING DOIs

- No DOI given, and none found for title: BIRRP: Bounded influence, remote reference process...
- No DOI given, and none found for title: Continuous integration: improving software quality...
- No DOI given, and none found for title: Mod3DMT and EMTF: Free Software for MT Data Proces...
- No DOI given, and none found for title: Resistics: A versatile native Python 3 package for...
- No DOI given, and none found for title: The Magnetotelluric Method
- No DOI given, and none found for title: MTHotel

INVALID DOIs

- None
kthyng commented 7 months ago

@kkappler Ok

danielskatz commented 7 months ago

The PDF error is an invalid ORCID. ORCID lines in the paper.md should either be valid ORCIDs or should be removed.

kkappler commented 7 months ago

Hi Kristen,

The pdf error should be fixed on the latest push.

There are not prepared docs for the joss branch, but the latest publicly available docs are here: https://simpeg.xyz/aurora/ . Please note also that a new release (3.13) is scheduled for this month, (PR already merged into main (https://github.com/simpeg/aurora/pull/322) -- just awaiting one PR/release on a dependency before we push to PyPI and condaforge.

best, Karl

On Mon, Apr 1, 2024 at 1:49 PM Kristen Thyng @.***> wrote:

@kkappler https://github.com/kkappler Ok

  • DOIs look good
  • maybe a new error in PDF — can you check it out above?
  • Is there a place I can see readthedocs of your joss branch? Can't remember if those links are public.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6520#issuecomment-2030529768, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZ66Z2OQXQM3AO6B64E63Y3HB5HAVCNFSM6AAAAABFCC6EGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGUZDSNZWHA . You are receiving this because you were mentioned.Message ID: @.***>

kthyng commented 7 months ago

@editorialbot generate pdf

kthyng commented 7 months ago

@kkappler Hey the docs look great with those tutorials in them! Maybe they could use a little massaging/reordering, but still really good.

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 7 months ago

@kkappler We have a backlog of submissions so I will add this to our waitlist. In the meantime, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them. Thanks for your patience.

kkappler commented 7 months ago

Thanks for the update and feedback.

We filtered for earth science and python processing and found these names:

And backup list:

kthyng commented 6 months ago

@AnjaliSandip Having a hard time telling who might be a fit as editor for this. Could you edit this?

kthyng commented 6 months ago

@editorialbot invite @AnjaliSandip as editor

editorialbot commented 6 months ago

Invitation to edit this submission sent!

kthyng commented 6 months ago

My apologies @AnjaliSandip, it looks like you do biomechanics-type work, I suspect you were going to turn me down when you saw this.

@diehlpk might you be able to edit this?

kthyng commented 6 months ago

@editorialbot invite @diehlpk as editor

editorialbot commented 6 months ago

Invitation to edit this submission sent!

diehlpk commented 6 months ago

@editorialbot add @diehlpk as editor

editorialbot commented 6 months ago

Assigned! @diehlpk is now the editor

diehlpk commented 6 months ago

Hi @danielmk do you have time to review this paper?

diehlpk commented 6 months ago

Hi @alejandrojuria do you have time to review this paper?

diehlpk commented 6 months ago

Hi @maple367 do you have time to review this paper?

maple367 commented 6 months ago

Sorry for not. I am not familiar with magnetotelluric data processing.

发件人: Patrick Diehl @.> 发送时间: 2024年5月6日 22:33 收件人: openjournals/joss-reviews @.> 抄送: Hai HUANG @.>; Mention @.> 主题: Re: [openjournals/joss-reviews] [PRE REVIEW]: Aurora: An open-source python implementation of the EMTF package for magnetotelluric data processing using MTH5 and mt_metadata (Issue #6520)

Hi @maple367https://github.com/maple367 do you have time to review this paper?

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/6520#issuecomment-2096182030, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYICFZFFWCGZQJS3JKPQ3WLZA6IBVAVCNFSM6AAAAABFCC6EGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJWGE4DEMBTGA. You are receiving this because you were mentioned.Message ID: @.**@.>>

danielmk commented 6 months ago

Hi @danielmk do you have time to review this paper?

Unfortunately I have no experience with magnetotelluric data. I briefly looked at the paper and I don't think I am qualified to review.

alejandrojuria commented 6 months ago

Hi @alejandrojuria do you have time to review this paper?

I am sorry but I have to decline, I do not think I have the expertise nor the time to do a proper review of the paper.

diehlpk commented 6 months ago

Hi @mrava87 do you have time to review this paper?

diehlpk commented 6 months ago

Hi @kwinkunks do you have time to review this paper?

diehlpk commented 6 months ago

Hi @dostuffthatmatters do you have time to review this paper?

mrava87 commented 6 months ago

@diehlpk thanks for the invite, however I’m not really into magnetotellurics, so I don’t think I can provide a valuable feedback here 😔

dostuffthatmatters commented 6 months ago

Hi @diehlpk,

thank you for considering me. The paper content is quite far from what I know, so I don't think I am qualified to review either. Good luck for your search!

Best, Moritz

diehlpk commented 6 months ago

Hi @blsqr do you have time to review this paper?

diehlpk commented 6 months ago

Hi @krischer do you have time to review this paper?

diehlpk commented 6 months ago

Hi @gchure do you have time to review this paper?

blsqr commented 6 months ago

Hi @diehlpk, I'd be interested in reviewing this submission but will only be able to start early June. If this would not delay review too much, please sign me up.

diehlpk commented 6 months ago

@editorialbot add @blsqr as reviewer

editorialbot commented 6 months ago

@blsqr added to the reviewers list!

gchure commented 6 months ago

Hi @diehlpk, the package looks cool, but is a bit too far out of my domain to give a thorough review.

diehlpk commented 6 months ago

Hi @rmsare do you have time to review this paper?

diehlpk commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left: