swisstopo address source: add timeout?

openoereb / pyramid_oereb

pyramid_oereb is an open-source implementation of the server side part for the Swiss "Cadastre of Public-law Restrictions on landownership" (PLR-cadastre).

Other

8 stars 22 forks source link

swisstopo address source: add timeout? #1875

Closed michmuel closed 2 months ago

michmuel commented 11 months ago

Shall we introduce a timeout at https://github.com/openoereb/pyramid_oereb/blob/1a3ba4bc9010d479473d5d88b00e31bab5ac1e7e/pyramid_oereb/contrib/data_sources/swisstopo/address.py#L64 ?

michmuel commented 11 months ago

As I understand there is no default time out (https://requests.readthedocs.io/en/latest/user/quickstart/#timeouts). @svamaa, @voisardf, @vvmruder, @jwkaltz: Shall we add 3s? Or leave it unchanged?

voisardf commented 11 months ago

@michmuel personally I would go for an slightly higher value - maybe 5s?

vvmruder commented 11 months ago

3s is enaough I would say. Otherwise we could make it configurable.