search

openooh / venue-taxonomy

The intention of this project is to standardize the list of venue types that represent Digital-Out-of-Home (DOOH) advertising screens within a programmatic OpenRTB 2.5 context. The systematization of DOOH venue types will allow for clearer targeting by media buying platforms across a spectrum of available supply-side platforms offering DOOH inventory.
http://openooh.media
36 stars 30 forks source link

Introduce a 0 in front of parent types #126

Closed Armitage35 closed 1 year ago

Armitage35 commented 1 year ago

A minor inconsistency if you look from the outside is that children and grand children enums always start with a 0 whereas parent start with a 1. This means that the count of digits is not always the same depending on if you are looking to a transit to Government parent category (1-9) vs financial and residential (10-11).

This is a minor issue in edge cases where we are looking at the numbers of digits to determine the venue type. Not critical and certainly has a good reason but strange from the outside.

jayshao commented 1 year ago

I don't believe we should do this, as it would be a compatibility breaking change (though I don't disagree it's inconsistent)

Armitage35 commented 1 year ago

I agree, this would cause a bunch of issues when running auctions.

jayshao commented 1 year ago

Based on concerns for impacts to machine-readable serializations and compatibility - this is not something being considered for 1.x series releases - but if we ever do a 2.0 and break compatibility anyway, then this (and similar rationalizations) could be considered