search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

SDN-4930: Revert "OCPBUGS-38414: Revert #1988 "Graduate `UserDefinedNetworks` to GA"" #1997

Open tssurya opened 3 months ago

tssurya commented 3 months ago

Reverts openshift/api#1996 https://github.com/openshift/origin/pull/28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe.

@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms)

The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again.

openshift-ci-robot commented 3 months ago

@tssurya: This pull request references SDN-4919 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to [this](https://github.com/openshift/api/pull/1997): >Reverts openshift/api#1996 >https://github.com/openshift/origin/pull/28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe > >@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

Hello @tssurya! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

tssurya commented 3 months ago

/payload 4.18 ci blocking /payload 4.18 nightly blocking

openshift-ci[bot] commented 3 months ago

@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cef7fd70-5971-11ef-8e9c-fd73856402bf-0

trigger 10 job(s) of type blocking for the nightly release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cef7fd70-5971-11ef-8e9c-fd73856402bf-1

tssurya commented 3 months ago

/payload cancel

openshift-ci[bot] commented 3 months ago

@tssurya: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

tssurya commented 3 months ago

/payload-abort

openshift-ci[bot] commented 3 months ago

@tssurya: aborted active payload jobs for pull request openshift/api#1997

openshift-ci[bot] commented 3 months ago

@smg247: This PR was included in a payload test run from openshift/origin#28997 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/502783a0-5974-11ef-88ea-51e3322bf150-0

openshift-ci[bot] commented 3 months ago

@smg247: This PR was included in a payload test run from openshift/origin#28997 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c93b2670-5974-11ef-94b4-ebabd8a793eb-0

tssurya commented 3 months ago

/payload 4.18 ci blocking /payload 4.18 nightly blocking

openshift-ci[bot] commented 3 months ago

@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ebfdfce0-59f7-11ef-922d-84ad5312de64-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ebfdfce0-59f7-11ef-922d-84ad5312de64-1

openshift-ci-robot commented 3 months ago

@tssurya: This pull request references SDN-4919 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to [this](https://github.com/openshift/api/pull/1997): >Reverts openshift/api#1996 >https://github.com/openshift/origin/pull/28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe. > >@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms) > >The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
anuragthehatter commented 3 months ago

/lgtm /label qe-approved

openshift-ci-robot commented 3 months ago

@tssurya: This pull request references SDN-4919 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to [this](https://github.com/openshift/api/pull/1997): >Reverts openshift/api#1996 >https://github.com/openshift/origin/pull/28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe. > >@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms) > >The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tssurya commented 3 months ago

/retest-required

openshift-ci[bot] commented 3 months ago

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 4 job(s) of type blocking for the ci release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d5e52620-5a76-11ef-8cf6-cba82feaebc3-0

openshift-ci[bot] commented 3 months ago

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea0bb010-5a76-11ef-8170-4812ecdc1d87-0

tssurya commented 3 months ago

/retest-required

tssurya commented 3 months ago

/retest-required

tssurya commented 3 months ago

/payload 4.18 ci blocking /payload 4.18 nightly blocking

openshift-ci[bot] commented 3 months ago

@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9cae2d30-5aac-11ef-92b9-f2c993677c34-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9cae2d30-5aac-11ef-92b9-f2c993677c34-1

openshift-ci[bot] commented 3 months ago

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 4 job(s) of type blocking for the ci release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8d2ebc20-5ab7-11ef-8555-1c089b208de9-0

openshift-ci[bot] commented 3 months ago

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1de333d0-5abe-11ef-983f-862ee23e83ff-0

openshift-ci[bot] commented 3 months ago

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3cb7f6b0-5abe-11ef-9387-ff294f89ad91-0

openshift-ci[bot] commented 3 months ago

@ormergi: This PR was included in a payload test run from openshift/origin#28995 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/09943ab0-5b08-11ef-9839-571e36a6895a-0

openshift-ci[bot] commented 3 months ago

@ormergi: This PR was included in a payload test run from openshift/origin#28995 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5fb66670-5b08-11ef-9ac7-70a30b4950ee-0

tssurya commented 3 months ago

/hold we will hold merging this for now because @JoelSpeed showed another workaround that @trozet showed me which is to have lanes run as presubmits with UDN enabled which I didn't know we could do! that will help us get the signal we need.

openshift-ci[bot] commented 3 months ago

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 4 job(s) of type blocking for the ci release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a9f97d80-5bd0-11ef-9106-821b4d285fa7-0

openshift-ci[bot] commented 3 months ago

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b2636bc0-5bd0-11ef-8f6b-ff174841c8a0-0

stbenjam commented 3 months ago

/test verify

Just checking if metal shows up

stbenjam commented 3 months ago

/test verify

openshift-ci[bot] commented 3 months ago

@ormergi: This PR was included in a payload test run from openshift/origin#28995 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d1d45330-5d73-11ef-9a7f-e73dabc2a915-0

openshift-ci[bot] commented 3 months ago

@ormergi: This PR was included in a payload test run from openshift/origin#28995 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e0c7afe0-5d73-11ef-835c-f127b811b5d4-0

tssurya commented 3 months ago

@stbenjam yeah the metal is showing up.. looks like we need more runs on that :D

tssurya commented 3 months ago

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn 10

openshift-ci[bot] commented 3 months ago

@tssurya: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3fa07720-5e20-11ef-9a73-769c3cdb2a25-0

stbenjam commented 3 months ago

/test verify

stbenjam commented 3 months ago

payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn 10

Are you trying to get more signal for the verify job? These won't contribute to it, since it's from a PR. It only considers signal from merged PR's. I can kick off a couple jobs if you need it.

stbenjam commented 3 months ago

/test verify

tssurya commented 3 months ago

payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn 10

Are you trying to get more signal for the verify job? These won't contribute to it, since it's from a PR. It only considers signal from merged PR's. I can kick off a couple jobs if you need it.

yeah how do I trigger techpreview vsphere jobs? I couldn't get the right job name :(

stbenjam commented 2 months ago

/test verify

stbenjam commented 2 months ago

/test verify

stbenjam commented 2 months ago

Only one test remaining that's not at the threshold - I kicked off 10x metal jobs to boost signal, should hopefully know in a few hours

image
anuragthehatter commented 1 month ago

Apparently, bot can't build on this PR due to merge conflicts :(

tssurya commented 1 month ago

oopsy will rebase tomorrow

anuragthehatter commented 1 month ago

@tssurya Can we rebase it so QE can build clusters on this build? It seems some CRD validations won't work unless we bring clusters with this API changes

openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

tssurya commented 1 month ago

@anuragthehatter see if it works now?

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter, tssurya Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment