openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 517 forks source link

CORS-3695: Update the api for aws cluster hosted dns options #2046

Closed barbacbd closed 1 month ago

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

JoelSpeed commented 1 month ago

/hold

I think there's a legitimate issue that needs to be looked into here

JoelSpeed commented 1 month ago

The issue in the serial techpreview is

E1004 19:23:40.502435       1 upgrade_monitor.go:382] Error applying MCN Spec: MachineConfigNode.machineconfiguration.openshift.io "ip-10-0-90-100.us-west-1.compute.internal" is invalid: spec.configVersion.desired: Invalid value: "": spec.configVersion.desired in body should match '^([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]{0,61}[a-zA-Z0-9])(\.([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]{0,61}[a-zA-Z0-9]))*$'
E1004 19:23:40.502455       1 sync.go:812] Error making MCN spec for Update Compatible: MachineConfigNode.machineconfiguration.openshift.io "ip-10-0-90-100.us-west-1.compute.internal" is invalid: spec.configVersion.desired: Invalid value: "": spec.configVersion.desired in body should match '^([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]{0,61}[a-zA-Z0-9])(\.([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]{0,61}[a-zA-Z0-9]))*$'

Which is on the MachineConfigNodes CRD which is not touched by this PR. I also can't see any changes to anything to do with the desired version that would be affected by this PR, MCO logs look, otherwise, to be happy.

Happy to unhold and will poke the MCO team about this

/hold cancel

openshift-ci[bot] commented 1 month ago

@barbacbd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202410071240.p0.g82e0822.assembly.stream.el9. All builds following this will include this PR.