search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

OPRUN-3401: Promote NewOLM to Default FeatureSet #2099

Closed joelanford closed 9 hours ago

joelanford commented 1 week ago

This PR promotes the NewOLM feature to the Default featureset for SelfManaged clusters. OLMv1 is not ready to be included in Hypershift clusters. The regenerated CRDs will only be pulled into the payload after this PR merges and is incorporated into https://github.com/openshift/cluster-olm-operator/pull/74

/hold

Holding until we are ready for this to merge (we have a few other tasks to execute first)

openshift-ci-robot commented 1 week ago

@joelanford: This pull request references OPRUN-3401 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2099): >This PR promotes the `NewOLM` feature to the `Default` featureset. The regenerated CRDs will only be pulled into the payload after this PR merges and is incorporated into https://github.com/openshift/cluster-olm-operator/pull/74 > >/hold > >Holding until we are ready for this to merge (we have a few other tasks to execute first) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

Hello @joelanford! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

perdasilva commented 3 days ago

I've cloned this PR (#2101) - to kick CI over until you show up in the morning so we can burn these down.

joelanford commented 3 days ago

@perdasilva I updated this PR so that we stop showing up in Hypershift. @LalatenduMohanty will be submitting a new PR today in cluster-olm-operator that is similar to https://github.com/openshift/cluster-olm-operator/pull/86 (which had to be reverted due to hypershift failures). It will essentially be a re-apply of 86, but with the corrected set of annotations.

openshift-ci-robot commented 3 days ago

@joelanford: This pull request references OPRUN-3401 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2099): >This PR promotes the `NewOLM` feature to the `Default` featureset for SelfManaged clusters. OLMv1 is not ready to be included in Hypershift clusters. The regenerated CRDs will only be pulled into the payload after this PR merges and is incorporated into https://github.com/openshift/cluster-olm-operator/pull/74 > >/hold > >Holding until we are ready for this to merge (we have a few other tasks to execute first) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
perdasilva commented 2 days ago

/retest

joelanford commented 2 days ago

/test verify

joelanford commented 2 days ago

/retest

joelanford commented 2 days ago

/label acknowledge-critical-fixes-only

jianzhangbjz commented 2 days ago

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-4.18-upgrade-from-stable-4.18-azure-ipi-proxy-tp-arm-f60

jianzhangbjz commented 1 day ago

Pre-merge test fail, details: https://redhat-internal.slack.com/archives/C06KP34REFJ/p1732095507235489?thread_ts=1732077839.541179&cid=C06KP34REFJ

tmshort commented 1 day ago

/test ci/prow/verify

openshift-ci[bot] commented 1 day ago

@tmshort: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/api/pull/2099#issuecomment-2489103137): >/test ci/prow/verify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tmshort commented 1 day ago

/test verify

joelanford commented 1 day ago

/payload-with-prs 4.18 nightly blocking openshift/cluster-olm-operator#74,openshift/api#2099

openshift-ci[bot] commented 1 day ago

@joelanford: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

joelanford commented 1 day ago

/payload-with-prs 4.18 ci blocking openshift/cluster-olm-operator#74 openshift/api#2099

openshift-ci[bot] commented 1 day ago

@joelanford: trigger 4 job(s) of type blocking for the ci release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1f932580-a764-11ef-91df-736755db3e6c-0

openshift-ci[bot] commented 1 day ago

@joelanford: This PR was included in a payload test run from openshift/api#2099 trigger 4 job(s) of type blocking for the ci release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1f932580-a764-11ef-91df-736755db3e6c-0

joelanford commented 1 day ago

/payload-with-prs 4.18 nightly blocking openshift/cluster-olm-operator#74 openshift/api#2099 openshift/operator-framework-operator-controller#196 openshift/operator-framework-catalogd#90 openshift/origin#29312

openshift-ci[bot] commented 1 day ago

@joelanford: trigger 14 job(s) of type blocking for the nightly release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8415a6a0-a76d-11ef-8e6a-5e18a0a92929-0

openshift-ci[bot] commented 1 day ago

@joelanford: This PR was included in a payload test run from openshift/api#2099 trigger 14 job(s) of type blocking for the nightly release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8415a6a0-a76d-11ef-8e6a-5e18a0a92929-0

jianzhangbjz commented 1 day ago

/label qe-approved

openshift-ci-robot commented 1 day ago

@joelanford: This pull request references OPRUN-3401 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2099): >This PR promotes the `NewOLM` feature to the `Default` featureset for SelfManaged clusters. OLMv1 is not ready to be included in Hypershift clusters. The regenerated CRDs will only be pulled into the payload after this PR merges and is incorporated into https://github.com/openshift/cluster-olm-operator/pull/74 > >/hold > >Holding until we are ready for this to merge (we have a few other tasks to execute first) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
grokspawn commented 1 day ago

/test verify

grokspawn commented 1 day ago

/retest

joelanford commented 23 hours ago

/hold cancel

joelanford commented 23 hours ago

@JoelSpeed, with @jianzhangbjz's approval, we are ready for this to merge.

/override ci/prow/verify

/override ci/prow/verify-crd-schema

openshift-ci[bot] commented 23 hours ago

@joelanford: Overrode contexts on behalf of joelanford: ci/prow/verify, ci/prow/verify-crd-schema

In response to [this](https://github.com/openshift/api/pull/2099#issuecomment-2490179372): >@JoelSpeed, with @jianzhangbjz's approval, we are ready for this to merge. > >/override ci/prow/verify >- based on @jianzhangbjz 's approval > >/override ci/prow/verify-crd-schema >- based on "In some cases you may have changed or renamed a file that already contained api violations, but you are not introducing a new violation. In such cases it is appropriate to /override the failing CI job." Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
perdasilva commented 22 hours ago

/retest ci/prow/e2e-aws-ovn

openshift-ci[bot] commented 22 hours ago

@perdasilva: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

/test build
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial
/test e2e-aws-serial-techpreview
/test e2e-upgrade
/test images
/test integration
/test minor-e2e-upgrade-minor
/test minor-images
/test unit
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-azure
/test e2e-gcp
/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-api-master-build
pull-ci-openshift-api-master-e2e-aws-ovn
pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
pull-ci-openshift-api-master-e2e-aws-serial
pull-ci-openshift-api-master-e2e-aws-serial-techpreview
pull-ci-openshift-api-master-e2e-azure
pull-ci-openshift-api-master-e2e-gcp
pull-ci-openshift-api-master-e2e-upgrade
pull-ci-openshift-api-master-images
pull-ci-openshift-api-master-integration
pull-ci-openshift-api-master-minor-e2e-upgrade-minor
pull-ci-openshift-api-master-minor-images
pull-ci-openshift-api-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-api-master-unit
pull-ci-openshift-api-master-verify
pull-ci-openshift-api-master-verify-client-go
pull-ci-openshift-api-master-verify-crd-schema
pull-ci-openshift-api-master-verify-deps
In response to [this](https://github.com/openshift/api/pull/2099#issuecomment-2490349615): >/retest ci/prow/e2e-aws-ovn Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jianzhangbjz commented 21 hours ago

/lgtm

JoelSpeed commented 19 hours ago

/lgtm

openshift-ci[bot] commented 19 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, joelanford, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 18 hours ago

/retest-required

Remaining retests: 0 against base HEAD caf97963ed302881f01e67b791ae4efc6bcf723c and 2 for PR HEAD 917f3bfd3d28f429b7e89b296acdd5906e572f92 in total

JoelSpeed commented 18 hours ago

/retest

perdasilva commented 18 hours ago

/retest e2e-aws-serial

openshift-ci[bot] commented 18 hours ago

@perdasilva: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

/test build
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial
/test e2e-aws-serial-techpreview
/test e2e-upgrade
/test images
/test integration
/test minor-e2e-upgrade-minor
/test minor-images
/test unit
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-azure
/test e2e-gcp
/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-api-master-build
pull-ci-openshift-api-master-e2e-aws-ovn
pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
pull-ci-openshift-api-master-e2e-aws-serial
pull-ci-openshift-api-master-e2e-aws-serial-techpreview
pull-ci-openshift-api-master-e2e-azure
pull-ci-openshift-api-master-e2e-gcp
pull-ci-openshift-api-master-e2e-upgrade
pull-ci-openshift-api-master-images
pull-ci-openshift-api-master-integration
pull-ci-openshift-api-master-minor-e2e-upgrade-minor
pull-ci-openshift-api-master-minor-images
pull-ci-openshift-api-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-api-master-unit
pull-ci-openshift-api-master-verify
pull-ci-openshift-api-master-verify-client-go
pull-ci-openshift-api-master-verify-crd-schema
pull-ci-openshift-api-master-verify-deps
In response to [this](https://github.com/openshift/api/pull/2099#issuecomment-2490923365): >/retest e2e-aws-serial Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jianzhangbjz commented 17 hours ago

Hi @JoelSpeed, can we override those non-required jobs and let it merge? Thanks! Once https://github.com/openshift/cluster-olm-operator/pull/74 is merged, these failure test cases can pass.

joelanford commented 17 hours ago

/test e2e-aws-serial

LalatenduMohanty commented 17 hours ago

@JoelSpeed can we override e2e-aws-serial test failure as it is a non-required test, also QE has approved the PR. Also after merge https://github.com/openshift/cluster-olm-operator/pull/74 it will improve the pass rate of the test. Need to merge this PR first then we can merge https://github.com/openshift/cluster-olm-operator/pull/74

openshift-ci-robot commented 14 hours ago

/retest-required

Remaining retests: 0 against base HEAD ec9bf3faa1aa2f52805c44b7b13cd7ab4b984241 and 1 for PR HEAD 917f3bfd3d28f429b7e89b296acdd5906e572f92 in total

JoelSpeed commented 14 hours ago

/hold we concluded some origin changes need to go in, and then this will likely need a green button merge simultaneously with openshift/cluster-olm-operator#74

joelanford commented 13 hours ago

Origin PR that needs to merge first: https://github.com/openshift/origin/pull/29313

LalatenduMohanty commented 12 hours ago

https://github.com/openshift/origin/pull/29313 has merged

joelanford commented 12 hours ago

https://github.com/openshift/origin/pull/29313 and https://github.com/openshift/cluster-olm-operator/pull/74 have merged. Proceeding now with a merge of this PR.

/hold cancel /overrride ci/prow/e2e-aws-ovn

joelanford commented 12 hours ago

/skip /override ci/prow/e2e-aws-serial

openshift-ci[bot] commented 12 hours ago

@joelanford: Overrode contexts on behalf of joelanford: ci/prow/e2e-aws-serial

In response to [this](https://github.com/openshift/api/pull/2099#issuecomment-2491945824): >/skip >/override ci/prow/e2e-aws-serial >- it will fail until it runs against a payload containing https://github.com/openshift/cluster-olm-operator/pull/74 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
joelanford commented 12 hours ago

/override ci/prow/e2e-aws-ovn

openshift-ci[bot] commented 12 hours ago

@joelanford: Overrode contexts on behalf of joelanford: ci/prow/e2e-aws-ovn

In response to [this](https://github.com/openshift/api/pull/2099#issuecomment-2491947373): >/override ci/prow/e2e-aws-ovn Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.