openshift-ci-robot
commented
4 years ago @Prashanth684: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.
In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/189):
>[release-4.3]: Use virtio disk instead of config drive for injecting ignition for s390x/ppc64le
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Prashanth684
crawford
zeenix
openshift-bot
Similar to dmacvicar/terraform-provider-libvirt#718
The method of mimicking what Openstack does for injecting ignition config works for images which have the provider as Openstack because ignition recognizes the platform and knows it has to get the ignition config from the config drive. For QEMU images, ignition supports getting the config from the firmware config device which is not supported by ppc64 and s390x.
The workaround we have used thus far is to use the Openstack image on the QEMU platform but have this provider create the iso containing the ignition config. There was a discussion in ignition (coreos/ignition#928) to have a more QEMU based method of injecting ignition config and it was decided to use a virtio-blk device with a serial of ignition which ignition can recognize. This was mainly because with external devices, it is hard to tell if there is an issue with the device or if the kernel has not detected it yet if it has a long discovery phase.
This PR replaces the the method of ignition injection from a conig drive disk to a virtio-blk device.
Reference PR which supports ignition fetching through virtio-blk for QEMU: coreos/ignition#936