search

opensource-ny / OpenSource-NY

MIT License
10 stars 14 forks source link

Logo Misplacement #104

Open darrenzhang2000 opened 4 years ago

darrenzhang2000 commented 4 years ago

The logo is misplaced! Should be on the bottom left of the client page rather covering the bottom of the ranks table.

darrenzhang2000 commented 4 years ago

Hi! I have identified the issue and I found a solution to this problem. Will submit pull request shortly.

yizongk commented 4 years ago

Hi darren!

Thanks for the documentations and the logo placement fix man!

I am gonna to review the changes later tonight and merge.

For next time, can you separate your pull request into two? One for documentation and one for the logo? This would make issues/pull requests more manageable! You don't have to change anything about your current PR this time though :^)

yizongk commented 4 years ago

Just an update to this issue for future contributor:

The PR that was submitted by darrenzhang2000 only concern the documentation. The Logo misplacement is still an open issue. I think now