search

opensource-ny / OpenSource-NY

MIT License
10 stars 14 forks source link

Need a basic login page that will check for authorization through GitHub API. #36

Closed guti21js closed 5 years ago

guti21js commented 5 years ago

Basic HTML needs a text box for username and password to use for authorization with GitHub API.

zhik commented 5 years ago

Let's not collect any passwords. Instead use Github's built in Application OAuth

Examples can be found here

I will try to help out on Friday.

yizongk commented 5 years ago

The scope of this authorization is limited to accessing private repos. I think! Because the public repo will have their PR info public. I may be wrong, will see it as it comes up in the future.

mxmsunny commented 5 years ago

Should we still have a text box for the username?

yizongk commented 5 years ago

yes! We should still have a text box for username, but I would suggest holding that off til we get to the part where we actually need a box for the username for implementing our particular feature. Because right now, we don't really need it yet.

mxmsunny commented 5 years ago

okiedokie thanks!

Fioringo commented 5 years ago

As we agreed before, we don't want to collect passwords and other information about the users. Maybe down the road, but for right now I think we should just track all of the public pull requests and commits. This way we limit liability and can keep track of the scores easier.

This issue may be re-opened later on.