search

opensource-ny / OpenSource-NY

MIT License
10 stars 14 forks source link

Changed port number to 3000 and added login #37

Closed guti21js closed 5 years ago

guti21js commented 5 years ago

Changed port to 3000 in server.js according to instructions and added login and password into index.html.

guti21js commented 5 years ago

Hey @yizongk can you review this before I merge.

zhik commented 5 years ago

Don't change the port to 3000 in server.js, it will conflict with react.

guti21js commented 5 years ago

Okay so then I will change the README then.

yizongk commented 5 years ago

Ya, React is using port 3000, i changed server.js to port 5000 for that reason. As of right now, React read from port 3000 and redirect it to port 5000 when it interacts with server.js

yizongk commented 5 years ago

Is there also a way to do the form in React? by editing src/myapp/client/src/App.js? Because I am not sure if editing the index.html is a good idea. That html is meant to be a blank page that will be updated with content returned from App.js

Which means that App.js in the future can potentital wipe out the form input boxes in the future as it will do its job by updating that html with new content by overwriting certain area of the html.