search

opensource-ny / OpenSource-NY

MIT License
10 stars 14 forks source link

added some styling to the website, also added the login fields #42

Closed mxmsunny closed 5 years ago

mxmsunny commented 5 years ago

Not the prettiest, but it's something to get us going? I made the username password forms, and the submit does nothing as of yet. It's clickable, though.

tempweb

mxmsunny commented 5 years ago

@Gutierrezjdr would the login thing be okay like this for now?

yizongk commented 5 years ago

@mxmsunny It looks great. Just two thing I am not sure of and want some other opinion:

  1. I think Zhi mentioned something about using github authorization to log in, instead of actual username and password. So this way we don't have to worry about security. Refer to #36

  2. On REACT's side, is it a good idea to edit anywhere else beside App.js?

mxmsunny commented 5 years ago

@yizongk Thanks for the input! 1) oh okay! I'll comment out the login fields and submit another PR! 2) Imo, I think it's fine to edit other places beside App.js. I just created a components folder with other js files that are called in App.js so it doesn't become a huge clutter of code. I think @Fioringo can confirm/give more input on this question.