search

opensource-ny / OpenSource-NY

MIT License
10 stars 14 forks source link

Rank list starts count at zero #92

Closed yizongk closed 4 years ago

yizongk commented 4 years ago

the person with the most PRs on the ranking list, is currently listed like 0. 1. 2. etc

Should really be like 1. 2. 3. Counting starting at one

rursteve2 commented 4 years ago

https://github.com/opensource-ny/OpenSource-NY/pull/93

yizongk commented 4 years ago

Hey stephen, the place you have made the change is at the constructor of RankElement.

I think we should leave the constructor alone, so that it constructs RankElement with values that you gave it as input.

I think you should move your fix to the place where RankElement is getting constructed. I am pretty it's in Ranks.js

In Ranks.js there's a place where RankElement is being created, that would be a good place to move your fix to.

Thanks man!