search

openspacelabs / react-native-zoomable-view

A view component for react-native with pinch to zoom, tap to move and double tap to zoom capability.
MIT License
189 stars 57 forks source link

Lint issues #60

Closed steven-pearson closed 1 year ago

steven-pearson commented 1 year ago

While consuming in another project, lint will complain about two import paths as they need to be relative

Resolved in https://github.com/openspacelabs/react-native-zoomable-view/pull/59

Details of lint error output

yarn run v1.22.19 $ tsc --noemit && eslint --ext .js,.jsx,.ts,.tsx ./ node_modules/@openspacelabs/react-native-zoomable-view/src/animations/index.ts:2:23 - error TS2307: Cannot find module 'src/typings' or its corresponding type declarations.

2 import { Vec2D } from 'src/typings';


node_modules/@openspacelabs/react-native-zoomable-view/src/helper/index.ts:2:23 - error TS2307: Cannot find module 'src/typings' or its corresponding type declarations.

2 import { Vec2D } from 'src/typings';

Found 2 errors in 2 files.

Errors Files 1 node_modules/@openspacelabs/react-native-zoomable-view/src/animations/index.ts:2 1 node_modules/@openspacelabs/react-native-zoomable-view/src/helper/index.ts:2 error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

steven-pearson commented 1 year ago

@thomasttvo Will you be publishing a new version to npm?