search

openspacelabs / react-native-zoomable-view

A view component for react-native with pinch to zoom, tap to move and double tap to zoom capability.
MIT License
212 stars 58 forks source link

Need onStartShouldSetPanResponderCapture to steal PanResponder from Childs #91

Closed easy-bios closed 2 months ago

easy-bios commented 8 months ago

The missing onStartShouldSetPanResponderCapture prop makes it impossible to steal PanResponder on Move if Child has a Pressable: https://stackoverflow.com/questions/75975994/react-native-zoomable-view-child-component-should-have-onpress-and-be-pannable

To fix this we need onStartShouldSetPanResponderCapture as an Prop.

elliottkember commented 8 months ago

This sounds like a good idea – please open a pull request with the changes and we'll review it. Thank you!

easy-bios commented 8 months ago

This is my first time contributing somewhere. Please give me some advice if there is something wrong with the pill request. ;)

https://github.com/openspacelabs/react-native-zoomable-view/pull/93

DanielKuhn commented 3 weeks ago

I'm having the exact same problem (Pressable inside zoomable view consumes pan event) and don't understand the solution outlined here. Could someone explain, please?