search

openspending-archive / satellite-template

Create dedicated Where Does My Money Go style websites quickly and easily
6 stars 15 forks source link

Defaults of a salary and a tax in Dailybread cannot be changed with _config.yml #4

Closed jmblog closed 11 years ago

jmblog commented 11 years ago

Even if I change the default values of a salary and a tax in _config.yml, app/dailybread/dailybread.js overwrites them in OpenSpending.DailyBread.init().

trickvi commented 11 years ago

Yeah, this is pretty messy at the moment and really tied to wheredoesmymoneygo.org. I'm actually working on the dailybread now so I might be able to solve this soon. Is this something you need as soon as possible (before the global city spending party)?

jmblog commented 11 years ago

Thanks, @tryggvib! Could you fix this before the spending party? Some of us are planning to create WDMMG sites for locals at the party.

trickvi commented 11 years ago

I'l fix this before the spending party.

One question. Dailybread uses taxman and you don't seem to have one for Japan. You might want to take a look at that as well (or if you intend to do this differently I'd like to know so I can take your approach into account in my fix).

jmblog commented 11 years ago

Great, thanks! About the taxman, I intend to add a module for Japan before the spending party.

trickvi commented 11 years ago

@jmblog I've made a change to dailybread in openspendingjs to allow for this change. The change just creates a few configurables that can be passed in via a opts objects. In order for it to be accepted into openspendingjs we need someone to review it. Could you perhaps do a review on the pull request? It's pull request number 24.

You just have to take a look at the code and see if there's anything wrong with the changes. We have some guidelines on how to do code reviews but it's basically give it a +1 or a -1 to indicate if it's good to merge or not.