opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Implement new Phenotypes data table on disease/phenotype profile page #1332

Closed andrewhercules closed 3 years ago

andrewhercules commented 3 years ago

The new GraphQL API disease endpoint now exposes more phenotypes data. And so we can replace the current unordered list with a more comprehensive data table. Further details and spec TBC.

Example diseases with phenotypes: Cowden Syndrome, Noonan Syndrome, ulcerative colitis

andrewhercules commented 3 years ago

Data is now available from the development API branch - see sample query

Data table design

Can we please implement the following data table based on the design spec? Please note that the section title has changed to Clinical Signs and Symptoms.

Phenotypes_spec

Important note

Expand the number of entries in row.evidence as each entry should be in its own row. Please check sample query above for examples where row.evidence has multiple entries. Also check Orphanet_1934 for an example phenotype - Muscular hypotonia - with 11 evidence entries

Column content

Qualifier

Phenotype

Phenotype ID

Aspect

Frequency

Onset

Modifier

Sex

Evidence

Value returned by API Tool tip text
IEA Inferred from Electronic Annotations (IEA) are extracted by parsing the Clinical Features sections of the Online Mendelian Inheritance in Man resource
PCS Published Clinical Study (PCS) are annotations extracted from articles in the medical literature with the PubMed ID of the published study (if available)
TAS Traceable Author Statement (TAS) is used for information gleaned from knowledge bases such as OMIM or Orphanet that have derived the information from a published source

Source

References

QC checks

andrewhercules commented 3 years ago

@LucaFumis the spec is complete

@d0choa please review the spec above. I slightly adjusted the "References" column as the identifers.org link structure won't work due to the prefixes - instead we can link directly to the HPO website

d0choa commented 3 years ago

It looks fantastic. Thank you @andrewhercules

d0choa commented 3 years ago

@LucaFumis @andrewhercules The name of the widget was never updated. I would recommend changing the name to avoid confusion with "phenotypes" that show up in our disease profile pages.

More importantly, the sources need to be updated to HPO and MONDO as described in the spec.

andrewhercules commented 3 years ago

Noted - I've added to the feedback document for the next round of polish

andrewhercules commented 3 years ago

Ticket closed as work completed and merged into beta

Polish work will be captured in subsequent Beta Release polish ticket

andrewhercules commented 3 years ago

@LucaFumis for Integration Day tomorrow - 24 February - can we please make the following small adjustments?

  1. Change the name of the detail view to "Clinical signs and symptoms"
  2. Change the letter acronym to "CS"
  3. Update the "Source: EFO" list to include
LucaFumis commented 3 years ago

Last requested changes were implemented for Integration day. Ticket can be closed, I imagine.

andrewhercules commented 3 years ago

Ticket closed as work completed and merged into main for Beta release