opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Update Chemical Probes summary widget and detail view #1677

Closed andrewhercules closed 2 years ago

andrewhercules commented 2 years ago

See comment below for full design specification — https://github.com/opentargets/platform/issues/1677#issuecomment-896677359

JarrodBaker commented 2 years ago

Steps required to unblock from BE:

andrewhercules commented 2 years ago

With the new target ETL pipeline and API response, we have new Chemical Probe insights that we can display on the target profile page.

query targetInfo {
  target(ensemblId: "ENSG00000204256") {
    id
    approvedSymbol
    chemicalProbes{
      id
      control
      drugId
      inchiKey
      mechanismOfAction
      origin
      probeMinerScore
      probesDrugScore
      scoreInCells
      scoreInOrganisms
      targetFromSourceId
      urls{
        niceName
        url
      }
    }
  }
}

Sample query: BRD2 (ENSG00000204256)

Can we please update the Chemical Probes summary widget and detail view to show the new data?

Summary widget

In the current production Platform, we display the sources of the chemical probes data, separated by a bullet:

Screenshot 2021-08-11 at 10 13 38

Instead, can we please show the total number of chemical probes returned in the chemicalProbes array?

Screenshot 2021-08-11 at 10 15 32

Detail view

The new Chemical Probes detail view will only have one data table, showing data for all different sources.

-[ ] Please remove the old table component (OtTableRF) and replace with the new Open Targets table component

Probe ID Reported target Mechanism of action Probe origin Score Source
id with control as tooltip, if available targetFromSourceId mechanismOfAction origin Score chips (see below) n sources where n = length of urls array

Chemical Probes (2)

Probe Miner: probeMinerScore Drugs: probesDrugScore Cells: scoreInCells Organisms: scoreInOrganisms

For each chip, please show an on-hover tooltip with the score and the description of the score that has been provided by @ireneisdoomed below (see https://github.com/opentargets/platform/issues/1677#issuecomment-896893979).

The overall style and interaction pattern for the chips can copy the approach taken for the driver method chips in the intOGen evidence data table.

Chemical Probes (1)

d0choa commented 2 years ago

Looks great. Only one minor comment. The score columns: Probe Miner, Drug, Cell and Organism have a lot of nulls. Each row very rarely have more than one non-null and often they are all nulls. I feel they might do the table unnecessarily wide.

An alternative could be to have a single column with the header "Scores" and have chips or other element that say Probeminer: 20 Drug Score: 70, etc. Sort of what we did for intogen.

We should also have on-hover interactions to explain what each score means. @ireneisdoomed can you come out with labels for each of the 4?

On a different note, the control column is very strange. It can have names DDR-TRK-1N but also integers 1. It's secondary information and also very frequently null. We could make it a tooltip of Probe ID that says Control: DDR-TRK-1N.

andrewhercules commented 2 years ago

Good idea @d0choa! I have created a design mockup and updated the ticket

ireneisdoomed commented 2 years ago

The mock-ups look awesome @andrewhercules!

Proposed labels for the chips:

d0choa commented 2 years ago

Looks great @LucaFumis. After discussion with @ireneisdoomed, we have a few minor suggestions:

@ireneisdoomed is looking at how to make the URLs more specific/useful from the data side and also removing the label (suitable probes) from the Probe Miner reference niceNames. None of these changes will impact FE

LucaFumis commented 2 years ago

Front end work done.