opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Miss-handled API response crashes variant page due to undefined object #2045

Closed d0choa closed 3 years ago

d0choa commented 3 years ago

URL: https://dev--genetics-app.netlify.app/variant/1_154453788_C_T

Variable:

{"variantId": "1_154453788_C_T"}

GQL API Query

query VariantPageQuery($variantId: String!) {
  variantInfo(variantId: $variantId) {
    rsId
    chromosome
    position
    chromosomeB37
    positionB37
    refAllele
    altAllele
    nearestGene {
      id
      symbol
      __typename
    }
    nearestGeneDistance
    nearestCodingGene {
      id
      symbol
      __typename
    }
    nearestCodingGeneDistance
    mostSevereConsequence
    caddRaw
    caddPhred
    gnomadAFR
    gnomadAMR
    gnomadASJ
    gnomadEAS
    gnomadFIN
    gnomadNFE
    gnomadNFEEST
    gnomadNFENWE
    gnomadNFESEU
    gnomadOTH
    __typename
  }
  genesForVariantSchema {
    qtls {
      id
      sourceId
      sourceLabel
      sourceDescriptionOverview
      sourceDescriptionBreakdown
      pmid
      tissues {
        id
        name
        __typename
      }
      __typename
    }
    intervals {
      id
      sourceId
      sourceLabel
      sourceDescriptionOverview
      sourceDescriptionBreakdown
      pmid
      tissues {
        id
        name
        __typename
      }
      __typename
    }
    functionalPredictions {
      id
      sourceId
      sourceLabel
      sourceDescriptionOverview
      sourceDescriptionBreakdown
      pmid
      tissues {
        id
        name
        __typename
      }
      __typename
    }
    distances {
      id
      sourceId
      sourceLabel
      sourceDescriptionOverview
      sourceDescriptionBreakdown
      pmid
      tissues {
        id
        name
        __typename
      }
      __typename
    }
    __typename
  }
  genesForVariant(variantId: $variantId) {
    gene {
      id
      symbol
      __typename
    }
    overallScore
    qtls {
      sourceId
      aggregatedScore
      tissues {
        tissue {
          id
          name
          __typename
        }
        quantile
        beta
        pval
        __typename
      }
      __typename
    }
    intervals {
      sourceId
      aggregatedScore
      tissues {
        tissue {
          id
          name
          __typename
        }
        quantile
        score
        __typename
      }
      __typename
    }
    functionalPredictions {
      sourceId
      aggregatedScore
      tissues {
        tissue {
          id
          name
          __typename
        }
        maxEffectLabel
        maxEffectScore
        __typename
      }
      __typename
    }
    distances {
      typeId
      sourceId
      aggregatedScore
      tissues {
        tissue {
          id
          name
          __typename
        }
        distance
        score
        quantile
        __typename
      }
      __typename
    }
    __typename
  }
  indexVariantsAndStudiesForTagVariant(variantId: $variantId) {
    associations {
      indexVariant {
        id
        rsId
        __typename
      }
      study {
        studyId
        traitReported
        pmid
        pubDate
        pubAuthor
        hasSumstats
        __typename
      }
      pval
      nTotal
      overallR2
      posteriorProbability
      oddsRatio
      oddsRatioCILower
      oddsRatioCIUpper
      beta
      betaCILower
      betaCIUpper
      direction
      __typename
    }
    __typename
  }
  tagVariantsAndStudiesForIndexVariant(variantId: $variantId) {
    associations {
      tagVariant {
        id
        rsId
        __typename
      }
      study {
        studyId
        traitReported
        pmid
        pubDate
        pubAuthor
        __typename
      }
      pval
      nTotal
      overallR2
      posteriorProbability
      __typename
    }
    __typename
  }
}
d0choa commented 3 years ago

I'm investigating whether there is a data issue and not really a FE issue

andrewhercules commented 3 years ago

Issue appears to be fixed as previously crashing variant pages are now working, along with a correct PheWAS plot