I would expect same icon going to the same page

[mkarmona]

I would expect the same icon to go to the same page as it is confusing having two different buttons behaving the same but looking different.

[mirandaio]

@mkarmona the query string parameters in the URL are different, so, the links go to different versions of the locus page.

[mkarmona]

@mirandaio same page but different configuration. both buttons must show the same icon and slightly different message, which I personally think should be the same though.

[andrewhercules]

I agree with Miguel. Ideally all Locus View buttons should look the same. But it might be tricky given how small the buttons are in the data tables.

On Tue, Oct 9, 2018, 12:20 PM Miguel Carmona, notifications@github.com wrote:

@mirandaio https://github.com/mirandaio same page but different configuration. both buttons must show the same icon and slightly different message, which I personally think should be the same though.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <opentargets/issues#2303>, or mute the thread https://github.com/notifications/unsubscribe-auth/AHJK0h3mHoIlFfygqf695El56-hbx-hbks5ujIaBgaJpZM4XS2P_ .

[andrewhercules]

@mirandaio, as a short-term solution, can we please alter the variant page header so that it is line with the gene page header with a larger Locus View button (with icon)?

All other small buttons - for example in the PheWAS table - will remain as-is because the icon isn't optimised for a smaller space.

@ElaineMcA, once the short-term fix is implemented, this ticket can be closed. A broader "look & feel" ticket will be opened pending the PoC Platform project as we will want to harmonise the visual style and framework for both services.

[andrewhercules]

Issue closed as it will be addressed in opentargets/issues#2086