Closed ElaineMcA closed 6 years ago
Those labels (e.g. "Mutations in common diseases") are defined in https://github.com/opentargets/targetGenomeBrowser/blob/master/src/targetGenomeBrowser.js
Will then need @emepyc to update it in npm, or better to give some of us publish permission in npm.
Also, just to summarise, are the changes as follow? In the browser tracks: 1) "Mutations in common diseases" : change to "Variants in common disease" 2) "Mutations in rare diseases" : keep as it is? In the browser legend: 3) "Mutation in NOD2 associated with Crohn's disease" : change to "Variant in NOD2 associated..." 4) "Mutation associated with Crohn's disease in other genes" : change to "Variant associated with..." In the tables: 5) keep "variant" in common disease table and "mutation" in rare diseases?
Yes, this is correct.
This is our FAQ: https://docs.targetvalidation.org/faq/variants-or-mutations
I will add more of @iandunham's explanation to the current FAQ.
Just to follow-up from yesterday's front-end/UX meeting, it was decided that the changes will be made as summarised by @LucaFumis above:
"Mutations in common diseases" : change to "Variants in common disease" "Mutations in rare diseases" : keep as it is
In the browser legend:
"Mutation in NOD2 associated with Crohn's disease" : change to "Variant in NOD2 associated..." "Mutation associated with Crohn's disease in other genes" : change to "Variant associated with..."
In the tables:
Keep "variant" in common disease table and "mutation" in rare diseases table
Deployed in version 3.7.4
@nikiforosk commented on Wed Aug 30 2017
Yesterday I met Jeff and we were looking at the Genetic associations for SNCA - Parkinson's: https://www.targetvalidation.org/evidence/ENSG00000145335/EFO_0002508?view=sec:genetic_associations
He mentioned that on the browser widget we should be using the term "variant(s)" instead of "mutation(s)":
The reason for this, as far as I understood, is that mutations are variants that have not been inherited by one's parent whereas what we show in these tracks are common variants from GWAS. Although many people use both terms interchangeably, this is not correct in Jeff's view.
We also noticed that on 2nd column of the Common diseases table we use the header "Variant" while the corresponding column on the Rare diseases is called "Mutation". Jeff was OK with that (although this seems to suggest that it's OK to use "Mutations" on the 2nd track of the widget - but not on the 1st track and the legend underneath). @iandunham any thoughts?
@iandunham commented on Wed Aug 30 2017
Cheers Ian
Ian Dunham M.A. D.Phil Scientific Director Open Targets European Bioinformatics Institute (EMBL-EBI) European Molecular Biology Laboratory Wellcome Genome Campus Hinxton Cambridge CB10 1SD United Kingdom
Tel: 01223 492636 FAX: 01223 494468 dunham@ebi.ac.uk
http://targetvalidation.org http://opentargets.org http://twitter.com @DunhamReal
@deniseOme commented on Thu Sep 07 2017
Jeff is not the first to be concerned with the way we interchangebly use 'variant' and 'mutation'. This was raised at the training UCL Alzheimers Res UK in July and discussed in one of our meetings where @iandunham asked me to list the places (yet to be done by me) where variants and mutations are used (the latter should be in rare disease track, and in cancer only). Ensembl calls mutations the variants coming from COSMIC (who mantains cancer gene census) and from The Human Gene Mutation Database (http://www.hgmd.cf.ac.uk/ac/index.php). Everything else is variants.
We can choose our definition based on @iandunham's comments above and stick with it. I will draft something and circulate. Once it's agreed we can have this as a FAQ (or tool tip in the Browser view and other places).