opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Implement method to flag trans-qtl associations #3124

Open DSuveges opened 9 months ago

DSuveges commented 9 months ago

Upon ingesting and processing QTLs, we need to differentiate between cis and trans QTLs. Cis QTLs (associations in the close vicinity of the studied gene) are believed to be more reliable causal associations than further (trans) QTLs. The applied distance is quite arbitrary, but it is in the order of +/-1.5Mbp around the transcription start and stop of the gene.

We need a method that flags transQTLs after window based clumping. I imagine it would work like this:

updated_qtl_study_locus = window_clumped_qtl_study_locus.flag_trans_qtls(
    study_index,
    gene_index,
    window_size
)

The implied the method would be part of the StudyLocus class, and would need:

Then each study locus, that are located outside of this window around the gene would be considered as trans. This annotation would be added to the qualityControls array using the usual instruments provided by the class.

If this method should be part of the STudyLocus dataset is up to debate. There are pros and cons:

I personally believe we should not distinguish between gwas and qtls at all. This nature of the study is solely a concern of the study table.

@ireneisdoomed , @d0choa Please feel free to chip in.

ireneisdoomed commented 9 months ago

We have logic for V2G that resembles the task. VariantAnnotation.get_distace_to_tss extracts all variant/gene pairs within a window. The scoring part is irrelevant.

I have a more general question related to how we want to deal with QTLs. In this case the trait refers to a gene product. We need to introduce a geneId column either in StudyIndex or StudyLocus, correct?

DSuveges commented 9 months ago

There are some details under the main QTL ticket, @tskir has been working on. The study datamodel is expected to be extended with some extra columns.

d0choa commented 9 months ago

I might need to think a bit deeper in the ramifications of this, but cis/trans looks like a property of V2G/L2G. It does not look very natural as a property of a StudyLocus. 🤔