opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Gathering feedback on the new 'Export' and 'Pinning' functionalities in AOTF (23.12 release) #3153

Closed buniello closed 8 months ago

buniello commented 10 months ago

This ticket will contain feedback from testing of the new 'Export' functionality in AOTF (23.12 release). Any feedback welcome - user journey, style, data quality in downloaded files. Platform Dev Link

ireneisdoomed commented 10 months ago

In general:

I've tested the export function in SPATA24

Copy URL button

The Copy URL button didn't totally work as I was expecting. However, the functionality of keeping the state is so cool that I'd perhaps make it more visible and I'd change the word copy to share

Data export

I did all possible combinations: pinned/unpinned diseases, with and without adjusting sources, and filtering/not filtering by data type, and using TSV/JSON exports and I didn't find any discrepancy with what I could see in the UI. It's great that the export actually works!

Other comments:

buniello commented 10 months ago

thank you @ireneisdoomed - we are discussing these in FE meeting!

HelenaCornu commented 10 months ago

I agree with everything Irene said!

Some additional comments or things that were different for me:

Copy URL button

I am slightly confused about whether what is going on is expected or not.

Search box design

Export box design

By default, clicking on the download tabs from this view (JSON or TSV) will export the entire association table. Please expand the advanced options to customise the export parameters.

Downloaded files

prashantuniyal02 commented 10 months ago

Things to be done for this release:

Discarded:

HelenaCornu commented 10 months ago

Additional suggestion:

prashantuniyal02 commented 10 months ago

As pointed out by Helena, this seems to be a bug. Is this intentional?

  1. Go to a disease aotf page (e.g. Melanoma)
  2. Pin 2-3 targets (BRAF, NRAS, KIT)
  3. Now in the search bar, search for another disease (e.g. Cancer)
  4. In the new disease page, the targets are still pinned. However the URL does not display the pinned list of targets

image

prashantuniyal02 commented 10 months ago

The isPinned column in downloaded data does not work correctly for tsv and json.

Image

Image

prashantuniyal02 commented 10 months ago

The export has the same associated-targets data for both diseases and targets in the export header and the filename.

image image

buniello commented 10 months ago

I also came across the bug reported by Helena above: pinned/uploaded rows do not disappear with a page refresh. Given we still don't provide e "clear all" functionality and users need to remove the pins manually one by one (and with the uploads functionality we are talking about hundreds potentially), I believe fixing this bug is important - together with providing a "clear all" tab