Closed buniello closed 8 months ago
In general:
I've tested the export function in SPATA24
Copy URL
buttonThe Copy URL
button didn't totally work as I was expecting. However, the functionality of keeping the state is so cool that I'd perhaps make it more visible and I'd change the word copy
to share
I did all possible combinations: pinned/unpinned diseases, with and without adjusting sources, and filtering/not filtering by data type, and using TSV/JSON exports and I didn't find any discrepancy with what I could see in the UI. It's great that the export actually works!
Other comments:
thank you @ireneisdoomed - we are discussing these in FE meeting!
I agree with everything Irene said!
Some additional comments or things that were different for me:
Copy URL
buttonI am slightly confused about whether what is going on is expected or not.
copy url
it doesn't have the pinned targets ❌associations aggregation
By default, clicking on the download tabs from this view (JSON or TSV) will export the entire association table. Please expand the advanced options to customise the export parameters.
Things to be done for this release:
isPinned
column in downloaded dataPrioritization Aggregation
to Prioritisation Aggregation
in the advance export (z -> s)Copy URL. Data sources controls not included
Discarded:
Download completed
pop up message when download is complete. (The user might move to any other page while the download is in progress)Additional suggestion:
As pointed out by Helena, this seems to be a bug. Is this intentional?
The isPinned
column in downloaded data does not work correctly for tsv and json.
isPinned
column true values into one.isPinned
values are false, even though they are pinned on the UI. (in the case I tested, 4 rows were pinned, the json had 1 value as true and 3 were false for isPinned
isPinned
column working as expectedThe export has the same associated-targets data for both diseases and targets in the export header and the filename.
disease_name-associated-targets data
and exporting from a target page, it should be target_name-associated-diseases data
in both export header and filename for both json and tsv.OT-
as a prefix in the download file name for both disease and target page, so that the full filename reads, OT-EFO_0001421-associated-targets-30_11_2023-v23_12.json
I also came across the bug reported by Helena above: pinned/uploaded rows do not disappear with a page refresh. Given we still don't provide e "clear all" functionality and users need to remove the pins manually one by one (and with the uploads functionality we are talking about hundreds potentially), I believe fixing this bug is important - together with providing a "clear all" tab
This ticket will contain feedback from testing of the new 'Export' functionality in AOTF (23.12 release). Any feedback welcome - user journey, style, data quality in downloaded files. Platform Dev Link