Multiselect button causes Metrics app to crash

[ireneisdoomed]

Describe the bug Compare metrics tab crashes when selecting the two runs for comparison at the same time.

Observed behaviour The work done in https://github.com/opentargets/ot-release-metrics/pull/28 introduced this weird behaviour that can lead to the metrics app crashing:

• When we open the dropdown to select which 2 subruns to compare

  

• if we select both subruns at the same time the page goes blank and the logging shows

  Traceback (most recent call last):
  File "/mount/src/ot-release-metrics/app.py", line 147, in main
  data, selected_runs = select_and_mask_data_to_compare(all_releases, all_runs, data)
  File "/mount/src/ot-release-metrics/src/metric_visualisation/utils.py", line 288, in select_and_mask_data_to_compare
  masks_run = (data["runId"] == select_runs[0]) | (data["runId"] == select_runs[1])
  IndexError: list index out of range

Expected behaviour The error happens because the selector needs to update the masks_run state one selection at a time.

This is minor. To avoid the error simply:

• select the first subrun
• let the app update
• select the second subrun

To Reproduce Steps to reproduce the behaviour:

1. Go to https://open-targets-metrics.streamlit.app/
2. Click on Compare metrics
3. Choose 24.03 as major release ID
4. Select 24.03_2024-03-05 and 24.03_2024-02-22 in the dropdown menu
5. See error