opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Removing splicing QTL effect sizes to build "variantFunctionalConsequenceFromQtlId" evidence column. #3283

Closed Juanmaria-rr closed 2 months ago

Juanmaria-rr commented 2 months ago

Background

The current interpretation of splicing QTL (sQTL) beta coefficients for the direction of effect assessment is not informative, where negative are interpreted as loss of function and positive ones as gain of function.

For now we propose to remove them from the assessment for the direction of effect (DoE), so we will need to filter them out when building the evidences.

This issue is also addressing the point 1 of the issue raised by @Daniel-Considine here.

Tasks

Acceptance tests

When direction of effect data shows no directionality from sQTL evidences.

How do we know the task is complete?

  1. Using an user case raised in genetics slack channel: On the associations page for Lymphocyte count associated with TYK2 (link), for the variant 19_10351837_C_T, the DoE is loss of function | Risk, where the loss of function comes from the Decreased gene product level derived from the highest effect size of sQTLs. After removing sQTL, this should appear as a gain of function | Risk.
ireneisdoomed commented 2 months ago

Looking at the ETL code, the value for variantEffect is based on variantFunctionalConsequenceFromQtlId, a value generated during the OTG evidence generation. @remo87 @Juanmaria-rr Can you confirm this is true? If so, it's up to us to filter out sQTLs in the logic and we'd have it fixed by next release.

Juanmaria-rr commented 2 months ago

Yes @ireneisdoomed, I think that would be the step to include to remove the sQTL effect sizes from the DoE assessment.

DSuveges commented 2 months ago

It's here So, the data team can update the parsers by filtering out sQTLs from the aggregation.

d0choa commented 2 months ago

In #3282, @addramir and @Daniel-Considine suggested changing the logic of the aggregation. Instead of using the largest effect size, which could be problematic for poorly powered studies, use the lowest p-value. I would try to introduce this change in the same script as well.

@Juanmaria-rr will have some estimates on the impact of this change.

@buniello This will imply changing a tooltip and documentation.

DSuveges commented 2 months ago

The parser and the data is updated. The data is here:

gs://otar000-evidence_input/Genetics_portal/json/genetics-portal-evidence-2024-04-16.json.gz

Benchmark against old data

Questions:

Answers: