opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Issues with the facets filtering #3362

Closed prashantuniyal02 closed 5 days ago

prashantuniyal02 commented 6 days ago

Describe the bug When using the facets filtering, currently the search also gives results for the terms that match the category values.

Observed behaviour Currently the facets filtering search also gives results for the terms that match the category values.

Expected behaviour This needs to be discussed in more detail but the values of the categories should also be displayed to the user.

To Reproduce Steps to reproduce the behaviour:

  1. Go to any target association page. Say KRAS
  2. Type 't' in the Facets filters
  3. See 'Therapeutic Area' as a result
  4. Click on any 'Therapeutics Area'
jdhayhurst commented 5 days ago

Just noting here that it's easy to disable the category searching in the API. Given that we display the categories in the drop-down menu, there's probably not much value in having the category search enabled.

buniello commented 5 days ago

I also think we could remove the category search, because the categories are already displayed in the dropdown. If this is an easy fix, i would perhaps release it as soon as ready.