opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Locus Drawer object in Credible Sets Widgets #3407

Closed buniello closed 1 week ago

buniello commented 1 month ago

The locus drawer will open from the number field in the credible set size column, for both GWAS and molQTLs widget. if credible sets size is 7, the drawer will contain 7 rows for 7 variants in the locus.

Credible sets widget ticket

Discussed with @DSuveges and Genetics Team.

Pending credible sets API deployment at time of drafting this, we have scoped this object with this schema:


"locus": [
    {
      "is95CredibleSet": true,
      "is99CredibleSet": true,
      "logBF": null,
      "posteriorProbability": 0.8281915098204469,
      "variantId": "3_50557710_C_T",
      "pValueMantissa": null,
      "pValueExponent": null,
      "beta": null,
      "standardError": 0.9999996011812708,
      "r2Overall": 1.0000000000000027
    },

TABLE/DRAWER:

  1. HEADER: VARIANT ID - variantId
  2. HEADER: P-VALUE - pValueMantissa & pValueExponent (Table will be sorted/sortable by this column)
  3. HEADER: BETA - beta - Tooltip: Beta with respect to the ALT allele
  4. HEADER: SE standardError-Tooltip: Standard Error: Estimate of the standard deviation of the sampling distribution of the beta
  5. HEADER: LD (r2) - r2Overall - Tooltip: Linkage disequilibrium with the queried variant
  6. HEADER: POSTERIOR PROBABILITY - posteriorProbability - Tooltip: Posterior inclusion Probability from fine-mapping that this variant is causal
  7. HEADER: LOG(BF) - logBF
  8. HEADER: IS IN 95% CREDIBLE SET - is95CredibleSet
d0choa commented 1 month ago

We are not considering representing as much data, but this is an equivalent view for inspiration: https://r11.finngen.fi/region/I9_HYPTENS/20:58876654-59376654

Correction: There is a difference in the fact we are representing a study-locus whereas they are representing a locus across all studies.

d0choa commented 1 month ago

A few comments from @addramir:

d0choa commented 1 month ago

As discussed on August 7th, we will make progress on the credible set API endpoint while @gjmcn is away, so it simplifies the locus drawer implementation

buniello commented 3 weeks ago

I would still keep the is95CredibleSet field in table (same as current OTG) as my understanding from discussion with Daniel S is that not all variants are in the 95% (but they all are in 99%).

buniello commented 2 weeks ago

@gjmcn - please pause implementation on this for now (more scoping happening in the background)

buniello commented 1 week ago

this task is not planned anymore as replaced by this