opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Promote features for new L2G feature matrix #3456

Open project-defiant opened 5 days ago

project-defiant commented 5 days ago

As a user I want document and refactor list of features included in the new feature matrix because I want to document them properly and test the feature template interface.

Background

Refactoring of the feature matrix https://github.com/opentargets/issues/issues/3252 allows genetics team to revisit the implementation of existing L2G features described in https://github.com/opentargets/issues/issues/3458

Tasks

This task is the continuation of #3458 to develop new and reimplement old features with new feature matrix template.

Acceptance tests

ireneisdoomed commented 5 days ago

Because each feature has its own class now, they are documented at the code level so further documentation could go here. For example:

class EqtlColocClppMaximumFeature(L2GFeature):
    """Max CLPP for each (study, locus, gene) aggregating over all eQTLs."""

    feature_dependency_type = Colocalisation
    feature_name = "eQtlColocClppMaximum"

    @classmethod
    def compute(
    ...