Promote features for new L2G feature matrix

project-defiant commented 2 months ago

As a user I want document and refactor list of features included in the new feature matrix because I want to document them properly and test the feature template interface.

Background

Refactoring of the feature matrix https://github.com/opentargets/issues/issues/3252 allows genetics team to revisit the implementation of existing L2G features described in https://github.com/opentargets/issues/issues/3458

Tasks

This task is the continuation of #3458 to develop new and reimplement old features with new feature matrix template.

[ ] New features are implemented
[ ] Old features are reimplemented

Acceptance tests

[ ] All L2G features follow the template
[ ] All L2G features have it's own documentation and explanation

ireneisdoomed commented 2 months ago

Because each feature has its own class now, they are documented at the code level so further documentation could go here. For example:

class EqtlColocClppMaximumFeature(L2GFeature):
    """Max CLPP for each (study, locus, gene) aggregating over all eQTLs."""

    feature_dependency_type = Colocalisation
    feature_name = "eQtlColocClppMaximum"

    @classmethod
    def compute(
    ...

addramir commented 2 months ago

This issue overlaps with others. I suggest to start form table created and curated by @xyg123 . Could you please share it?

addramir commented 2 months ago

We need to re-write this issue next week.

addramir commented 2 months ago

Can we delete this issue as it is a duplication?

opentargets / issues