opentargets / issues

Issue tracker for Open Targets Platform and Open Targets Genetics Portal
https://platform.opentargets.org https://genetics.opentargets.org
Apache License 2.0
12 stars 2 forks source link

Adapt Platform FE to upcoming Genetics Portal data #816

Closed d0choa closed 4 years ago

d0choa commented 4 years ago

Front-end changes necessary to allocate the Genetics Portal data in the Platform Details TBC.

andrewhercules commented 4 years ago

I have created an iInitial mockup of the Genetic Associations (Common Diseases) data table and it is available on the team Google Drive.

Based on a preliminary review by @DSuveges, @d0choa, and @edm1, a few questions remain open for discussion:

  1. Can we obtain the reported trait information for GWAS Catalog and PheWAS Catalog evidence string data?
  2. Can we obtain the author and year of the publication for GWAS Catalog and PheWAS Catalog evidence string data?
  3. For rows with L2G data, we can link the variant ID to the variant page on the Genetics Portal. However, for rows without L2G data, we could continue to link to Ensembl or can we determine if the RSID entry exists in the Genetics Portal?

In order to deploy the mockup into production, it will require:

DSuveges commented 4 years ago

Some of these values are not yet exported by the GWAS team, I send an email to them so they can fix their pipeline. The newly added values are:

andrewhercules commented 4 years ago

Based on feedback from the team and a review of the data from the API (example), I have updated the data table design for the new L2G data - see below:

Screenshot 2020-02-19 at 15 54 15

@LucaFumis, here are the design notes for each column in the data table:

Disease For both PheWAS data and the Open Targets Genetics Portal L2G data, please display disease.efo_info.label and hyperlink to the Platform disease profile page using the disease.id value.

Reported trait name For PheWAS Catalog data: please display N/A. For Open Targets Genetics Portal L2G data: please display disease.reported_trait

Publications For both PheWAS data and the Open Targets Genetics Portal L2G data, please implement the existing functionality - number of publications badge and a link to EuropePMC

Variant For PheWAS Catalog data: please implement the existing functionality of displaying the RSID and hyperlink to Ensembl. For Open Targets Genetics Portal L2G data: please display variant.rs_id value and hyperlink to the Genetics Portal using the variant.source_link value.

Variant type For both PheWAS data and the Open Targets Genetics Portal L2G data, please implement the existing functionality (note: please ignore the SO_0001060 issue which will be resolved in the rewrite)

Association p-value For PheWAS Catalog data: please implement the existing functionality of displaying the p-value using the evidence.variant2disease.resource_score.value value. For Open Targets Genetics Portal L2G data: please display the p-value as a string using the evidence.variant2disease.resource_score.mantissa + e + evidence.variant2disease.resource_score.exponent.

Odds ratio (confidence) Please drop this column.

Gene prioritisation score For PheWAS Catalog data: please display N/A. For Open Targets Genetics Portal L2G data: please display the L2G pipeline score in evidence.gene2variant.resource_score.value.

Evidence source For PheWAS Catalog data: please implement the existing functionality of displaying PheWAS Catalog and linking to their website. For Open Targets Genetics Portal L2G data: please display Open Targets Genetics Portal and hyperlink to the study-locus page in the Genetics Portal - for example https://genetics.opentargets.org/study-locus/GCST004610/19_1026478_G_T. To construct this link, please extract the study ID from evidence.variant2disease.study_link and combine with the variant ID value in variant.id.

Also, can we please ensure that the table is sorted as it currently is in production - from highest to lowest p-value score?

andrewhercules commented 4 years ago

I have reviewed the current implementation on QA and it looks great! 👍

Screenshot 2020-02-24 at 11 30 55

@LucaFumis, can we please make a few updates:

  1. By default, sort the data table by the Gene Prioritisation Score
  2. In the Reported Trait column, link to the value to the study page on the Genetics Portal using the evidence.variant2disease.study_link value
  3. Create a tooltip with placeholder for the Gene Prioritisation Score (text will be confirmed once documentation is ready)
  4. In the Variant column, display the RSID and if possible, for Genetics Portal data, hyperlink to the Genetics Portal using the variant.source_link value.
  5. Drop the Variant type column (Note: we were previously able to map the SO terms, but I wonder if the new data has broken this logic. @d0choa and I have discussed and if the logic has been broken, we can simply remove this column from the table)
  6. For the OT Genetics Portal link in the Evidence Source column, hyperlink to the study-locus page in the Genetics Portal (e.g. https://genetics.opentargets.org/study-locus/GCST004610/19_1026478_G_T). To construct this link, please extract the study ID from evidence.variant2disease.study_link and combine with the variant ID value in variant.id.
d0choa commented 4 years ago

2 extra notes in case we resolve all the above issues:

d0choa commented 4 years ago

Keep in mind there were issues before with the variant type resolver #757

LucaFumis commented 4 years ago

Yes exactly, the variant type seems a data issue - the field evidence.evidence_codes_info is null. We can simply hide the field for now and leave all the logic there.

LucaFumis commented 4 years ago

Regarding point 4, it seems that for genetics portal data the rsid is not always available. I've updated the table to show when avail.

d0choa commented 4 years ago

The mantissa and exponent work is still pending. It will finish the work started in #434

A reference example: https://qa.targetvalidation.org/evidence/ENSG00000146374/EFO_0009270?view=sec:genetic_association