Closed d0choa closed 4 years ago
I have created an iInitial mockup of the Genetic Associations (Common Diseases) data table and it is available on the team Google Drive.
Based on a preliminary review by @DSuveges, @d0choa, and @edm1, a few questions remain open for discussion:
In order to deploy the mockup into production, it will require:
Some of these values are not yet exported by the GWAS team, I send an email to them so they can fix their pipeline. The newly added values are:
Based on feedback from the team and a review of the data from the API (example), I have updated the data table design for the new L2G data - see below:
@LucaFumis, here are the design notes for each column in the data table:
Disease
For both PheWAS data and the Open Targets Genetics Portal L2G data, please display disease.efo_info.label
and hyperlink to the Platform disease profile page using the disease.id
value.
Reported trait name
For PheWAS Catalog data: please display N/A.
For Open Targets Genetics Portal L2G data: please display disease.reported_trait
Publications For both PheWAS data and the Open Targets Genetics Portal L2G data, please implement the existing functionality - number of publications badge and a link to EuropePMC
Variant
For PheWAS Catalog data: please implement the existing functionality of displaying the RSID and hyperlink to Ensembl.
For Open Targets Genetics Portal L2G data: please display variant.rs_id
value and hyperlink to the Genetics Portal using the variant.source_link
value.
Variant type For both PheWAS data and the Open Targets Genetics Portal L2G data, please implement the existing functionality (note: please ignore the SO_0001060 issue which will be resolved in the rewrite)
Association p-value
For PheWAS Catalog data: please implement the existing functionality of displaying the p-value using the evidence.variant2disease.resource_score.value
value.
For Open Targets Genetics Portal L2G data: please display the p-value as a string using the evidence.variant2disease.resource_score.mantissa
+ e + evidence.variant2disease.resource_score.exponent
.
Odds ratio (confidence) Please drop this column.
Gene prioritisation score
For PheWAS Catalog data: please display N/A.
For Open Targets Genetics Portal L2G data: please display the L2G pipeline score in evidence.gene2variant.resource_score.value
.
Evidence source
For PheWAS Catalog data: please implement the existing functionality of displaying PheWAS Catalog and linking to their website.
For Open Targets Genetics Portal L2G data: please display Open Targets Genetics Portal
and hyperlink to the study-locus page in the Genetics Portal - for example https://genetics.opentargets.org/study-locus/GCST004610/19_1026478_G_T. To construct this link, please extract the study ID from evidence.variant2disease.study_link
and combine with the variant ID value in variant.id
.
Also, can we please ensure that the table is sorted as it currently is in production - from highest to lowest p-value score?
I have reviewed the current implementation on QA and it looks great! 👍
@LucaFumis, can we please make a few updates:
evidence.variant2disease.study_link
value variant.source_link
value.evidence.variant2disease.study_link
and combine with the variant ID value in variant.id
.2 extra notes in case we resolve all the above issues:
Keep in mind there were issues before with the variant type resolver #757
Yes exactly, the variant type seems a data issue - the field evidence.evidence_codes_info
is null
.
We can simply hide the field for now and leave all the logic there.
Regarding point 4, it seems that for genetics portal data the rsid is not always available. I've updated the table to show when avail.
The mantissa and exponent work is still pending. It will finish the work started in #434
A reference example: https://qa.targetvalidation.org/evidence/ENSG00000146374/EFO_0009270?view=sec:genetic_association
Front-end changes necessary to allocate the Genetics Portal data in the Platform Details TBC.