opentripmodel / otm5-change-requests

Tracking and reporting bugs and change requests of the OTM5 specification.
5 stars 1 forks source link

TransportEquipmentTypeConstraint #46

Closed thomaskolmans closed 2 years ago

thomaskolmans commented 2 years ago

Type of request

Is your feature request related to a problem? Not able to create a constraint for a TransportEquipmentType

Describe the solution you'd like A new ConstraintValue type namely TransportEquipmentTypeConstraint with an array of possible types. Just like VehicleTypeConstraint and FuelTypeConstraint are constructed.

So a Constraint with that type it will look something like:

{
   "name": "Name of constraint", 
   "value": {
       "type": "transportEquipmentTypeConstraint",
       "transportEquipmentTypes": ["trailer"]
   }
}

Describe alternatives you've considered None - don't see a valid alternative to be honest.

bmeesters commented 2 years ago

Hello Thomas, thanks for your contribution again. I will discuss it, but I also don't really see an alternative, so I expect this can go in. Though note that everything for OTM5.3 is closed since we are going to release it next week and this will not have had enough time for others to provide alternatives or counter arguments.

bmeesters commented 2 years ago

Hello @thomaskolmans, we discussed it and it makes sense to add this constraint. If possible, can you elaborate how you would use this addition? Is this for transport orders? For trips that need some trailer? I also assume we also want to leverage equipmentSubType so you can indicate what kind of trailer(s)?

thomaskolmans commented 2 years ago

This is for Consignment and Trip maybe even Location. Yes, the equipmentSubType would also come in handy

bmeesters commented 2 years ago

This is now part of OTM5.4