search

opentripmodel / otm5-change-requests

Tracking and reporting bugs and change requests of the OTM5 specification.
5 stars 1 forks source link

FuelStation and Terminal location type #73

Open thomaskolmans opened 1 year ago

thomaskolmans commented 1 year ago

Type of request

Is your feature request related to a problem? The model currently does not support fuelStation location types nor terminal.

Describe the solution you'd like Adding fuelStation and terminal as a types to the LocationType enum. For integration purposes and also with the addition of the fuel action, this seems like a logical addition.

Describe alternatives you've considered None

nlenlited commented 1 year ago

We actually need to be able to use OTM for Maritime transport.

bmeesters commented 1 year ago

Thank again for your contribution @thomaskolmans. Both make sense to me. (though I do wonder what the exact definition is of a terminal). Lets discuss it next meeting.

bmeesters commented 1 year ago

Accepted, we might want to consider more types as well before the next release

bmeesters commented 1 year ago

Maybe it is a good idea to also make an other type and include a otherLocationType field that can be filled in that case like we do for fuel? Though I am in favor of being complete the problem is that there always will be very specific types for certain operations that will not make it into OTM.

bmeesters commented 11 months ago

@woutvandenheuvel is going to look into existing code lists and see how we can integrate that with the existing enum.

bmeesters commented 3 months ago

After discussion this is accepted. Even though we expect more types to be needed in the future