openzim / python-libzim

Libzim binding for Python: read/write ZIM files in Python
https://pypi.org/project/libzim/
GNU General Public License v3.0
62 stars 19 forks source link

Reorganize wrapper and add search and suggestion #119

Closed mgautierfr closed 2 years ago

mgautierfr commented 2 years ago

New update of python-libzim.

This PR is pretty big.

Better to review commit by commit as the whole change is pretty complex.

Unit tests have been update with last version of the testing zim files.

mgautierfr commented 2 years ago

The failing unit test is fixed in https://github.com/openzim/libzim/pull/625

rgaudin commented 2 years ago

The failing unit test is fixed in openzim/libzim#625

Great! Once this is merged we'll update the nightly we build against

kelson42 commented 2 years ago

@rgaudin @mgautierfr What is the review process/status.

codecov[bot] commented 2 years ago

Codecov Report

Merging #119 (1c7c7ce) into update-libzim (38e2114) will increase coverage by 0.71%. The diff coverage is 97.82%.

Impacted file tree graph

@@                Coverage Diff                @@
##           update-libzim     #119      +/-   ##
=================================================
+ Coverage          97.11%   97.82%   +0.71%     
=================================================
  Files                  3        1       -2     
  Lines                312      414     +102     
=================================================
+ Hits                 303      405     +102     
  Misses                 9        9              
Impacted Files Coverage Δ
libzim/libzim.pyx 97.82% <97.82%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a0b305...1c7c7ce. Read the comment docs.

rgaudin commented 2 years ago

@mgautierfr, tests are now passing

rgaudin commented 2 years ago

@mgautierfr I also squeezed-in a tiny commit to set the charset on add_metadata's default mimetype. We can add that separately but since it's harmless…