search

openzim / python-libzim

Libzim binding for Python: read/write ZIM files in Python
https://pypi.org/project/libzim/
GNU General Public License v3.0
62 stars 19 forks source link

Allow setting mimetype for metadata #128

Closed rgaudin closed 2 years ago

rgaudin commented 2 years ago

While the _Creator allows setting the mimetype in add_metadata(), with a default value, it is overriden in Creator without such ability.

This exposes the mimetype parameter in Creator.add_metadata() so any user can set the mimetype. Default value is thus moved there.

codecov[bot] commented 2 years ago

Codecov Report

Merging #128 (6c74338) into master (d511870) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files           1        1           
  Lines         416      416           
=======================================
  Hits          407      407           
  Misses          9        9
Impacted Files Coverage Δ
libzim/libzim.pyx 97.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d511870...6c74338. Read the comment docs.