finalize must be always called.

openzim / python-libzim

Libzim binding for Python: read/write ZIM files in Python

https://pypi.org/project/libzim/

GNU General Public License v3.0

62 stars 20 forks source link

Closed mgautierfr closed 4 years ago

mgautierfr commented 4 years ago

There are two issues here :

One on libzim assuming that the finalize method will be call before deletion of the creator.
test_libzim.py not calling the finalize method.

For the second point, the more pythonic way to solve this is to use a contextmanager to force the call to finalize in the __exit__ method.