Debian package fails to compile

openzim / python-libzim

Libzim binding for Python: read/write ZIM files in Python

https://pypi.org/project/libzim/

GNU General Public License v3.0

60 stars 19 forks source link

Debian package fails to compile #160

Closed kelson42 closed 1 year ago

kelson42 commented 1 year ago

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028780

kelson42 commented 1 year ago

I can not investigate right now, but:

either there is a problem in getMediaCount() declaration in libzim OR
Debian compiles against an older version of the libzim and the we have a requirement problem (in package definition and in compilation script): we should require libzim 8.1.0+

rgaudin commented 1 year ago

https://salsa.debian.org/debian/python-libzim/-/blob/master/debian/control specifies libzim-dev (>= 8.1.0),

paulgevers commented 1 year ago

https://salsa.debian.org/debian/python-libzim/-/blob/master/debian/control specifies libzim-dev (>= 8.1.0),

That is currently insufficient as you can see from the name 8.1.0+really8.0.0-1. The package of zimlib had to be reverted to 8.0.0 but package version can only go up: https://tracker.debian.org/news/1408038/accepted-zimlib-810really800-1-source-into-unstable/

kelson42 commented 1 year ago

Seems to be a pure packaging problem - but not sure about the root cause - not sure there is anything we can do here.

mgautierfr commented 1 year ago

The "revert" to really8.0.0-1 seems to be a workaround because of https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027565

It seems this commit https://github.com/openzim/libzim/commit/1aca07b29d3936f4928b861d9184ac449a6e75d5 introduce a ABI breaking change as we remove zim::Item::getPath method when defining the method in the header (quick investigation here). I should have been more careful about that and release a 9.0.0 version (or delay the change).

I suggest we revert the commit and publish a hot fix 8.1.1 release. (@legoktm, @xvitaly, you are the known packagers of libzim, is it ok for you ?)

xvitaly commented 1 year ago

I suggest we revert the commit and publish a hot fix 8.1.1 release. (@legoktm, @xvitaly, you are the known packagers of libzim, is it ok for you ?)

Breaking an ABI in a patch release is certainly not good, but not a problem for Fedora because we always rebuild all dependent packages in the Kiwix dependency subtree.

mgautierfr commented 1 year ago

It is not breaking ABI in patch release (we re-add a missing method). It is undo a breaking ABI (introduced in a minor release) with a patch release. API is not broken in any 8.* version.

xvitaly commented 1 year ago

It is not breaking ABI in patch release (we re-add a missing method). It is undo a breaking ABI (introduced in a minor release) with a patch release.

Looks good for me.

kelson42 commented 1 year ago

Fixed in libzim and available in libzim 8.1.1