Closed legoktm closed 1 year ago
@legoktm thank you for bringing this up. It should indeed be limited to the download part.
@legoktm please let us know if there's anything else preventing debian packaging as we're about to make a release.
Nope this was it, thanks!
In https://github.com/openzim/python-libzim/commit/ded83079dcaf4735a727bcc57d908820dc2a5746 the check for a supported platform was moved from the download_libzim function to something that runs for all builds, regardless of whether you're downloading libzim or using system libzim.
Context: in Debian we're currently building libzim for a very diverse set of architectures: https://buildd.debian.org/status/package.php?p=libzim and python-libzim built on all of those architectures too.
When I try to build on i386 (via CI), I get an error like:
Should the platform check be moved back to the download function or is there some other reason python-libzim should only be built for x86_64 and aarch64?