search

openzim / python-libzim

Libzim binding for Python: read/write ZIM files in Python
https://pypi.org/project/libzim/
GNU General Public License v3.0
60 stars 19 forks source link

Add wrapper on `creator.addAlias`. #175

Closed mgautierfr closed 7 months ago

mgautierfr commented 8 months ago

Need https://github.com/openzim/libzim/pull/833 Blocked by https://github.com/openzim/libzim/issues/837

mgautierfr commented 7 months ago

Adapted to add_alias.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7c62b0c) 93.52% compared to head (4842bc7) 93.44%.

Files Patch % Lines
libzim/libzim.pyx 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #175 +/- ## ========================================== - Coverage 93.52% 93.44% -0.09% ========================================== Files 1 1 Lines 510 519 +9 ========================================== + Hits 477 485 +8 - Misses 33 34 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgautierfr commented 7 months ago

Should be ok to merge now ?

kelson42 commented 7 months ago

This PR is blocked by https://github.com/openzim/libzim/issues/837 (written in description)

rgaudin commented 7 months ago

I merged with the nightly (that's usual for this repo) but we need a release of libzim to release pylibzim to release scraperlib… to integrate in warc2zim