search

openzim / python-libzim

Libzim binding for Python: read/write ZIM files in Python
https://pypi.org/project/libzim/
GNU General Public License v3.0
67 stars 25 forks source link

Rely on proper libzim version 9.1.0 #184

Closed kelson42 closed 11 months ago

kelson42 commented 11 months ago

Substainable implementation of #175 (Use stable libzim release)

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (88ddf31) 93.44% compared to head (f5f1ee1) 93.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #184 +/- ## ======================================= Coverage 93.44% 93.44% ======================================= Files 1 1 Lines 519 519 ======================================= Hits 485 485 Misses 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rgaudin commented 11 months ago

FYI the PR was not OK ; it didn't change the libzim version used for release ; fixing that on main before releasing

kelson42 commented 11 months ago

@rgaudin OK. Current system is error prone. Libzim version should be defined only in one place and ideally not as an env. variable.

rgaudin commented 11 months ago

I agree. We actually have it in code and the env is here to allow changing it easily. Maybe we should remove them from the workflows.