remove metadata conversion

openzim / python-libzim

Libzim binding for Python: read/write ZIM files in Python

https://pypi.org/project/libzim/

GNU General Public License v3.0

60 stars 19 forks source link

remove metadata conversion #190

Open aryanA101a opened 4 months ago

aryanA101a commented 4 months ago

Fixes #188

aryanA101a commented 4 months ago

@rgaudin Sorry, my bad. Actually, I ran the tests after the modification but didn't install the project.

kelson42 commented 3 months ago

@aryanA101a Any update?

rgaudin commented 3 months ago

converted to draft to prevent accidental merge

benoit74 commented 3 months ago

I don't think this is sufficient: type hints should be simplified as well to explicitly mention these methods support only bytes and str values now (i.e. conversion must be done by python-scraperlib or any other "user")

rgaudin commented 3 months ago

Thank you @benoit74 ; that's right and I forgot @aryanA101a to mention that you should not force-push after having asked for a review ; it makes (and made in that case) reviewing a real pain.

rgaudin commented 3 months ago

@aryanA101a please update type hints as suggested